From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 851F943B59 for ; Thu, 18 Aug 2022 02:34:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A15D68B962; Thu, 18 Aug 2022 05:34:36 +0300 (EEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9A11668B889 for ; Thu, 18 Aug 2022 05:34:29 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660790074; x=1692326074; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=v0gbAaNcpWc5W1dLo/6fsa1Z98EeI61KapkvdZL4DGI=; b=mWcqf+1ME81N+h/t6FgTTwh6zqf5wVVatgsu7SR0OMrlbjgo7dEXgY4E fwD2gyq2QxDOcGyw5hmJBmLSKWQSq6X55fAw/giGj/u35YCOIOlOAOe5T U1J3FuyHe518ylpX2oNXLg2JNG0BdqUEpJerG+w4Flbj+z9D03NTWznyh Sh7erYP2i+nLllb9mk3hw4/4ntdJx68BjyZCLRPMLsFJ+wA7nWLrCSkDp FmeS3qI7s71Z1PUfVCXjYpZt2Z6N/ACZOLyh1qcq/SPnvlMwu6zxJGGL9 jjQZ2cnAbH/8Fsnw/4nNZ7PC2ktKob4nE04KGJmfdJMDpYzkikd/EkQVA g==; X-IronPort-AV: E=McAfee;i="6500,9779,10442"; a="293441265" X-IronPort-AV: E=Sophos;i="5.93,245,1654585200"; d="scan'208";a="293441265" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2022 19:34:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,245,1654585200"; d="scan'208";a="584016876" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 17 Aug 2022 19:34:27 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 17 Aug 2022 19:34:27 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 17 Aug 2022 19:34:27 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Wed, 17 Aug 2022 19:34:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqHgpqdKGg8pZ7L+RmdNKXhfZ4OjG8t2hgrrFZPQ5d3Ul/g2T/ZutvAM0jbRMyiRfNapHqlOySgY87vI2/pxtt1UnphQlQ9mkQQqJtpTvjD+ze3SGmWLMiR9STqWDAigI1nhEW0687Fn7R8oOKw1LBD35GYIe7C6icnSnM+1SRtwHGHACYZqR1Jpu4pt/gOYwWZazxT1KCJUg5dVAanITm6PdgJELxoKJRVf+oMn8ra6gM5v0D//c26AyCn8ka0MpvO1V4SaUIQElM735lEEYDTfXXmC0f/q9bcxSC7lkcPHCPtXaBCiclnOeVITFe169wCIojiSeqKcbKQJr44a4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v0gbAaNcpWc5W1dLo/6fsa1Z98EeI61KapkvdZL4DGI=; b=MHsRlLBzbKVVVRb6DA29fu5azpYwcCm4g9V9BaYMXhJOkaHdG+kboTOcthVemAuouUFY95DDiRloo2YtjYq9ewtBMpa7LjhCtELfXLrwOnX/vUm8lT/WjhNxk5AoIf2D/C0pnAZELZ6fi5DT7f5DhWBf5PocMvUxsxySHapOHCjelBo0PkmuSlGLjdasEJ4pzHBkdRgq43ETAykbDMdAqu/TFsoOD9oI65flFy46nVV/pKpj0yYaDx098iPJ2lHIfur8+t5sg4lGLyVOVcMG3hmEP8mbm+EWfz6R99uJWIF5Os82kz2FT3BcqtSAKeUwrnh2jdHS0UekICRlQ019PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by BL1PR11MB5365.namprd11.prod.outlook.com (2603:10b6:208:308::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.19; Thu, 18 Aug 2022 02:34:25 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::bd7e:47b5:e014:2c0f]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::bd7e:47b5:e014:2c0f%9]) with mapi id 15.20.5525.010; Thu, 18 Aug 2022 02:34:24 +0000 From: "Wang, Fei W" To: "anton@khirnov.net" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v1 1/3] lavc/decode: Add get_hw_config function Thread-Index: AQHYrkrPndgONk11RU67cFMBTmJ9+q2xaGSAgAKQ94A= Date: Thu, 18 Aug 2022 02:34:24 +0000 Message-ID: <83c524cdc71e033c828068cfc0c8f38cb2b912ce.camel@intel.com> References: <20220812125545.1229410-1-fei.w.wang@intel.com> <166064895716.3205.18227206247708899551@lain.khirnov.net> In-Reply-To: <166064895716.3205.18227206247708899551@lain.khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a56d58b-29d8-448e-e669-08da80c22a56 x-ms-traffictypediagnostic: BL1PR11MB5365:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 41s5G9rAFtH7eemlPsYTsDlVQOc1UIbP2TC0TdEXCorsnhBL19vEMbm7BF9JTvBIxyD9odihB0avR4JHPhpHOMUmfYAnozzABBPAqQws45EjSgBm54bi27oO2/76MyoaMgl/ECeFk0RkcYZ6L54DTuHOlNEouw5uvV0jOctUINqbNTrrnDd96/F+sdehwjRRtl2sh7fzoH4/+h3Wn6OltDhU7xBFseA2RtXCWNmznYYrEO0dt7hEjJ0T27a+d5M8Xv4EmMoOanbLGPilVnDTdCJSh2DGTRESWryGSaLCy/YA87yW6CcY0nHFNW8v1LBriTX80VctHITy2c81I7IjKzjvvVBehBVV19V7FLsFwOMHOUcHY+RJFqurG/FmvuB/GSZ5WGYzpifjRieQUjiCwcHyAgzoflquuij5QmgkMKqSqKZ+4fByCz75tF5YKj+T/nREMmPHY4252e5lkyb5k4/CAvhuytY93miazNj+dtGEVxokeWC/k3/KO3RpdufNYdCB8F6B9WX52Yl0jl8R6U/x1+ygRI2kKLTFQcNld9O/yLfmK3yivH4TsfbnQQrCsm0BEoi04Ux7uDTr2m/Vo6PFDx+eNx06td8UFlRR6MXWb/LzEc4U4PgQVxydIKTl+1fP8IzvxGD/ayDkoJ37r/BEhFOfX5cXaSH2KJwLOgXDwPQdcMZtWSPCqM83yljHSEpuz0c0HFCS4Tu+Sw2ZxG5hE2iDVSc1aDDDH54otBebxTxt3DPivJzEvD6nH+Z7cNRjoWDnj3FkZ2wbXYtFUg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(346002)(396003)(366004)(39860400002)(136003)(82960400001)(5660300002)(36756003)(478600001)(91956017)(71200400001)(107886003)(316002)(110136005)(41300700001)(2906002)(6486002)(66946007)(64756008)(66556008)(66476007)(76116006)(8936002)(66446008)(8676002)(4326008)(38100700002)(38070700005)(186003)(6512007)(2616005)(6506007)(86362001)(26005)(122000001)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q0ZMWGQ0N2xiRDY0YnppZnhndmtPNW5lSGdOS1E5akRYMlpqbTdjWDhEUEIy?= =?utf-8?B?UkIvL0pzd0JyZTZYa2RHd1o5KzZTZ3h6Q0QzSHNKRkh1elFYZkhCVEsvcURS?= =?utf-8?B?NVZYQkpMQU8xdVNxcUkweC9Sb1VtK0hSQUJSSTZzUEFlN0IwQjZLK3J6U2dW?= =?utf-8?B?K0hDUVo0ZDdJcEhBNFhhYitocHRqTURxNjF5cE4vYWNlLzMxNEdsWnZpOHMx?= =?utf-8?B?NVBxQ2dGY3Q5SG5uMWtOZDU3TlNBSU5yeWd2UG5hdlV2WVhwdDY1TkVHM2Rm?= =?utf-8?B?RDh0RWlaTlZFVUZiOG5TRHVPZVMveHJTb2UwM3h0Q2tiWVBuOWFtS0Q3M0l5?= =?utf-8?B?b1hqVGlZVVg2S1Z1NHdIV0dDMGZrRk02SzBjcmRhZkNZOERIVjM2Y3JhK2dI?= =?utf-8?B?U3lVZHNhdW02NkljRWFYYkFCc3BmM0VYeWRHLzZHMUFpWGdTcnZObGNnU3dm?= =?utf-8?B?aU4xSGRRVk1KVklHNTJKUlJPakxpVGViYXduaTU4WlVLNXRYT2hIcHlXRVNM?= =?utf-8?B?MjB1T0szWEdkTHBvVmpLeXlHUHM4c0NFR2xBZ1ZFNzNXVVBsWlBpem02dktm?= =?utf-8?B?Q0t4cjlZZUZQaTk1cjNxNmZkNWkrQmNEOG13blhIcjQ4TE1qZ2VxZ0xOWnRk?= =?utf-8?B?Nndmc2I1Z1dEdEIvRTdzZUJLZzFzNXZ0OVZlbit3NmFheXVuRUFibmpqQSs2?= =?utf-8?B?SnhzeGlPUFRVRW1QUWVGeWtjQTlLdFJnRGFJeFcxWjRCYitYR3JOKy9FeWhu?= =?utf-8?B?TXMzOXJZQmxNd25ic0p4d21GbFIxcEszdUQ4M2hNNWVXMkRlVFFWNHhsUVJs?= =?utf-8?B?dW45YUpsZGpGakRwVXE3UTB5NTdNZE16eHV5a2haVDZDVlBTcUZ3YnNSaDJj?= =?utf-8?B?aG5rc0JsUGdCcmNFOUVxd2IyNFdBakg0bUtnOHdsYTVMd1NqUldyaVJYU3l5?= =?utf-8?B?S0NpdzdlZTNDbHowZDVqNjgvTGdvZ3BMa0xEOVErdC9PbEhsQXd1YTZoOWVR?= =?utf-8?B?QVh5YXJaQmxBVXJXZnV5L1NJRVdNdWhqTmZEUldkR2NXb1lhVk0vblJFM0JL?= =?utf-8?B?UE5Rei8vV3ZRYTZtMCtYcEhrWFBmQ244dmpZZVNKL1A2MzJNVE01NFE2ZWtZ?= =?utf-8?B?ek5CcklIME4ramE2RHA1Z1FnK09oeHVXRDdmVzRBNVVrUTEyZzJMd3ZzM2FD?= =?utf-8?B?a3dJUVNuVitpbjlrZDdpU05RcXNzdWYyMkZ0dGpxa2RvYi9UWlpvOTNtMVhC?= =?utf-8?B?RXVrYmdPUC9LVEJMb1Q5S1RicmVDcWdPRVFhazlKOXk5ZnJ4ZlEyckd2RTFh?= =?utf-8?B?eWQ0NmRpZ3ZEZVozMDlrL3pvb1ZPS010U0FvdElOU2JMN2x6YkpBZk4wcmtV?= =?utf-8?B?dThHcjIxMlQ5a3I3U0tRdXhrMGtSSUNuLytmQzNUd042WXJ6ejcxQmlrWW1x?= =?utf-8?B?a2FVbmRxMjJTQnJlck05dXhIeVRkQTU1UWsrU2FTQk5yZWZYYjJ6Q05pa0NF?= =?utf-8?B?dStLb3pGTmt0Tys0ZTI2R0tEa0YrSDUxdnFDaFN4a3hsWUM5OTdhUDBjYXdN?= =?utf-8?B?U3dCRVZxSFBHdkdOTkdKcHA1UWJFMDZrcndTWVI0L1QwcDBuTEl5MVNrb01w?= =?utf-8?B?T0ZzbWhHQUxQcVErSzFJckl5KzREcEh0NGJpV0R2QTV0dVVoZzJTNWxSUWUx?= =?utf-8?B?VUJrTXUvc0ROMmw3ZU5Tc21vbnR3K0JRWjVaUGNTamNxLzBTNXY1a1diME1W?= =?utf-8?B?Z1VCU1J0OXhoRFBqaFNvQjh4clpTY2JiZ2lPd2ZGa0lhbE1kdS81K0EvVzlp?= =?utf-8?B?U3U1SE1TbXc0QWdyRXlPZlBNRG9Bd3FZMUN6S2xMVjlKQUdKMllvMjIwVzQy?= =?utf-8?B?MDd6a2cyaG5SNW82M2dSUkMzVzlEanEzbHJFdGVWKzVPUnphU3h3S3NrRi9h?= =?utf-8?B?Rll3T3QvWEtSbGhHbmtsWnk1b3p0ZURucGxyRkozempRem9wZGxMWTI1bG9L?= =?utf-8?B?d055ZUJrQUR5bHFwc21FdmU0a09xbk9uQnJMWU5DSnZPWFJuRUtwY3duUmlt?= =?utf-8?B?bi9id044VGE4a1BvTFVBdjlKWlBhTURQYVBRaDRVN3dmNHBmOG11b0JiVnpO?= =?utf-8?B?RHE3MWxHTldtMzB4Uis5Wmx1YzU0OW50Vk16QUtqbE92QVB6aHZxeHZFZjV1?= =?utf-8?B?cUE9PQ==?= Content-ID: <23A2EB051A5D7C4A9DDD463379C21DDD@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a56d58b-29d8-448e-e669-08da80c22a56 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2022 02:34:24.8226 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7kywel84e6qBeu9M3o0CffAH+keTZ7cjAFZBp8OTW4kIFWxifQF558YPsCOyAGftyhO9MWJF1QMwJGQo4g0JPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5365 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v1 1/3] lavc/decode: Add get_hw_config function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "linjie.fu@intel.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-08-16 at 13:22 +0200, Anton Khirnov wrote: > The commit message is misleading - you are not adding code, you are > moving code. > > Quoting Fei Wang (2022-08-12 14:55:43) > > From: Linjie Fu > > > > Wrap the procedure of getting the hardware config from a pixel > > format > > into a function. > > > > Signed-off-by: Linjie Fu > > Signed-off-by: Fei Wang > > --- > > libavcodec/decode.c | 33 +++++++++++++++++++++------------ > > 1 file changed, 21 insertions(+), 12 deletions(-) > > > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > > index 75373989c6..d66d5a4160 100644 > > --- a/libavcodec/decode.c > > +++ b/libavcodec/decode.c > > @@ -1156,6 +1156,26 @@ static void hwaccel_uninit(AVCodecContext > > *avctx) > > av_buffer_unref(&avctx->hw_frames_ctx); > > } > > > > +static const AVCodecHWConfigInternal *get_hw_config(AVCodecContext > > *avctx, enum AVPixelFormat fmt) > > +{ > > + const AVCodecHWConfigInternal *hw_config; > > + int i; > > Should be declared in the loop > > > + if (ffcodec(avctx->codec)->hw_configs) { > > + for (i = 0;; i++) { > > + hw_config = ffcodec(avctx->codec)->hw_configs[i]; > > + if (!hw_config) > > + break; > > return NULL; > > > + if (hw_config->public.pix_fmt == fmt) > > + break; > > return hw_config; > > > + } > > + } else { > > + hw_config = NULL; > > + } > > You can save one level of indentation by starting with > > if (!ffcodec(avctx->codec)->hw_configs) > return NULL; Fix in V2. Thanks Fei > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".