Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed - Lynne via ffmpeg-devel

From: Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Lynne <dev@lynne.ee>
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lpc: copy levenson coeffs only when they have been computed
Date: Sun, 12 May 2024 02:13:06 +0200
Message-ID: <83bec738-e2dc-41a3-88af-a53ab6958628@lynne.ee> (raw)
In-Reply-To: <20240512000349.3381912-1-michael@niedermayer.cc>

On 12/05/2024 02:03, Michael Niedermayer wrote:
> Fixes: CID1473514 Uninitialized scalar variable
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>   libavcodec/lpc.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c
> index 8305cc0596a..981dacce8a5 100644
> --- a/libavcodec/lpc.c
> +++ b/libavcodec/lpc.c
> @@ -282,8 +282,9 @@ int ff_lpc_calc_coefs(LPCContext *s,
>           double av_uninit(weight);
>           memset(var, 0, FFALIGN(MAX_LPC_ORDER+1,4)*sizeof(*var));
>   
> -        for(j=0; j<max_order; j++)
> -            m[0].coeff[max_order-1][j] = -lpc[max_order-1][j];
> +        if (lpc_passes > 1)
> +            for(j=0; j<max_order; j++)
> +                m[0].coeff[max_order-1][j] = -lpc[max_order-1][j];
>   
>           for(; pass<lpc_passes; pass++){
>               avpriv_init_lls(&m[pass&1], max_order);

max_order is a function argument, I don't think that's the right place 
to fix this.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".