From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D84F84215A for ; Thu, 16 Dec 2021 16:17:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 39D5968AE5A; Thu, 16 Dec 2021 18:16:59 +0200 (EET) Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DBC5568A3AD for ; Thu, 16 Dec 2021 18:16:52 +0200 (EET) Received: by mail-qk1-f172.google.com with SMTP id m186so23761031qkb.4 for ; Thu, 16 Dec 2021 08:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=IEGCFNn8GkY+5E1FL61Irutfo4qgvzotXxeAtFeJrOc=; b=I0v1Y7FnXgt3fCrVScqg4chpJq4+a8H6ZW3XzPT5qIKJ1npKKh41kPIUq0LLhT1QAY foYdayzcIrePxf27l9V8HnHQsYUPZcqSt3ssXc6zurEk/mWMn+iU8RjjXuBJkJWbqnZv seq8NIkCvdAyaXbEHRTPCLQaBNRgVVYjdnjA9QXtxLskTKNlZ22iuhKWXFDplNS+OaFc 42BsxxgN6dE1MZv/i+fjqstHL8PKgPeZgyg14ATGdQ3c+w4cf4Yxa4pgppILKDjqk8CD vNIixqwAsTUArXFmH42TXGvzFDX8dDkHoDZcNJ19D7weJaCvJbCJDRcENnbSGQW67kRF HwPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=IEGCFNn8GkY+5E1FL61Irutfo4qgvzotXxeAtFeJrOc=; b=gKE8A8e9PMJ2isTy1+QrcIZPw8Id6g2Hztm0nHPbzIIwFyZMuF9kJUy2VzlXWOonFH 1nLLFHDamwmFkFNf8aI87UdUBJYLWfHqYw3Tq5LKgkGO8Bd6hNWd5T6NtSDsTeO7CjLh d0WvXanLBGQD0W+9GSgBlck6yg2yLJyn+NUxX5LlhqomfIps/9VBKz9Vx3n8BCIEXQ04 LSsn51x635Kkqe4/I1SR3Kcrpor0n8/RGpm2X7RStBkhj0xj0OY/iobOjpHhXugx/Esc flb/CuT+bNr37aAoOwYFvCcFEViN9VFhqbsqhESZxDdPXXK7XDGom/1XEyYSbOZ228af dMQg== X-Gm-Message-State: AOAM532xpIO2PQB2B8P9OZ8TaHQ4GBp01FcnVZgxt+m/ZoUH2oYEVwcn RFrY2TA++/NEhmyUXumDKRlZ2nQsQSjLPg== X-Google-Smtp-Source: ABdhPJykwPLXh4Mc9DOeDO3RUJGuZHVBbkvsPlKyvQTsQgDRpvqxhiy4kw5p2JRsppYu/tNSk/yV3A== X-Received: by 2002:a05:620a:c4f:: with SMTP id u15mr12693197qki.565.1639671411169; Thu, 16 Dec 2021 08:16:51 -0800 (PST) Received: from [192.168.0.13] ([181.170.250.138]) by smtp.gmail.com with ESMTPSA id bj32sm3006316qkb.75.2021.12.16.08.16.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Dec 2021 08:16:50 -0800 (PST) Message-ID: <83bd66ac-bfd8-badd-d861-09a82d2bbba5@gmail.com> Date: Thu, 16 Dec 2021 13:16:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20211216160548.2035835-1-alankelly@google.com> From: James Almer In-Reply-To: <20211216160548.2035835-1-alankelly@google.com> Subject: Re: [FFmpeg-devel] [PATCH] x86/swscale: fix minor coding style issues X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/16/2021 1:05 PM, Alan Kelly wrote: > --- > libswscale/x86/swscale.c | 14 +++++++------- > tests/checkasm/sw_scale.c | 3 +-- > 2 files changed, 8 insertions(+), 9 deletions(-) > > diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c > index 164b06d6ba..c49a05c37b 100644 > --- a/libswscale/x86/swscale.c > +++ b/libswscale/x86/swscale.c > @@ -578,13 +578,13 @@ switch(c->dstBpc){ \ > break; \ > } > > - if (EXTERNAL_AVX2_FAST(cpu_flags)){ > - if ((c->srcBpc == 8) && (c->dstBpc <= 14)){ > - if(c->chrDstW % 16 == 0) > - ASSIGN_AVX2_SCALE_FUNC(c->hcScale, c->hChrFilterSize); > - if(c->dstW % 16 == 0) > - ASSIGN_AVX2_SCALE_FUNC(c->hyScale, c->hLumFilterSize); > - } > + if (EXTERNAL_AVX2_FAST(cpu_flags)) { > + if ((c->srcBpc == 8) && (c->dstBpc <= 14)) { > + if (c->chrDstW % 16 == 0) > + ASSIGN_AVX2_SCALE_FUNC(c->hcScale, c->hChrFilterSize); > + if (c->dstW % 16 == 0) > + ASSIGN_AVX2_SCALE_FUNC(c->hyScale, c->hLumFilterSize); > + } > } > > if (EXTERNAL_AVX2_FAST(cpu_flags)) { > diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c > index 011cb46428..f4912e6c2c 100644 > --- a/tests/checkasm/sw_scale.c > +++ b/tests/checkasm/sw_scale.c > @@ -217,9 +217,8 @@ static void check_hscale(void) > } > ff_sws_init_scale(ctx); > memcpy(filterAvx2, filter, sizeof(uint16_t) * (SRC_PIXELS * MAX_FILTER_WIDTH + MAX_FILTER_WIDTH)); > - if (cpu_flags & AV_CPU_FLAG_AVX2){ > + if (cpu_flags & AV_CPU_FLAG_AVX2) > ff_shuffle_filter_coefficients(ctx, filterPosAvx, width, filterAvx2, SRC_PIXELS); > - } > > if (check_func(ctx->hcScale, "hscale_%d_to_%d_width%d", ctx->srcBpc, ctx->dstBpc + 1, width)) { > memset(dst0, 0, SRC_PIXELS * sizeof(dst0[0])); Applied, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".