From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] x86/swscale: fix minor coding style issues
Date: Thu, 16 Dec 2021 13:16:48 -0300
Message-ID: <83bd66ac-bfd8-badd-d861-09a82d2bbba5@gmail.com> (raw)
In-Reply-To: <20211216160548.2035835-1-alankelly@google.com>
On 12/16/2021 1:05 PM, Alan Kelly wrote:
> ---
> libswscale/x86/swscale.c | 14 +++++++-------
> tests/checkasm/sw_scale.c | 3 +--
> 2 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c
> index 164b06d6ba..c49a05c37b 100644
> --- a/libswscale/x86/swscale.c
> +++ b/libswscale/x86/swscale.c
> @@ -578,13 +578,13 @@ switch(c->dstBpc){ \
> break; \
> }
>
> - if (EXTERNAL_AVX2_FAST(cpu_flags)){
> - if ((c->srcBpc == 8) && (c->dstBpc <= 14)){
> - if(c->chrDstW % 16 == 0)
> - ASSIGN_AVX2_SCALE_FUNC(c->hcScale, c->hChrFilterSize);
> - if(c->dstW % 16 == 0)
> - ASSIGN_AVX2_SCALE_FUNC(c->hyScale, c->hLumFilterSize);
> - }
> + if (EXTERNAL_AVX2_FAST(cpu_flags)) {
> + if ((c->srcBpc == 8) && (c->dstBpc <= 14)) {
> + if (c->chrDstW % 16 == 0)
> + ASSIGN_AVX2_SCALE_FUNC(c->hcScale, c->hChrFilterSize);
> + if (c->dstW % 16 == 0)
> + ASSIGN_AVX2_SCALE_FUNC(c->hyScale, c->hLumFilterSize);
> + }
> }
>
> if (EXTERNAL_AVX2_FAST(cpu_flags)) {
> diff --git a/tests/checkasm/sw_scale.c b/tests/checkasm/sw_scale.c
> index 011cb46428..f4912e6c2c 100644
> --- a/tests/checkasm/sw_scale.c
> +++ b/tests/checkasm/sw_scale.c
> @@ -217,9 +217,8 @@ static void check_hscale(void)
> }
> ff_sws_init_scale(ctx);
> memcpy(filterAvx2, filter, sizeof(uint16_t) * (SRC_PIXELS * MAX_FILTER_WIDTH + MAX_FILTER_WIDTH));
> - if (cpu_flags & AV_CPU_FLAG_AVX2){
> + if (cpu_flags & AV_CPU_FLAG_AVX2)
> ff_shuffle_filter_coefficients(ctx, filterPosAvx, width, filterAvx2, SRC_PIXELS);
> - }
>
> if (check_func(ctx->hcScale, "hscale_%d_to_%d_width%d", ctx->srcBpc, ctx->dstBpc + 1, width)) {
> memset(dst0, 0, SRC_PIXELS * sizeof(dst0[0]));
Applied, thanks.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2021-12-16 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 16:05 Alan Kelly
2021-12-16 16:09 ` Alan Kelly
2021-12-16 16:16 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bd66ac-bfd8-badd-d861-09a82d2bbba5@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git