Re: [FFmpeg-devel] [PATCH v3 3/5] avformat/hls: relay programs to child muxers

From: Gyan Doshi <ffmpeg@gyani.pro>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3 3/5] avformat/hls: relay programs to child muxers
Date: Sat, 18 Feb 2023 10:21:16 +0530
Message-ID: <83b929cf-061e-ce62-8764-9a3d78133148@gyani.pro> (raw)
In-Reply-To: <46224f44-2eca-f8d3-2ba8-3a849337d5bb@passwd.hu>

On 2023-02-18 03:31 am, Marton Balint wrote:
>
>
> On Fri, 17 Feb 2023, Gyan Doshi wrote:
>
>> ---
>> libavformat/hlsenc.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
>> index e1f96feda3..cf2b36da01 100644
>> --- a/libavformat/hlsenc.c
>> +++ b/libavformat/hlsenc.c
>> @@ -911,6 +911,14 @@ FF_ENABLE_DEPRECATION_WARNINGS
>>         st->id = vs->streams[i]->id;
>>     }
>>
>> +    for (i = 0; i < s->nb_programs; i++) {
>> +        ret = av_program_copy(oc, (const AVFormatContext *)s, 
>> s->programs[i]->id, 0);
>> +        if (ret < 0) {
>> +            av_log(s, AV_LOG_WARNING, "unable to transfer program %d 
>> to child muxer\n", s->programs[i]->id);
>
> Aren't these errors supposed to be propagated back as hard failures, 
> instead of simply ignoring them? The next 2 patches also has this 
> problem.

Updated in v4.

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".