From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 12E344A275
	for <ffmpegdev@gitmailbox.com>; Sat, 27 Apr 2024 20:47:34 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5185968D29E;
	Sat, 27 Apr 2024 23:47:31 +0300 (EEST)
Received: from btbn.de (btbn.de [144.76.60.213])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CA14968D220
 for <ffmpeg-devel@ffmpeg.org>; Sat, 27 Apr 2024 23:47:23 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id
 34B0927FFD7E6
 for <ffmpeg-devel@ffmpeg.org>; Sat, 27 Apr 2024 22:47:21 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1714250841;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=fLkJWi6LK8dx1CFqEotso12CeKEFxTd84OVO5FAdKfc=;
 b=pZYkvzuAYJ4wQud5M7YDobqGjjrAYJiZk7qUiU57RyhI+803M/yrcRBXy5JTBktyOi1Xvy
 q9BlAmVv5q/ALHGVdLZNHoHdSkxlnA2ohRN6HKIEUnNRAAEqyGgIUeK4Z1YlleVle343cq
 A9CaVuulOVVIDg0xVJquqRLjxhrM87NiFm2kdnc4C77eywT5Zz6btgzCJxbJd7pHkzwWGa
 uu5fDlwIO0DLAMnGr/uo5P3uC1KMQa/HoT/02oOAHxUvMh20IuoqUe2HQ1hOXKHsmW0Ru/
 4vqE4mMv4TZSr/j4UMQOYX+3SVv2byOTrITUImXNKwWCvx9xXWc4ufqqurgU9w==
Message-ID: <83aee046-92c7-4e4b-86d2-8105c9c4d900@rothenpieler.org>
Date: Sat, 27 Apr 2024 22:47:24 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: ffmpeg-devel@ffmpeg.org
References: <20240427134936.32677-1-timo@rothenpieler.org>
 <20240427201448.26469-1-timo@rothenpieler.org>
 <CAPBf_O=nSpoOdvS6+f7PCSzmKsuu7d1Rekz1mE+x0UhzrymBEQ@mail.gmail.com>
Content-Language: en-US
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <CAPBf_O=nSpoOdvS6+f7PCSzmKsuu7d1Rekz1mE+x0UhzrymBEQ@mail.gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH v2] configure: support msvc build inside
 WSL
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/83aee046-92c7-4e4b-86d2-8105c9c4d900@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 27.04.2024 22:21, Sean McGovern wrote:
> Aside: We are now that much closer to summoning a demon inside 'configure'
> *laughs*.

The reasoning behind this complexification in v2 is that v1 put the 
string returned by cl.exe into a shell, allowing potential injection 
vectors.

Granted, the injection would come from inside ffmpeg code, so probably 
all would be lost at that point anyway, but at the very least, this 
approach avoids spawning a bunch of subshells we don't need, though is 
quite a bit uglier.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".