From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3B9C54CBAC for ; Thu, 26 Jun 2025 22:27:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3B57368E686; Fri, 27 Jun 2025 01:27:33 +0300 (EEST) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id EEF1068E65F for ; Fri, 27 Jun 2025 01:27:31 +0300 (EEST) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-450cfb790f7so12215065e9.0 for ; Thu, 26 Jun 2025 15:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750976851; x=1751581651; darn=ffmpeg.org; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=6AIFP0IYq2bTWq65/YzRQklH9wMGTsnk/5XpdfWIsL0=; b=RdLkfffjKqyl2DGkrBHHtsXwKxPzVC4DhoE1GG91ZsD1jHumWFsb0Q9EChvWuVTH9y i/Pggs2BIhCHGSSd/5zcnUt8HCuIkIZKlBdY54uUrMyW2/6DKBjlx9AtZcEIH/xA36jY +5RYY+VtNsTHVK1748WbDyCZhd9SbC0Ghalb8Sf4l+ZlzBxC6Kk2B/a13e/YmQP5mWAM PsN4vNhfKwZ6Y3JMV8Qgaczm+k5aZHEjxZfZdf82hcp/ryuruZn+OPaNvdsiB7nPhDTO f4zA/wcPgaWnSPwL/F8LK+cK6yZdlxUi6NR4kGRrj8Y9qSrK4FKoZLLik1Hdi3oxX/Bs kQhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750976851; x=1751581651; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6AIFP0IYq2bTWq65/YzRQklH9wMGTsnk/5XpdfWIsL0=; b=aOaJV23oIuwZjQdnHcR2NAgS3+ZmUei+CrJtJexO/kOmJ5EuOGFk50T9F4K2wcf596 Ot/FzCYy4I0D3Pa45q54sua7kZJRZ78HebkAaCmQdeBOOeRUq52OYVW+OAnDnv6uP9Uq ygNCLvFlLSleip+4PYsMy4Wr4FwAVLTS3std15Rb+wv6PPrP8ZvcViiv9v7PIa0rwXZp FeyrqdZ1eQG8nQVdhOwC04tiD1Vyq36mWHIMFbnagNROG7X6144jyiviTf0DaOTq1wSc e7OgKR+aWupQuIIFgFKjv7eZFQBQV4CBmAloYo7LXLC+7wxJWXwURr8FPLk3wo09D2SW tFgw== X-Gm-Message-State: AOJu0YzSL7uXGyDYP+YeYF3KxSusGqJOTW8JOTkAnBrqrqFgJOBLgF1v oUP+ltu5T9We8QAMst1mFFQDRgIM3JDC7Js326CMhQsDbCpADOe2thnnvNvaYA== X-Gm-Gg: ASbGnct7G6lQ7NQ4KNCeLYYbF8oervLT6CA+9oWEnrUF/yAi6LUCLAuVexBkgb6ef0d VrcNrlzrn/IY8guqqyR8WItPiV3oGiZ6fiEfTJJNDTMCO7xJMEXWMKDVVMb6PcpugYbVtzDtWIC 9MXFG6BMUVbDchH69YiIiLI4WN2Vq5SLCVR7/TIj3PfhVTe84JjjKGBisA2rmhXc8gP4YkNfb5j FUsN/wMSx4dXDVZHCP8cbEXs4CzLMku21//Wt9SOs2UA4qDcDCus80MclIjmzgmnHiACWBJI7b9 oKk0u/iyccZSvNw3H1tUHR+QFBfYZoHwQ1Gklul2NonCbEDg0+QIRxuzKPHtjG6lkBPpTpX0Kwh g0PSPM9wru7QCNJYxR/MwOxFR4AHboFtjUHIxlxdb0Ten3ULiCq9iBBS/uQLWJ+B+ff9Fcmzsh/ g= X-Google-Smtp-Source: AGHT+IEgJn/pjD5+jhlJCDQJRnJyi8PG6T9qqniXiOdvQSs+sRA9fzpPg+sJwVy/FxxIEpIa9vXVAg== X-Received: by 2002:a05:600c:4685:b0:450:cff7:62f9 with SMTP id 5b1f17b1804b1-4538ee56520mr9021105e9.22.1750976850727; Thu, 26 Jun 2025 15:27:30 -0700 (PDT) Received: from [192.168.178.57] (p20030102370045007d7f230e46ac5795.dip0.t-ipconnect.de. [2003:102:3700:4500:7d7f:230e:46ac:5795]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a3fe0efsm31192995e9.24.2025.06.26.15.27.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jun 2025 15:27:30 -0700 (PDT) From: Marvin Scholz To: FFmpeg development discussions and patches Date: Fri, 27 Jun 2025 00:27:29 +0200 X-Mailer: MailMate (2.0r6222) Message-ID: <83CD04C5-1EF0-4A0A-A4F1-E4F868F6E955@gmail.com> In-Reply-To: References: <20250620110853.1448602-1-nicolas.gaullier@cji.paris> <20250620110853.1448602-2-nicolas.gaullier@cji.paris> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] fftools/textformat: renamings in print_unit_int for consistency (cosmetic) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 23 Jun 2025, at 0:10, softworkz . wrote: >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of >> Nicolas Gaullier >> Sent: Freitag, 20. Juni 2025 13:08 >> To: ffmpeg-devel@ffmpeg.org >> Cc: Nicolas Gaullier >> Subject: [FFmpeg-devel] [PATCH 2/2] fftools/textformat: renamings >> in print_unit_int for consistency (cosmetic) >> >> Signed-off-by: Nicolas Gaullier >> --- >> fftools/ffprobe.c | 2 +- >> fftools/graph/graphprint.c | 2 +- >> fftools/textformat/avtextformat.c | 4 ++-- >> fftools/textformat/avtextformat.h | 2 +- >> 4 files changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c >> index 1346ed33c5..e8cde01407 100644 >> --- a/fftools/ffprobe.c >> +++ b/fftools/ffprobe.c >> @@ -429,7 +429,7 @@ static void log_callback(void *ptr, int level, >> const char *fmt, va_list vl) >> #define print_ts(k, v) avtext_print_ts(tfc, k, v, 0) >> #define print_duration_time(k, v, tb) avtext_print_time(tfc, k, v, >> tb, 1) >> #define print_duration_ts(k, v) avtext_print_ts(tfc, k, v, >> 1) >> -#define print_val(k, v, u) avtext_print_unit_int(tfc, k, v, >> u) >> +#define print_val(k, v, u) avtext_print_unit_integer(tfc, k, >> v, u) >> >> #define REALLOCZ_ARRAY_STREAM(ptr, cur_n, new_n) >> \ >> { >> \ >> diff --git a/fftools/graph/graphprint.c >> b/fftools/graph/graphprint.c >> index e4c6886cf8..242eaf8ba1 100644 >> --- a/fftools/graph/graphprint.c >> +++ b/fftools/graph/graphprint.c >> @@ -140,7 +140,7 @@ typedef struct GraphPrintContext { >> #define print_q(k, v, s) avtext_print_rational(tfc, k, v, >> s) >> #define print_str(k, v) avtext_print_string(tfc, k, v, 0) >> #define print_str_opt(k, v) avtext_print_string(tfc, k, v, >> gpc->opt_flags) >> -#define print_val(k, v, u) avtext_print_unit_int(tfc, k, v, >> u) >> +#define print_val(k, v, u) avtext_print_unit_integer(tfc, k, >> v, u) >> >> #define print_fmt(k, f, ...) do { \ >> av_bprint_clear(&gpc->pbuf); \ >> diff --git a/fftools/textformat/avtextformat.c >> b/fftools/textformat/avtextformat.c >> index 14bad9022b..396fe2f853 100644 >> --- a/fftools/textformat/avtextformat.c >> +++ b/fftools/textformat/avtextformat.c >> @@ -437,11 +437,11 @@ static char *value_string(const >> AVTextFormatContext *tctx, char *buf, int buf_si >> } >> >> >> -void avtext_print_unit_int(AVTextFormatContext *tctx, const char >> *key, int64_t value, const char *unit) >> +void avtext_print_unit_integer(AVTextFormatContext *tctx, const >> char *key, int64_t val, const char *unit) >> { >> char val_str[128]; >> struct unit_value uv; >> - uv.val.i = value; >> + uv.val.i = val; >> uv.unit = unit; >> avtext_print_string(tctx, key, value_string(tctx, val_str, >> sizeof(val_str), uv), 0); >> } >> diff --git a/fftools/textformat/avtextformat.h >> b/fftools/textformat/avtextformat.h >> index 8316829af5..d9c14069eb 100644 >> --- a/fftools/textformat/avtextformat.h >> +++ b/fftools/textformat/avtextformat.h >> @@ -169,7 +169,7 @@ void avtext_print_integer(AVTextFormatContext >> *tctx, const char *key, int64_t va >> >> int avtext_print_string(AVTextFormatContext *tctx, const char >> *key, const char *val, int flags); >> >> -void avtext_print_unit_int(AVTextFormatContext *tctx, const char >> *key, int64_t value, const char *unit); >> +void avtext_print_unit_integer(AVTextFormatContext *tctx, const >> char *key, int64_t val, const char *unit); >> >> void avtext_print_rational(AVTextFormatContext *tctx, const char >> *key, AVRational q, char sep); >> >> -- > > Hi Nicolas, > > thanks for the patch. Makes sense and > LGTM. > > softworkz > Pushed as 18c62245d7883c28d3f8ee5fa587b45fd2e82013. Thanks. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".