Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/flvdec: support demux HEVC in Enhancing FLV

["Martin Storsjö" <martin@martin.st>]

On Fri, 7 Apr 2023, Steven Liu wrote:

> Martin Storsjö <martin@martin.st> 于2023年4月6日周四 21:20写道：
>>
>> On Thu, 6 Apr 2023, Steven Liu wrote:
>>
>> > Martin Storsjö <martin@martin.st> 于2023年4月6日周四 20:31写道：
>> >>
>> >> On Thu, 6 Apr 2023, Steven Liu wrote:
>> >>
>> >> > Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
>> >> > ---
>> >> > libavformat/flvdec.c | 63 +++++++++++++++++++++++++++++++++++++++-----
>> >> > 1 file changed, 56 insertions(+), 7 deletions(-)
>> >>
>> >> Even if the title of the linked document is "Enhancing RTMP, FLV" I kinda
>> >> would expect the name of the concept/format to be more like "Enhanced FLV"
>> >> (as the name of the repo is "enhanced-rtmp", not "enhancing-rtmp").
>> >>
>> >> So I'd kinda prefer to refer to it in that form in the commit subject and
>> >> in the comment in the text. If you want to use literally the name used in
>> >> the document, I guess that's "Enhancing RTMP, FLV" though.
>>
>> > Or submit three patches, BTW supprt the Enhanced rtmp?
>>
>> I don't really understand what you mean here and how this is a response to
>> my comment?
>
> I mean, What  should i do? Resubmit some patches for support the full
> functions which describe in documents?
> Or just modify comments in patch commit messages?

I'm just saying you should replace "Enhancing" with "Enhanced" in the 
commit message and code comment.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".