From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 5B9AC460A8 for ; Tue, 4 Jul 2023 09:03:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 50C0768C599; Tue, 4 Jul 2023 12:03:03 +0300 (EEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1704E68C4FC for ; Tue, 4 Jul 2023 12:02:57 +0300 (EEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 639BF3200A3A for ; Tue, 4 Jul 2023 05:02:54 -0400 (EDT) Received: from imap49 ([10.202.2.99]) by compute1.internal (MEProxy); Tue, 04 Jul 2023 05:02:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1688461373; x=1688547773; bh=WZim9D08kDHPs NKDinpBjhfin8inTw7njZvkgbPe/zg=; b=EtEKH9Unof7Ai7ZJ2Yq0EWmOQgVvz dOe3K6pSHD26oS375eMKOl2rGkpQNUA/mWJFUSVJy2tGcggvYwkuOMZJu1aHxrco /t9wx0ONjcwXX6CqS7VbADNtIJV68mbRv1MGI2RtqAS1ZCdin9eJ6fw5yWCi7aib rM8rBYOYPeJGctqtvuVJu/EghEcLtGycXn+MYOuo8J+cuhyRlzapFgBxxCcFExye CfKk2eCyQtpm3YWio45jKgM6uslxL+QAXtiICMvGYfIvH9Aod+CzIItGwbSxqtqM A7T4LF+ptToIokP49Ow18SHwYwhbcc+mBa0DERxcAXVjqUhaOAgv7CZMQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudeggddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddutddmnecujfgurhepofgfgg fkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdflvggrnhdquegrphhtihhs thgvucfmvghmphhffdcuoehjsgesvhhiuggvohhlrghnrdhorhhgqeenucggtffrrghtth gvrhhnpeeiiefgvdffteekkeffvdeiffeijeethfevteeutdegvdegfeekgfektdelheef gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjsg esvhhiuggvohhlrghnrdhorhhg X-ME-Proxy: Feedback-ID: i06904239:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id A1BC015A008E; Tue, 4 Jul 2023 05:02:53 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-527-gee7b8d90aa-fm-20230629.001-gee7b8d90 Mime-Version: 1.0 Message-Id: <830e6dd9-1f9e-48f2-83b8-f65c2fcf88e5@app.fastmail.com> In-Reply-To: <20230703230005.7755-1-michael@niedermayer.cc> References: <20230703230005.7755-1-michael@niedermayer.cc> Date: Tue, 04 Jul 2023 11:02:33 +0200 From: "Jean-Baptiste Kempf" To: ffmpeg-devel Subject: Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hello, On Tue, 4 Jul 2023, at 01:00, Michael Niedermayer wrote: > Suggested-by: Anton > > Signed-off-by: Michael Niedermayer > --- > doc/developer.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index 0c2f2cd7d1..67f7f78e86 100644 > --- a/doc/developer.texi > +++ b/doc/developer.texi > @@ -806,7 +806,7 @@ improves readability. > > @item > Consider adding a regression test for your code. All new modules > -should be covered by tests. That includes demuxers, muxers, decoders, encoders > +must be covered by tests. That includes demuxers, muxers, decoders, encoders > filters, bitstream filters, parsers. If its not possible to do that, add > an explanation why to your patchset, its ok to not test if theres a reason. +1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".