[FFmpeg-devel] [PATCH] test: tiny_ssim: Don't include config.h

[FFmpeg-devel] [PATCH] test: tiny_ssim: Don't include config.h

[Martin Storsjö]

tiny_ssim is built for the build host, not for the target platform.
Therefore, it mustn't include the config.h header, which is set up
specifically for the target platform and compiler.

This fixes cross building for older WinStore platforms, where
config.h contains "#define getenv(x) NULL".

Signed-off-by: Martin Storsjö <martin@martin.st>
---
 tests/tiny_ssim.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/tiny_ssim.c b/tests/tiny_ssim.c
index 08f8e92a03..9740652288 100644
--- a/tests/tiny_ssim.c
+++ b/tests/tiny_ssim.c
@@ -27,7 +27,6 @@
  * overlapped 8x8 block sums, rather than the original gaussian weights.
  */
 
-#include "config.h"
 #include <inttypes.h>
 #include <limits.h>
 #include <math.h>
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] test: tiny_ssim: Don't include config.h

[Martin Storsjö]

On Sun, 27 Mar 2022, Martin Storsjö wrote:

> tiny_ssim is built for the build host, not for the target platform.
> Therefore, it mustn't include the config.h header, which is set up
> specifically for the target platform and compiler.
>
> This fixes cross building for older WinStore platforms, where
> config.h contains "#define getenv(x) NULL".
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> tests/tiny_ssim.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/tiny_ssim.c b/tests/tiny_ssim.c
> index 08f8e92a03..9740652288 100644
> --- a/tests/tiny_ssim.c
> +++ b/tests/tiny_ssim.c
> @@ -27,7 +27,6 @@
>  * overlapped 8x8 block sums, rather than the original gaussian weights.
>  */
>
> -#include "config.h"
> #include <inttypes.h>
> #include <limits.h>
> #include <math.h>
> -- 
> 2.25.1

Acked by Lynne on irc, thus pushed.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".