From: "Martin Storsjö" <martin@martin.st>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] test: tiny_ssim: Don't include config.h
Date: Wed, 30 Mar 2022 15:05:55 +0300 (EEST)
Message-ID: <82f5eea0-28fe-fa62-1218-45b83e7715eb@martin.st> (raw)
In-Reply-To: <20220326220717.2526163-1-martin@martin.st>
On Sun, 27 Mar 2022, Martin Storsjö wrote:
> tiny_ssim is built for the build host, not for the target platform.
> Therefore, it mustn't include the config.h header, which is set up
> specifically for the target platform and compiler.
>
> This fixes cross building for older WinStore platforms, where
> config.h contains "#define getenv(x) NULL".
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> tests/tiny_ssim.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/tiny_ssim.c b/tests/tiny_ssim.c
> index 08f8e92a03..9740652288 100644
> --- a/tests/tiny_ssim.c
> +++ b/tests/tiny_ssim.c
> @@ -27,7 +27,6 @@
> * overlapped 8x8 block sums, rather than the original gaussian weights.
> */
>
> -#include "config.h"
> #include <inttypes.h>
> #include <limits.h>
> #include <math.h>
> --
> 2.25.1
Acked by Lynne on irc, thus pushed.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-03-30 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 22:07 Martin Storsjö
2022-03-30 12:05 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82f5eea0-28fe-fa62-1218-45b83e7715eb@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git