From: Marton Balint <cus@passwd.hu> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Subject: Re: [FFmpeg-devel] [PATCH 1/5] avcodec/mpeg4videoenc: use MpegEncContext->picture_number instead of encode function parameter Date: Thu, 26 Jan 2023 20:45:14 +0100 (CET) Message-ID: <82d975ab-a374-e62d-1bcb-264d66b55aa2@passwd.hu> (raw) In-Reply-To: <20230124001322.23263-1-cus@passwd.hu> On Tue, 24 Jan 2023, Marton Balint wrote: > They should be the same and that is what most encode functions use. Applied the series. Regards, Marton > > Signed-off-by: Marton Balint <cus@passwd.hu> > --- > libavcodec/mpeg4videoenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpeg4videoenc.c b/libavcodec/mpeg4videoenc.c > index a2a14afbd0..e327334d59 100644 > --- a/libavcodec/mpeg4videoenc.c > +++ b/libavcodec/mpeg4videoenc.c > @@ -1065,7 +1065,7 @@ int ff_mpeg4_encode_picture_header(MpegEncContext *s, int picture_number) > if (!(s->avctx->flags & AV_CODEC_FLAG_GLOBAL_HEADER)) { > if (s->avctx->strict_std_compliance < FF_COMPLIANCE_VERY_STRICT) // HACK, the reference sw is buggy > mpeg4_encode_visual_object_header(s); > - if (s->avctx->strict_std_compliance < FF_COMPLIANCE_VERY_STRICT || picture_number == 0) // HACK, the reference sw is buggy > + if (s->avctx->strict_std_compliance < FF_COMPLIANCE_VERY_STRICT || s->picture_number == 0) // HACK, the reference sw is buggy > mpeg4_encode_vol_header(s, 0, 0); > } > if (!(s->workaround_bugs & FF_BUG_MS)) > -- > 2.35.3 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-01-26 19:45 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-24 0:13 Marton Balint 2023-01-24 0:13 ` [FFmpeg-devel] [PATCH 2/5] avcodec/rv20enc: " Marton Balint 2023-01-24 0:13 ` [FFmpeg-devel] [PATCH 3/5] avcodec/mpegvideo: remove picture_number parameter from encode functions Marton Balint 2023-01-24 0:13 ` [FFmpeg-devel] [PATCH 4/5] avcodec/ratecontrol: drop remnants of libxvid rate control Marton Balint 2023-01-24 0:13 ` [FFmpeg-devel] [PATCH 5/5] avcodec/ffv1: use 64-bit frame counter Marton Balint 2023-01-26 19:45 ` Marton Balint [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=82d975ab-a374-e62d-1bcb-264d66b55aa2@passwd.hu \ --to=cus@passwd.hu \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git