From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id A264540247
	for <ffmpegdev@gitmailbox.com>; Sat, 19 Feb 2022 21:43:22 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4169268B0EE;
	Sat, 19 Feb 2022 23:43:21 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4CBC068AFDC
 for <ffmpeg-devel@ffmpeg.org>; Sat, 19 Feb 2022 23:43:15 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 21JLhE8u015459-21JLhE8v015459
 for <ffmpeg-devel@ffmpeg.org>; Sat, 19 Feb 2022 23:43:14 +0200
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id 4CD7DA1430
 for <ffmpeg-devel@ffmpeg.org>; Sat, 19 Feb 2022 23:43:14 +0200 (EET)
Date: Sat, 19 Feb 2022 23:43:14 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20220219154831.GW2829255@pb2>
Message-ID: <82d346b-2dc7-6df3-4b4d-a2662febe2b1@martin.st>
References: <20220218144546.43231-1-martin@martin.st>
 <20220219154831.GW2829255@pb2>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [FFmpeg-devel] [PATCH] swscale: Take the destination range into
 account for yuv->rgb->yuv conversions
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/82d346b-2dc7-6df3-4b4d-a2662febe2b1@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Sat, 19 Feb 2022, Michael Niedermayer wrote:

> On Fri, Feb 18, 2022 at 04:45:46PM +0200, Martin Storsj=F6 wrote:
>> The range parameters need to be set up before calling
>> sws_init_context (which selects which fastpaths can be used;
>> this gets called by sws_getContext); solely passing them via
>> sws_setColorspaceDetails isn't enough.
>>
>> This fixes producing full range YUV range output when doing
>> YUV->YUV conversions between different YUV color spaces.
>>
>> Signed-off-by: Martin Storsj=F6 <martin@martin.st>
>> ---
>>  libswscale/utils.c | 11 ++++++++---
>>  1 file changed, 8 insertions(+), 3 deletions(-)
>
> Probably ok
>
> please add a fate test for this

Sure. I'm not offhand familiar with what kinds of tests we have for =

swscale right now, and where a test for this would fit in best. (It's =

reproducible by converting from e.g. BT601 to BT709 or vice versa, when =

the output is supposed to be full range.)

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".