From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1FA4C496AA for ; Sat, 18 May 2024 11:27:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 42F1B68CDE5; Sat, 18 May 2024 14:27:44 +0300 (EEST) Received: from mail.comstyle.com (speedy.comstyle.com [206.51.28.2]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8FEBE68CC58 for ; Sat, 18 May 2024 14:27:38 +0300 (EEST) Received: from mail.comstyle.com (localhost [127.0.0.1]) by mail.comstyle.com (Postfix) with ESMTP id 4VhM4m3VFBz8PbP for ; Sat, 18 May 2024 07:27:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=comstyle.com; h= message-id:date:mime-version:subject:from:to:references :in-reply-to:content-type:content-transfer-encoding; s=default; bh=dH9xsSJRLNonSish1nPLRcfDw5InWrzNiw1GyDX0wqg=; b=H9q0Z+D5uzcD hnvOlGSi/Wufcvhlzu6uEG81QWT/mEVZxp2E1bwmvFsl7B/8YHzH4olkZu8O/0ei Fdn5hrFGp9Jjdgzzs5wAvI6Ocvgbl2j12kecLtpAoP5ow3PNyzLnA7ys/fdLPfUG Js4gefnSrJWacAsnRl9RWdJNJRcd3m0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=comstyle.com; h=message-id :date:mime-version:subject:from:to:references:in-reply-to :content-type:content-transfer-encoding; q=dns; s=default; b=Hrv f75wOwmjoPswlJ8Vf6SFmdwqYcFO2M2ggkUcA8q9830wnumKvc/yEDw+Hejd/L4N m99DY/pbsdRbOTWeHloKquLXIsbOII6sW3P2Uab/MQhlCCBRRIbOm5EtAcuDv7UU sEquWqJ/3BQl2Qg8LE/CWGmGnlGuWPsNubljryCk= Received: from [IPV6:2001:470:b050:6:c5dc:3a19:94a2:c45b] (unknown [IPv6:2001:470:b050:6:c5dc:3a19:94a2:c45b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: brad) by mail.comstyle.com (Postfix) with ESMTPSA id 4VhM4m0lG7z8PbN for ; Sat, 18 May 2024 07:27:36 -0400 (EDT) Message-ID: <82c8dff4-2bd6-47e1-8615-dcc5e29815f7@comstyle.com> Date: Sat, 18 May 2024 07:27:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Brad Smith To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Use proper field type for second parameter of ioctl() with BSD's X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Can this be backported to 7, 6, 5 and 4.4 releases? On 2024-05-05 11:59 p.m., Brad Smith wrote: > lavd/v4l2: Use proper field type for second parameter of ioctl() with BSD's > > The proper type was used until 73251678c83cbe24d08264da693411b166239bc7. > > This covers all of the OS's that currently have V4L2 support, permutations > of Linux glibc/musl, Android bionic, FreeBSD, NetBSD, OpenBSD, Solaris. > > Copied from FreeBSD ports patch. > > Signed-off-by: Brad Smith > --- > libavdevice/v4l2.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavdevice/v4l2.c b/libavdevice/v4l2.c > index 3706582bc6..74f43ef6a9 100644 > --- a/libavdevice/v4l2.c > +++ b/libavdevice/v4l2.c > @@ -108,10 +108,10 @@ struct video_data { > int (*open_f)(const char *file, int oflag, ...); > int (*close_f)(int fd); > int (*dup_f)(int fd); > -#ifdef __GLIBC__ > - int (*ioctl_f)(int fd, unsigned long int request, ...); > -#else > +#if defined(__sun) || defined(__BIONIC__) || defined(__musl__) /* POSIX-like */ > int (*ioctl_f)(int fd, int request, ...); > +#else > + int (*ioctl_f)(int fd, unsigned long int request, ...); > #endif > ssize_t (*read_f)(int fd, void *buffer, size_t n); > void *(*mmap_f)(void *start, size_t length, int prot, int flags, int fd, int64_t offset); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".