From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 71C0D48549 for ; Sat, 6 Jan 2024 17:39:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2999B68CCCF; Sat, 6 Jan 2024 19:39:44 +0200 (EET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 26EE068CBC3 for ; Sat, 6 Jan 2024 19:39:38 +0200 (EET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6d9e62ff056so546248b3a.1 for ; Sat, 06 Jan 2024 09:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704562775; x=1705167575; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fa9RPTU5ey9qDEcZz58IGrtt+husEzr59/euCALApek=; b=UJZEDdgJBuKF+7xCSoThtODAP66ygwpOWthV7JPjNRLEDaiDh4oaWKZEZafkkIDowx NeyAZ1rNtNDTYIY+WIPUqSvDwwcuyWR7ey+U5f6XuinrM8SAzuvwzAE+4j6pxjXESm7D XL+z4LskS7gRWaJ1eSY3Xqk9AkwnGcfVEk06a8YCx185FijljGr26wlPnahz19OK3SYQ dtwz4WbfanAG0XNhSRht2e0UbgEJzYiAqQtFnpJ0HnYJxLExrivZf+Tn25QXkNuHDEOA J1bc6ZrtJWwiF7iCmj9kIHa/QXNEA5poVM1DRFbcizi6z45pZIrwOoSJHMSNGo/l8uPP R9bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704562775; x=1705167575; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fa9RPTU5ey9qDEcZz58IGrtt+husEzr59/euCALApek=; b=hNYJIZanOtUVA8QIVIQ6rok227PvjJdSGlNGmQx9zaj4eZxSFcEw8PwirOn1EswQkH HFyE+S/iPIE4gQW3ZrfHmffSVfl3RobsXyOVrttiI5fn5vYtLR8/5stvwF783P58RCrm cmT16xTS8hus85XP6r1BzJ6DoF5jeuGx0/qnMFbybKIAwFpafY1I/2AmK8IGQpU4AT3E pq/oLLAuDZouYTPqceZYZZ5WN9HUbpr2QfCMHl+lDo5vOcr4B/oIlRU86pOiNv3TDVqC S8iJ37xXeXxOOr+zYAE5c+o3AgLFoq/IFb/zibg8TK+xia8npLiOsM2xpfVEizCm5lpz epig== X-Gm-Message-State: AOJu0YweYV3aaLJVYZtiIcNQxigol7noTlilIb6l2DB6fDmMqQv5nRUG 0qeF3nSo78Ij0Xn3WIrZFWXg+nCD4rQ= X-Google-Smtp-Source: AGHT+IFAvhwdQKqJWisvOX+DF9puxCRuM4VPadIeJxTj4VTLpyuD++7HTzfSQ74A5ELNOiO4FGypNw== X-Received: by 2002:a05:6a20:5089:b0:196:29d0:72e1 with SMTP id l9-20020a056a20508900b0019629d072e1mr1090214pza.104.1704562775206; Sat, 06 Jan 2024 09:39:35 -0800 (PST) Received: from [192.168.0.13] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id d3-20020a634f03000000b0058901200bbbsm3187789pgb.40.2024.01.06.09.39.34 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Jan 2024 09:39:34 -0800 (PST) Message-ID: <82761741-27f5-49dd-8bf9-0127f4688993@gmail.com> Date: Sat, 6 Jan 2024 14:39:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20231216081322.53623-1-thilo.borgmann@mail.de> <20231216081322.53623-2-thilo.borgmann@mail.de> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: <20231216081322.53623-2-thilo.borgmann@mail.de> Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter: Add fsync filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 12/16/2023 5:13 AM, Thilo Borgmann via ffmpeg-devel wrote: > --- > Changelog | 1 + > MAINTAINERS | 1 + > configure | 2 + > doc/filters.texi | 33 +++++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/version.h | 2 +- > libavfilter/vf_fsync.c | 286 +++++++++++++++++++++++++++++++++++++++ > 8 files changed, 326 insertions(+), 1 deletion(-) > create mode 100644 libavfilter/vf_fsync.c [...] > +static int activate(AVFilterContext *ctx) > +{ > + FsyncContext *s = ctx->priv; > + AVFilterLink *inlink = ctx->inputs[0]; > + AVFilterLink *outlink = ctx->outputs[0]; > + > + int ret, line_count; > + AVFrame *frame; > + > + FF_FILTER_FORWARD_STATUS_BACK(outlink, inlink); > + > + buf_skip_eol(s); > + line_count = buf_get_line_count(s); > + if (line_count < 0) { > + line_count = buf_reload(s); > + if (line_count < 0) > + return line_count; > + line_count = buf_get_line_count(s); > + if (line_count < 0) > + return line_count; > + } > + > + if (avio_feof(s->avio_ctx) && buf_get_zero(s) < 3) { > + av_log(ctx, AV_LOG_DEBUG, "End of file. To zero = %i\n", buf_get_zero(s)); > + goto end; > + } > + > + if (s->last_frame) { > + ret = av_sscanf(s->cur, "%"PRId64" %"PRId64" %d/%d", &s->ptsi, &s->pts, &s->tb_num, &s->tb_den); > + if (ret != 4) { > + av_log(ctx, AV_LOG_ERROR, "Unexpected format found (%i / 4).\n", ret); > + ff_outlink_set_status(outlink, AVERROR_INVALIDDATA, AV_NOPTS_VALUE); > + return AVERROR_INVALIDDATA; > + } > + > + av_log(ctx, AV_LOG_DEBUG, "frame %lli ", s->last_frame->pts); > + > + if (s->last_frame->pts >= s->ptsi) { > + av_log(ctx, AV_LOG_DEBUG, ">= %lli: DUP LAST with pts = %lli\n", s->ptsi, s->pts); > + > + // clone frame > + frame = av_frame_clone(s->last_frame); > + if (!frame) { > + ff_outlink_set_status(outlink, AVERROR(ENOMEM), AV_NOPTS_VALUE); > + return AVERROR(ENOMEM); > + } > + > + // set output pts and timebase > + frame->pts = s->pts; > + frame->time_base = av_make_q((int)s->tb_num, (int)s->tb_den); > + > + // advance cur to eol, skip over eol in the next call > + s->cur += line_count; > + > + // call again > + if (ff_inoutlink_check_flow(inlink, outlink)) > + ff_filter_set_ready(ctx, 100); > + > + // filter frame > + return ff_filter_frame(outlink, frame); > + } else if (s->last_frame->pts < s->ptsi) { > + av_log(ctx, AV_LOG_DEBUG, "< %lli: DROP\n", s->ptsi); > + av_frame_free(&s->last_frame); > + > + // call again > + if (ff_inoutlink_check_flow(inlink, outlink)) > + ff_filter_set_ready(ctx, 100); > + > + return 0; > + } > + } > + > +end: > + ret = ff_inlink_consume_frame(inlink, &s->last_frame); There's a leak in this filter, and i suspect it's here. If s->last_frame is not NULL, the pointer will be rewritten and the frame will leak. http://fate.ffmpeg.org/history.cgi?slot=x86_64-archlinux-gcc-valgrind-no-undef > + if (ret < 0) > + return ret; > + > + FF_FILTER_FORWARD_STATUS(inlink, outlink); > + FF_FILTER_FORWARD_WANTED(outlink, inlink); > + > + return FFERROR_NOT_READY; > +} _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".