From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7A09842671 for ; Mon, 21 Mar 2022 21:27:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 705F868B187; Mon, 21 Mar 2022 23:27:50 +0200 (EET) Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F013568AF33 for ; Mon, 21 Mar 2022 23:27:48 +0200 (EET) Received: by mail-oo1-f49.google.com with SMTP id o22-20020a4ad156000000b00324910b18d2so4825524oor.7 for ; Mon, 21 Mar 2022 14:27:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=I+nDSxUu+Fg9Lj0vh18KqbXGq+KQm9uxUAy5yeKK3XY=; b=QVAF7cLSzDnnn4+LVCd/k5lrEPI0tMw4BNk3GaCkJPZOg3iuYbbP17kPU6iUn12bd6 SqobgwQcLlS6US3O7AYDQF3u7f70M6MRuaMZZwUKfUmz/VI8ividD6asoBikFaW3oevv Ah/GdS6EkbTN5KFSb8UVI/MlDPqXg9gADn5UyCQU+N9w4kCe42Qt5DQRX0v6ruC3a8cg zLg+xFFF9R/tR4pYWx/Fzpkoeg3/bUANBU4sZbo2FO0JzViaWCDisQri8FS7BCvx1JRl hIYIt++TARYmZd+f8keRAtMFafDPUMIhjPvEx2SftlIk51qjdvHHLmb8uAWvrXRevL+u tMoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=I+nDSxUu+Fg9Lj0vh18KqbXGq+KQm9uxUAy5yeKK3XY=; b=gCVIt2k5WntrN7XUuhFx5UIDYd7spqAzdfa0REyifR75LvUfRyEf1p7q53WZ8Z3yUD QeB2IypNoAk+kZ95jcDA4Fji8n7ivrs6uzU0uEleKm6Pdc0yg934+o4xRD9fvFFpOaU8 CDtMSEhL+O7NYgQuogHYmdfwzc/kRy9SscJB0/gtp7KaX7Qos+zk35tAWqud6sShGYkm FpZw1MbdYbZbR+Xv72uD6yf/Q5KZ6vAD7TFD1Jr6Tljal9cTvJGxN48MYHDVJSz/t75M k+VtJ36s1soQ5U8zXv5MuZlhP4YTXGt72z2Eb+pkapzcuNI/ZFJ4uih85z2mTnxwxSAh lnuw== X-Gm-Message-State: AOAM533qztIRYGOj7jjjMJbpBFfMbKYpVrFVA6Hfl2yfwcDccSW4NWyl PYFb1WpXJicFiafpUn7+OltHkoKJsdS1Ng== X-Google-Smtp-Source: ABdhPJwXOrR7Yq15yybZO3E/ow7FgihOT/LfQ6hlw1RoxL0fOltnMRKDG4/HE5AnCflHdehNAt+QMw== X-Received: by 2002:a05:6870:5708:b0:db:2ef8:f220 with SMTP id k8-20020a056870570800b000db2ef8f220mr456929oap.198.1647898066916; Mon, 21 Mar 2022 14:27:46 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id bb15-20020a056820160f00b0032404d7a88esm7779554oob.27.2022.03.21.14.27.45 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 14:27:46 -0700 (PDT) Message-ID: <822fa38f-2e72-2f11-8ab4-fe27c2ea2843@gmail.com> Date: Mon, 21 Mar 2022 18:27:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220320201523.51516-1-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg: make the ac option set the demuxer's ch_layout AVOption X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/21/2022 6:12 PM, Andreas Rheinhardt wrote: > James Almer: >> channels is deprecated on all supported raw demuxers. >> >> Signed-off-by: James Almer >> --- >> fftools/ffmpeg_opt.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c >> index 720a3cc46a..213a34eadc 100644 >> --- a/fftools/ffmpeg_opt.c >> +++ b/fftools/ffmpeg_opt.c >> @@ -1122,7 +1122,9 @@ static int open_input_file(OptionsContext *o, const char *filename) >> if (file_iformat && (priv_class = file_iformat->priv_class) && >> av_opt_find(&priv_class, "channels", NULL, 0, >> AV_OPT_SEARCH_FAKE_OBJ)) { >> - av_dict_set_int(&o->g->format_opts, "channels", o->audio_channels[o->nb_audio_channels - 1].u.i, 0); >> + char buf[32] = ""; >> + av_strlcatf(buf, sizeof(buf), "%dC", o->audio_channels[o->nb_audio_channels - 1].u.i); > > snprintf; it also avoids the initialization. Changed locally. > >> + av_dict_set(&o->g->format_opts, "ch_layout", buf, 0); >> } >> } >> if (o->nb_audio_ch_layouts) { > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".