From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1342A497B7 for ; Fri, 19 Apr 2024 17:38:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A4D468D414; Fri, 19 Apr 2024 20:38:05 +0300 (EEST) Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C402468D3CD for ; Fri, 19 Apr 2024 20:37:58 +0300 (EEST) Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6f043f9e6d7so2433021b3a.3 for ; Fri, 19 Apr 2024 10:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713548276; x=1714153076; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=GtOpvH429NhLk7KtCruoM+fScvnVFkRoejfVnezJOB4=; b=lLk02lDiG5pl7y+7wDiO4+ZG1ab9MPUBbPKukIgkBda/3k6pyPbsB/RtHk/Y3r0mR0 mUpB4zZp1FChkNWYAqO+ydAV9yN9G01kZsxASCJk4KFd9GUQ0/xRtMAGeOwN0d3TLXNG bz1IZYvKlQsiKFQAkJxgcc8DbADngse13XontAIoJ138xRGo6Dj+mz0PRqCgbMftme00 3i/0KPIgsm7+YyRwLGdFFq18xv4J0MLZUCtcQeZzfa3vDtH5XISe+aJ7SAuvKWUiPA6x D7JvrGynMIHmuzL1LXTHmQVUXUpIPfcDqYzKbB3tIzIwWsKE11bLTQw0x0gQTudAkB9t iQNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713548276; x=1714153076; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GtOpvH429NhLk7KtCruoM+fScvnVFkRoejfVnezJOB4=; b=PbqhtyBSuTjgt99zPloMjQrO1DmRfmGbxZz5AwTi5QLt0F143iYiQBRlLxgbLcsdvR SvDWxMCFrS45nzwaWqJ3F0w2H/En2BKf6ZZiX0Jnc839buPyIy21EygkxkTL4NnKTCzt 7Jv9oeZfzKn7YhJaoRLZ/5g88ekhl0ZfeHqseS5dawz1Aqf3gg660kwyYk4GmZ4sPA4J MROJH9t4xvdgquC3z74sfAUNoXLmb8BE108McLUVAC3/l0yZ8XAIntkXzR+Kac16/CbD LAcCyKl8l7eQo8kZMFvfh0p5fGdj/mr+81X+5sP+92mXzdNuaD8zzQajG8Rpcws8FaqY KFNA== X-Gm-Message-State: AOJu0YwBO/NBgM5D/IOIhO7meEV8XHGdnIVt/r1Ps7q+EY7P9lNy9Y90 H5LkFlPF90HFU5Rpw9eR8vr2gG2t9OJcaMZnRKg9ZKUxUGjn4wDhgkOQog== X-Google-Smtp-Source: AGHT+IGPPo3x7ptxitiE9x+gWKb3WUTUkh0KF+5lsRHp1+aZjLWj4eq0v+8XGgt8l6LXv8epidM1Ig== X-Received: by 2002:a05:6a00:1915:b0:6ef:a0fe:c478 with SMTP id y21-20020a056a00191500b006efa0fec478mr3085056pfi.34.1713548276427; Fri, 19 Apr 2024 10:37:56 -0700 (PDT) Received: from [192.168.0.10] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id jw31-20020a056a00929f00b006f09f17fa9asm2902970pfb.113.2024.04.19.10.37.55 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Apr 2024 10:37:56 -0700 (PDT) Message-ID: <819f684d-8a72-465d-ab22-3eef5bc3468b@gmail.com> Date: Fri, 19 Apr 2024 14:37:57 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <3e292cbb-8248-4dc6-a750-27f7b0e8ff8f@gmail.com> <20240419172309.101782-1-ffmpeg-devel@pileofstuff.org> Content-Language: en-US From: James Almer In-Reply-To: <20240419172309.101782-1-ffmpeg-devel@pileofstuff.org> Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/network: Return a proper negative error code from ff_network_init() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/19/2024 2:23 PM, Andrew Sayers wrote: > --- > libavformat/network.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/network.c b/libavformat/network.c > index f752efc411..d518bb0541 100644 > --- a/libavformat/network.c > +++ b/libavformat/network.c > @@ -63,7 +63,7 @@ int ff_network_init(void) > if (WSAStartup(MAKEWORD(1,1), &wsaData)) > return 0; > #endif > - return 1; > + return -1; This will make avformat_network_init() fail on all targets but Windows. Also, there are a lot of ff_network_init() callers that check for 0 as failure and anything else as success. What needs to be done is to make ff_network_init() return ff_neterrno() on WSAStartup() failure and 0 on success on Windows, and 0 for every other target (where there's no chance of failure), and the callers be adapted to check for < 0 and propagate the returned error value if so. > } > > int ff_network_wait_fd(int fd, int write) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".