From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4FEB242C96 for ; Thu, 2 Jun 2022 09:54:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 77CF468B79C; Thu, 2 Jun 2022 12:54:50 +0300 (EEST) Received: from mail.acc.umu.se (mail.acc.umu.se [130.239.18.156]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D5B2A68B64C for ; Thu, 2 Jun 2022 12:54:43 +0300 (EEST) Received: from localhost (localhost.localdomain [127.0.0.1]) by amavisd-new (Postfix) with ESMTP id 88E7144BB6 for ; Thu, 2 Jun 2022 11:54:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1654163682; bh=wMjxgVGAwV0VZ1PpPG4wmsPTOiHSdzD7HJLJmF6D5oI=; h=Subject:From:To:Date:In-Reply-To:References:From; b=bieuh17e0vHhCfzFoSoBNlc4XS6TwAEA7yQTG2mqeIiOVEVeGaRrrTsAogUHnVxbm dZYxCyYvzgDsXW4GT7iu5mazrXrxn0ACohz7AoRihwWilCh3pyVuvjjEUD8L9JlK2Z e6Ss2dSLOozZWRiyp1at9PynkRbOFLhXzd+7rJxaymjSl2LSSweRCohqMTbCkoaBeK wcRM5G/GgrV0qu8AF/FtFmRTyNR3SvkjQdxH/3hElDVeDXtcVMAwDj8ovMekqa9MvN Tz67ip4Nb74AZ3nE8wt84npFQdNcnrc3dIAgGtF/Hx+yVlHp8VPAt6zoXuzLUn+CtL zPLwjdesF9ghQ== Received: from [IPv6:2a00:1598:b021:4:2a3d:1e2d:2f3a:e03] (unknown [IPv6:2a00:1598:b021:4:2a3d:1e2d:2f3a:e03]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: tjoppen) by mail.acc.umu.se (Postfix) with ESMTPSA id E8BC644BB5 for ; Thu, 2 Jun 2022 11:54:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acc.umu.se; s=mail1; t=1654163682; bh=wMjxgVGAwV0VZ1PpPG4wmsPTOiHSdzD7HJLJmF6D5oI=; h=Subject:From:To:Date:In-Reply-To:References:From; b=bieuh17e0vHhCfzFoSoBNlc4XS6TwAEA7yQTG2mqeIiOVEVeGaRrrTsAogUHnVxbm dZYxCyYvzgDsXW4GT7iu5mazrXrxn0ACohz7AoRihwWilCh3pyVuvjjEUD8L9JlK2Z e6Ss2dSLOozZWRiyp1at9PynkRbOFLhXzd+7rJxaymjSl2LSSweRCohqMTbCkoaBeK wcRM5G/GgrV0qu8AF/FtFmRTyNR3SvkjQdxH/3hElDVeDXtcVMAwDj8ovMekqa9MvN Tz67ip4Nb74AZ3nE8wt84npFQdNcnrc3dIAgGtF/Hx+yVlHp8VPAt6zoXuzLUn+CtL zPLwjdesF9ghQ== Message-ID: <81755d6b2376e8f9ffb0898e328e6977cde04043.camel@acc.umu.se> From: Tomas =?ISO-8859-1?Q?H=E4rdin?= To: FFmpeg development discussions and patches Date: Thu, 02 Jun 2022 11:54:39 +0200 In-Reply-To: <20220601162308.GJ396728@pb2> References: <152f94f0779c645542f5a678d9392ee53584d45a.camel@acc.umu.se> <20220601162119.GI396728@pb2> <20220601162308.GJ396728@pb2> Content-Type: multipart/mixed; boundary="=-wY8ySLZraw+hgzda4aZu" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/8] libavcodec/jpeg2000_parser: Speed up long skips X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --=-wY8ySLZraw+hgzda4aZu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit ons 2022-06-01 klockan 18:23 +0200 skrev Michael Niedermayer: > On Wed, Jun 01, 2022 at 06:21:19PM +0200, Michael Niedermayer wrote: > > On Tue, May 31, 2022 at 11:58:39AM +0200, Tomas Härdin wrote: > > > > > > > >  jpeg2000_parser.c |   11 +++++++++++ > > >  1 file changed, 11 insertions(+) > > > 634546fb5a0eb281eea87ad7471c503f5bc9e8ab  0001-libavcodec- > > > jpeg2000_parser-Speed-up-long-skips.patch > > > From fedd7f9ae2c691a25c37be935d7547be61d46017 Mon Sep 17 00:00:00 > > > 2001 > > > From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= > > > Date: Fri, 20 May 2022 11:38:25 +0200 > > > Subject: [PATCH 1/8] libavcodec/jpeg2000_parser: Speed up long > > > skips > > > > > > --- > > >  libavcodec/jpeg2000_parser.c | 11 +++++++++++ > > >  1 file changed, 11 insertions(+) > > > > breaks > > j2kref/codestreams_profile1/p1_04.j2k > > [jpeg2000 @ 0x7fb0b8002600] Psot 66195 too big > [jpeg2000 @ 0x7fb0b8002600] error during processing marker segment > ff90 > Input #0, j2k_pipe, from 'j2kref/codestreams_profile1/p1_04.j2k': >   Duration: N/A, bitrate: N/A >   Stream #0:0: Video: jpeg2000 (JPEG 2000 codestream restriction 1), > gray16le(12 bpc), 1024x1024, 25 fps, 25 tbr, 25 tbn > [jpeg2000 @ 0x7fb0b8003240] unsupported marker 0x97C8 at pos 0x6F0 > [jpeg2000 @ 0x7fb0b8003240] Missing EOC Marker. > [jpeg2000 @ 0x7fb0b8032280] unsupported marker 0x97C8 at pos 0x6F0 > [jpeg2000 @ 0x7fb0b8032280] Missing EOC Marker. > [jpeg2000 @ 0x7fb0b8006280] Psot 66195 too big > [jpeg2000 @ 0x7fb0b8006280] error during processing marker segment > ff90 Took a while to figure out, but this is due to buf_size - i - 9 being changed to unsigned because of the uint32_t. Try attached patch. The rest of the set should work with it. Can we roll these tests into FATE? /Tomas --=-wY8ySLZraw+hgzda4aZu Content-Disposition: attachment; filename="0001-libavcodec-jpeg2000_parser-Speed-up-long-skips.patch" Content-Type: text/x-patch; name="0001-libavcodec-jpeg2000_parser-Speed-up-long-skips.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 RnJvbSBlNmEzNTk3MzQ1NmQxMzJhZGM0YWU4NzkwNGRmYjNjMzFlZmYwZmQ1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/VG9tYXM9MjBIPUMzPUE0cmRpbj89IDxnaXRA aGFlcmRpbi5zZT4KRGF0ZTogRnJpLCAyMCBNYXkgMjAyMiAxMTozODoyNSArMDIwMApTdWJqZWN0 OiBbUEFUQ0ggMS84XSBsaWJhdmNvZGVjL2pwZWcyMDAwX3BhcnNlcjogU3BlZWQgdXAgbG9uZyBz a2lwcwoKLS0tCiBsaWJhdmNvZGVjL2pwZWcyMDAwX3BhcnNlci5jIHwgMTEgKysrKysrKysrKysK IDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGliYXZjb2Rl Yy9qcGVnMjAwMF9wYXJzZXIuYyBiL2xpYmF2Y29kZWMvanBlZzIwMDBfcGFyc2VyLmMKaW5kZXgg Mjk3NWU3MTQ4Mi4uMzRhNTQ4N2U5MCAxMDA2NDQKLS0tIGEvbGliYXZjb2RlYy9qcGVnMjAwMF9w YXJzZXIuYworKysgYi9saWJhdmNvZGVjL2pwZWcyMDAwX3BhcnNlci5jCkBAIC05NSw2ICs5NSwx NyBAQCBzdGF0aWMgaW50IGZpbmRfZnJhbWVfZW5kKEpQRUcyMDAwUGFyc2VyQ29udGV4dCAqbSwg Y29uc3QgdWludDhfdCAqYnVmLCBpbnQgYnVmXwogICAgICAgICBzdGF0ZTY0ID0gc3RhdGU2NCA8 PCA4IHwgYnVmW2ldOwogICAgICAgICBtLT5ieXRlc19yZWFkKys7CiAgICAgICAgIGlmIChtLT5z a2lwX2J5dGVzKSB7CisgICAgICAgICAgICAvLyBoYW5kbGUgbG9uZyBza2lwcworICAgICAgICAg ICAgaWYgKG0tPnNraXBfYnl0ZXMgPiA4KSB7CisgICAgICAgICAgICAgICAgLy8gbmVlZCAtOSBl bHNlIGJ1Zl9zaXplIC0gaSA9PSA4ID09PiBpID09IGJ1Zl9zaXplIGFmdGVyIHRoaXMsCisgICAg ICAgICAgICAgICAgLy8gYW5kIHRodXMgaSA9PSBidWZfc2l6ZSArIDEgYWZ0ZXIgdGhlIGxvb3AK KyAgICAgICAgICAgICAgICBpbnQgc2tpcCA9IEZGTUlOKEZGTUlOKChpbnQ2NF90KW0tPnNraXBf Ynl0ZXMgLSA4LCBidWZfc2l6ZSAtIGkgLSA5KSwgSU5UX01BWCk7CisgICAgICAgICAgICAgICAg aWYgKHNraXAgPiAwKSB7CisgICAgICAgICAgICAgICAgICAgIG0tPnNraXBfYnl0ZXMgLT0gc2tp cDsKKyAgICAgICAgICAgICAgICAgICAgaSArPSBza2lwOworICAgICAgICAgICAgICAgICAgICBt LT5ieXRlc19yZWFkICs9IHNraXA7CisgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgfQog ICAgICAgICAgICAgbS0+c2tpcF9ieXRlcy0tOwogICAgICAgICAgICAgY29udGludWU7CiAgICAg ICAgIH0KLS0gCjIuMzAuMgoK --=-wY8ySLZraw+hgzda4aZu Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --=-wY8ySLZraw+hgzda4aZu--