From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 4AF0F43ED2
	for <ffmpegdev@gitmailbox.com>; Wed, 17 Aug 2022 08:58:25 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 772B768B78D;
	Wed, 17 Aug 2022 11:58:24 +0300 (EEST)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 596C768AC22
 for <ffmpeg-devel@ffmpeg.org>; Wed, 17 Aug 2022 11:58:17 +0300 (EEST)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 27H8wFcQ017531-27H8wFcR017531;
 Wed, 17 Aug 2022 11:58:15 +0300
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id BFB81A144B;
 Wed, 17 Aug 2022 11:58:15 +0300 (EEST)
Date: Wed, 17 Aug 2022 11:58:14 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <DB6PR0101MB2214A84D37940BB93EA34ACD8F6A9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
Message-ID: <816d34be-7ed9-ec5b-b37d-e993669db21@martin.st>
References: <DB6PR0101MB2214A84D37940BB93EA34ACD8F6A9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/me_cmp: Remove now incorrect
 av_assert2()
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/816d34be-7ed9-ec5b-b37d-e993669db21@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Wed, 17 Aug 2022, Andreas Rheinhardt wrote:

> Since d69d12a5b9236b9d2f1fd247ea452f84cdd1aaf9 these av_assert2()
> (or more exactly, the ones in hadamard8_diff8x8_c() and
> hadamard8_intra8x8_c()) are hit. So just remove all of these asserts.
> (If the test were improved to know which functions expect h == 8
> and which support any value, the asserts could be readded
> at the appropriate places.)
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/me_cmp.c | 13 -------------
> 1 file changed, 13 deletions(-)

LGTM, thanks!

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".