From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 696E543870
	for <ffmpegdev@gitmailbox.com>; Mon,  3 Oct 2022 00:14:42 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B71468BC11;
	Mon,  3 Oct 2022 03:14:39 +0300 (EEST)
Received: from btbn.de (btbn.de [136.243.74.85])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id F09F468BB85
 for <ffmpeg-devel@ffmpeg.org>; Mon,  3 Oct 2022 03:14:32 +0300 (EEST)
Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id DE39C233B2F
 for <ffmpeg-devel@ffmpeg.org>; Mon,  3 Oct 2022 02:14:29 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org;
 s=mail; t=1664756069;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding:
 in-reply-to:in-reply-to:references:references;
 bh=2vcYzW4luVWFv/ffno8OvleEMtk8ZHXtIif9b9nMrq4=;
 b=RR4wZMtqtIbqezPXiduQVXSo1jaBKwemknewiou0ZzU/NKYYe0hfDqeqv93GNVvcZrxrFH
 a0+Saf2BcYpJIhrPmwwmG3IOtPaM/6XiVGNlynV6SkfUmvqyVQPNqwPxSQ8F+4SOhtqKCB
 ZJNqUmxwvTvuq94ki+i2ILG6sU82jEtOlduFk4wWOb2KbwwF6YFM4GeT0uCWdBUhhfSHPV
 RZXvPiMdO/OukFoHXzLEQiep31kC+8jL9/+wv0n8DnSgdkI6JqnDDo4ovXy4gl0+91KZe+
 05F3c5XLh4LxRAyNPPZGv/g36b6jEqOeCQqONXhmR0VhZ1ULNa6C2t4k1Gc0Zg==
Message-ID: <81454a2b-417e-9ff3-36d1-c02b7be4271b@rothenpieler.org>
Date: Mon, 3 Oct 2022 02:14:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
To: ffmpeg-devel@ffmpeg.org
References: <20221002234755.3354-1-dev@rocha.red>
 <20221002234755.3354-2-dev@rocha.red>
Content-Language: en-US
From: Timo Rothenpieler <timo@rothenpieler.org>
In-Reply-To: <20221002234755.3354-2-dev@rocha.red>
Subject: Re: [FFmpeg-devel] [PATCH 1/1] Enable building with WSL and MSVC
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/81454a2b-417e-9ff3-36d1-c02b7be4271b@rothenpieler.org/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On 03.10.2022 01:47, Julio C. Rocha wrote:
> ---
>   configure | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 6712d045d9..f5f5eb29dd 100755
> --- a/configure
> +++ b/configure
> @@ -4847,7 +4847,12 @@ probe_cc(){
>           else
>               _ident=$($_cc --version 2>/dev/null | head -n1 | tr -d '\r')
>           fi
> -        _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)'
> +        if [ "$(grep -i Microsoft /proc/version)" ]; then

Not convinced that this is a good check.
I can think of a few other situations where Microsoft might appear in 
there. Like, for example on one of their servers, Azure Cloud, Github 
Actions and so on.

> +            # Windows Subsystem for Linux
> +            _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) { cmd="/usr/bin/wslpath \x27" $$0 "\x27"; cmd |& getline pth; print "$@:", pth } }'\'' > $(@:.o=.d)'
> +        else
> +            _DEPCMD='$(DEP$(1)) $(DEP$(1)FLAGS) $($(1)DEP_FLAGS) $< 2>&1 | awk '\''/including/ { sub(/^.*file: */, ""); gsub(/\\/, "/"); if (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)'
> +        fi
>           _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs'
>           _cflags_speed="-O2"
>           _cflags_size="-O1"


What actual issue is this solving?
I've been building in WSL for years, including MSVC builds, and never 
encountered any problems.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".