From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A6C134287F for ; Tue, 5 Jul 2022 12:21:11 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CAD5568B998; Tue, 5 Jul 2022 15:21:07 +0300 (EEST) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 643D368B7F9 for ; Tue, 5 Jul 2022 15:21:00 +0300 (EEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1E52932008FC for ; Tue, 5 Jul 2022 08:20:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 05 Jul 2022 08:20:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itanimul.li; h= cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1657023656; x=1657110056; bh=5mi49+ix3Y vsBbZTh0VZZQRhUqKgcVjtn/2o9JtJ318=; b=V+42zGQ9i0KerI5zXPup1WW8ex 4BxLOV66f7ZNDvUTfKXesiPQeeDVQMPKdzUBdtJXeaeiVviIK91GxKi9gwwzdmKy 1GVeXJ1hOCiR2rZtaFojHfojZ/movdxosyL0ZGbx4Uwe8tmTzr65tbBPzPOsE5zT e/G6ZvwDhz8a2DHl5Jp6WxJqbn0gjE0pRrivhqj9+HhEB0JMq3NN8VHWCHfGDpWm AzjUMHm9+1uy+JmmfNF8S/STxOP0e4cjdMAcnlQGm0APU4HRoxYmBdB9Yk8kMt8p CJaHM9TGJHGyoxOWvZd48cKgkTsoS5HCuEuPoDOADyim7+xkUFK0kOqm2reA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1657023656; x=1657110056; bh=5mi49+ix3YvsBbZTh0VZZQRhUqKg cVjtn/2o9JtJ318=; b=XsP6iTZCm+T/dF/jj+jAsjhPSjYZzwAmkTPHQwTlWsoR 1xdBU/I66xz/cHsZ9tS78kQQd00HY3m+3ofYTGjSZ9ETxVzhY3xsOGXp41luvxKn GVM+HO4cO3OcOZuis0Fvd3h9a7qBlhQOJViIMMOBtVSX6q8CDY3I8zLcZ7/aWC2O r+TJ/uXFrmWUTSRTWoPnOKvm+UJidChuepzRBPxrhgxHbQBfsggmz5L14tUnJy7/ wEJhfE+1vh7PIXLlwoAvA0LYiyMX9Q1gAxahwy2BMAkO+C99EFE66K9BpYL5QsOC gTDhhBZ9yrH3cmQaCjZUbZcr6dVXs0fGHWXVkNieuQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiuddgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffoffkjghfgggtsehttdhmtdertddtnecuhfhrohhmpedflfdrucff vghkkhgvrhdfuceojhguvghksehithgrnhhimhhulhdrlhhiqeenucggtffrrghtthgvrh hnpeevhfegteekffekjedvgeefteejueehueetvddvleeijeeivdfgfefggfekfeeutden ucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhguvghksehithgrnhhimhhulhdrlhhi X-ME-Proxy: Feedback-ID: i84994747:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 5 Jul 2022 08:20:55 -0400 (EDT) From: "J. Dekker" To: FFmpeg development discussions and patches Date: Tue, 05 Jul 2022 14:20:53 +0200 X-Mailer: MailMate Trial (1.14r5852) Message-ID: <8100CC45-97FA-425F-9726-C8DFC04DD267@itanimul.li> In-Reply-To: <20220705001101.111869-1-ffmpeg@haasn.xyz> References: <20220705001101.111869-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavu: always provide symbols from hwcontext_vulkan.h X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5 Jul 2022, at 2:11, Niklas Haas wrote: > From: Niklas Haas > > This header is unconditionally installed, even though the utility > functions defined by it may be missing from the built library. > > A precedent set by e.g. libavcodec/qsv.h (and others) is to always > provide these functions by compiling stub functions in the absence of > CONFIG_*. Make hwcontext_vulkan.h match this convention. > > Fixes downstream issues, e.g. > https://github.com/haasn/libplacebo/issues/120 > > Signed-off-by: Niklas Haas > --- > libavutil/Makefile | 2 +- > libavutil/hwcontext_vulkan.c | 26 ++++++++++++++++++++++++-- > 2 files changed, 25 insertions(+), 3 deletions(-) > > [...] Public API symbols (av_*) shouldn't completely disappear based on configure options. LGTM. -- J. Dekker _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".