From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7D5E943527 for ; Thu, 16 Jun 2022 10:04:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2EFC768B5E4; Thu, 16 Jun 2022 13:04:22 +0300 (EEST) Received: from shout02.mail.de (shout02.mail.de [62.201.172.25]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1B5C768B13C for ; Thu, 16 Jun 2022 13:04:15 +0300 (EEST) Received: from postfix02.mail.de (postfix02.bt.mail.de [10.0.121.126]) by shout02.mail.de (Postfix) with ESMTP id B3499A0316 for ; Thu, 16 Jun 2022 12:04:14 +0200 (CEST) Received: from smtp01.mail.de (smtp01.bt.mail.de [10.0.121.211]) by postfix02.mail.de (Postfix) with ESMTP id 9B08CA03C1 for ; Thu, 16 Jun 2022 12:04:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mail.de; s=mailde202009; t=1655373854; bh=Ha0MVJsktYhJrFqdV6R8n11cyFNA8cdHMEBh+N7VNY8=; h=Message-ID:Date:Subject:To:From:From:To:CC:Subject:Reply-To; b=sZGHw5cWNjf19XVKGKhG5aYgREJOB2sgsV1bgndTj+vwG41dhL7hVq6UGqzWUHA7v TsKNw6AX4LzLY2zDkah4bJ3/AO11ovvkvtaqbSGzRkXloxcox+LeCgQLQa/xIKX8WG eOdN8zAYwICK/qRG6/V04nkKYKrQnA75r+1bI3t1B44CMNKevSR2BXhDkzMF+mXAgf cx0RawwGZbtZT99SJ0K28PZQ9cYdnDXk/preWuelK4FCcUbfxOokXenYLkvzAp4Ho6 ZnRjdGA1nocVu0hWhXUlHdL5HlKkhfHqFqujkQxkHzXCaqkvUnb6V3DYMUjlEy0Sdl J3g1nzZOZgaGQ== Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtp01.mail.de (Postfix) with ESMTPSA id 6834A102943 for ; Thu, 16 Jun 2022 12:04:14 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------YgLFoVnO2CA15bVAmjYUX30w" Message-ID: <80816607-3610-9133-9d5d-7fee3040de06@mail.de> Date: Thu, 16 Jun 2022 12:04:13 +0200 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Thilo Borgmann In-Reply-To: X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 3092 X-purgate-ID: 154282::1655373854-000005DA-01223E18/0/0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/dovi_rpu: Fix UB for possible left shift of negative values X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is a multi-part message in MIME format. --------------YgLFoVnO2CA15bVAmjYUX30w Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Am 16.06.22 um 11:44 schrieb Andreas Rheinhardt: > Thilo Borgmann: >> Hi, >> >> avoid left-shifting possibly negative values in case of RPU_COEFF_FLOAT. >> Changed RPU_COEFF_FIXED as well for consistency. >> > > This is wrong: Both of your changes only affect RPU_COEFF_FIXED. Indeed I'm sorry, got confused looking at the patch only when writing the commit msg. It is actually changing get_ue_coef() for consistency although its all unsigned in there. v2 attached. Thanks, Thilo --------------YgLFoVnO2CA15bVAmjYUX30w Content-Type: text/plain; charset=UTF-8; name="v2-0001-lavc-dovi_rpu-Fix-UB-for-possible-left-shift-of-n.patch" Content-Disposition: attachment; filename*0="v2-0001-lavc-dovi_rpu-Fix-UB-for-possible-left-shift-of-n.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1NWEzZDFmMWQyNzZmMzMyN2M4OTIwZWM3NDhmZWQ3OWQ4YTk4ODI1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEdvdWxldCA8bWdvdWxldEBmYi5jb20+ CkRhdGU6IFRodSwgMTYgSnVuIDIwMjIgMTI6MDI6MDIgKzAyMDAKU3ViamVjdDogW1BBVENI IHYyXSBsYXZjL2RvdmlfcnB1OiBGaXggVUIgZm9yIHBvc3NpYmxlIGxlZnQgc2hpZnQgb2Yg bmVnYXRpdmUKIHZhbHVlcwoKSXQgaXMgdW5kZWZpbmVkIHRvIGxlZnQtc2hpZnQgYSBuZWdh dGl2ZSB2YWx1ZS4KQ2hhbmdlZCBnZXRfdWVfY29lZigpIGFzIHdlbGwgZm9yIGNvbnNpc3Rl bmN5IGFsdGhvdWdoIGl0cyBhbGwgcG9zaXRpdmUgdmFsdWVzIHRoZXJlLgotLS0KIGxpYmF2 Y29kZWMvZG92aV9ycHUuYyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saWJhdmNvZGVjL2RvdmlfcnB1 LmMgYi9saWJhdmNvZGVjL2RvdmlfcnB1LmMKaW5kZXggYTg3NTYyYzhhMy4uODMzY2U5ZTcw NSAxMDA2NDQKLS0tIGEvbGliYXZjb2RlYy9kb3ZpX3JwdS5jCisrKyBiL2xpYmF2Y29kZWMv ZG92aV9ycHUuYwpAQCAtMTUzLDcgKzE1Myw3IEBAIHN0YXRpYyBpbmxpbmUgdWludDY0X3Qg Z2V0X3VlX2NvZWYoR2V0Qml0Q29udGV4dCAqZ2IsIGNvbnN0IEFWRE9WSVJwdURhdGFIZWFk ZXIKICAgICBjYXNlIFJQVV9DT0VGRl9GSVhFRDoKICAgICAgICAgaXBhcnQgPSBnZXRfdWVf Z29sb21iX2xvbmcoZ2IpOwogICAgICAgICBmcGFydC51MzIgPSBnZXRfYml0c19sb25nKGdi LCBoZHItPmNvZWZfbG9nMl9kZW5vbSk7Ci0gICAgICAgIHJldHVybiAoaXBhcnQgPDwgaGRy LT5jb2VmX2xvZzJfZGVub20pICsgZnBhcnQudTMyOworICAgICAgICByZXR1cm4gaXBhcnQg KiAoMSA8PCBoZHItPmNvZWZfbG9nMl9kZW5vbSkgKyBmcGFydC51MzI7CiAKICAgICBjYXNl IFJQVV9DT0VGRl9GTE9BVDoKICAgICAgICAgZnBhcnQudTMyID0gZ2V0X2JpdHNfbG9uZyhn YiwgMzIpOwpAQCAtMTcyLDcgKzE3Miw3IEBAIHN0YXRpYyBpbmxpbmUgaW50NjRfdCBnZXRf c2VfY29lZihHZXRCaXRDb250ZXh0ICpnYiwgY29uc3QgQVZET1ZJUnB1RGF0YUhlYWRlciAq CiAgICAgY2FzZSBSUFVfQ09FRkZfRklYRUQ6CiAgICAgICAgIGlwYXJ0ID0gZ2V0X3NlX2dv bG9tYl9sb25nKGdiKTsKICAgICAgICAgZnBhcnQudTMyID0gZ2V0X2JpdHNfbG9uZyhnYiwg aGRyLT5jb2VmX2xvZzJfZGVub20pOwotICAgICAgICByZXR1cm4gKGlwYXJ0IDw8IGhkci0+ Y29lZl9sb2cyX2Rlbm9tKSArIGZwYXJ0LnUzMjsKKyAgICAgICAgcmV0dXJuIGlwYXJ0ICog KDEgPDwgaGRyLT5jb2VmX2xvZzJfZGVub20pICsgZnBhcnQudTMyOwogCiAgICAgY2FzZSBS UFVfQ09FRkZfRkxPQVQ6CiAgICAgICAgIGZwYXJ0LnUzMiA9IGdldF9iaXRzX2xvbmcoZ2Is IDMyKTsKLS0gCjIuMjAuMSAoQXBwbGUgR2l0LTExNykKCg== --------------YgLFoVnO2CA15bVAmjYUX30w Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --------------YgLFoVnO2CA15bVAmjYUX30w--