From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A614845C66 for ; Thu, 30 Mar 2023 01:28:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D984C68C39E; Thu, 30 Mar 2023 04:28:22 +0300 (EEST) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 86A6468C07D for ; Thu, 30 Mar 2023 04:28:16 +0300 (EEST) Received: by mail-ot1-f49.google.com with SMTP id r40-20020a05683044a800b006a14270bc7eso5907120otv.6 for ; Wed, 29 Mar 2023 18:28:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680139694; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3Q1ENZZ9MOyQMH2GhWE/YYXgOAj0d02wn7XX6+k25zc=; b=EwrN9bicEgiuK0+mY+400yIZyRu3pVZr2VBs1BhgE20PaRaNyAJfrmprjtu+/KUoPT 0Io25yNxOPu0N0nV88MjANQmWYaEibjF1VQpwiuzYovE2ut8wzarVLp8AdanM401AE+0 f0auYsIwvOnLp3E+Z+QSZWNQ5o9FSqcbk5ioL9PhzFRe5L/+YvAKp7qlQVAPsBkQ4C2T DRZJhMtO4/9BBO9mK5Ipo0l0NHxFRmV7cn4yu8YQ/hk4C/o1jT6j2PtTvwJcneu4oiah GD4o9tAXcyT2H89QKGCAhMzf20LmNOJm5DJrULNIdPhfvUcWe2zxd1RgkTZFijM9XcfZ TKvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680139694; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3Q1ENZZ9MOyQMH2GhWE/YYXgOAj0d02wn7XX6+k25zc=; b=qOFSCb0rqPQWBNDeWthVLkKPEJaaVi5gJaoZfLt5jy1RpvJzZFiRJEcxRpUtRIng9v 3eug6mZG9RUOAlxe5EWBerwijrE3B//H08XGJqhycf8duQJy/xM2y+CE05XXcdQtyBNm R7RiXkrkLj5D0YORu6C+3ZMZgM3B4zpmCuqCYxFOdvnO4hadrMz5GJPmpomjC6sLaML0 7mcQeVd6nG1K6Wm7kjkfoEuvu+FI7+pvw1jEgoy92cyRM8/jsSP4O1PBSpM4RK2JS/iD qrWTyjeZIXdp0DAiyER2CJap2XxYmb2rwu59+Cavt8Dxq1FbpF3t00DY+ad7UBzbc4hq JIJQ== X-Gm-Message-State: AO0yUKXUBoFsfL0OjfV+gEICTmFJKe/YFh+BL9w05LxjwVLA8VnwcSCi Ezg0Qcm2K/RDhUBEH2QUk+slvBC5Kkk= X-Google-Smtp-Source: AK7set/43hpTW/z1mbkWkjuAovIPkJx/P5IeVyR30GuoMqOgBcQAdyw0zlcPd+yuQGo0ugAHMfqQ6w== X-Received: by 2002:a05:6830:d3:b0:6a1:1a8c:6fcf with SMTP id x19-20020a05683000d300b006a11a8c6fcfmr9284217oto.0.1680139694536; Wed, 29 Mar 2023 18:28:14 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id i7-20020a4a8d87000000b0052a77e38722sm14558959ook.26.2023.03.29.18.28.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Mar 2023 18:28:13 -0700 (PDT) Message-ID: <8030d6f0-410f-1c4b-4868-5765fe1ee106@gmail.com> Date: Wed, 29 Mar 2023 22:28:11 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230324155213.3493-1-jamrial@gmail.com> <20230324155213.3493-5-jamrial@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v3 5/7] avformat/matroskaenc: write a MaxBlockAdditionID element X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/29/2023 9:44 PM, Andreas Rheinhardt wrote: >> @@ -3070,6 +3082,25 @@ after_cues: >> >> if (mkv->track.bc) { >> // write Tracks master >> + int64_t end = avio_tell(mkv->track.bc); >> + >> + for (int i = 0; i < s->nb_streams; i++) { > AVFormatContext.nb_streams is unsigned, so i should be, too. This same kind of loop is done with an int everywhere, but ok, will change it since it's harmless. > >> + const mkv_track *track = &mkv->tracks[i]; >> + >> + if (IS_WEBM(mkv)) >> + break; > This check does not belong into the loop. Changed, but it looks uglier now. > >> + if (!track->max_blockaddid) >> + continue; >> + >> + // We reserved a single byte to write this value. >> + av_assert0(track->max_blockaddid <= 0xFF); >> + >> + avio_seek(mkv->track.bc, track->blockadditionmapping_offset, SEEK_SET); >> + >> + put_ebml_uint(mkv->track.bc, MATROSKA_ID_TRACKMAXBLKADDID, track->max_blockaddid); >> + } >> + >> + avio_seek(mkv->track.bc, end, SEEK_SET); > This seek (and the avio_tell() before the loop) seem unnecessary; see > 0fc150f048398c9dbb8578f25e916fd356c18a54. Ah, good to know. Will remove it then. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".