From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 1E65C426EB for ; Mon, 25 Jul 2022 05:22:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6187E68B752; Mon, 25 Jul 2022 08:22:20 +0300 (EEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 353C168B4C9 for ; Mon, 25 Jul 2022 08:22:12 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658726538; x=1690262538; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=BTZWAtsP27zHAhop9GyWlf/zVoTox6Vm7CcFP2kSNPQ=; b=dyjiwPCbJEF8NHOMvhd7JcId+Y1Km5utv+JAFNWq1xd7N1iWobr1ixI0 Pf+ekUfuLpRLNXEp748dn9EOFw2CA6pX+o8JrfikrPiopuEzfLwR89XCl Udjcubdl1uPHXiDztsqK0mkl9gAX8PtCkZO0CVTTHyiE79JNoageIySZX E9KriOCrLnSZixuOls2/YVY/aOsawP9qR0sauYEDCUtIb9O9e0+0dhxoN SR9wqgSIXoKyAt+L7gxz6XVPh48IGIKpgy9SDXRHUoeS9Hm+ZizgBpMW/ vQOf97DZnO+kQWjDR7mpUQ7ROd2yK9tB/Peq0FhXnRFwjmO/2RhLoEDzQ g==; X-IronPort-AV: E=McAfee;i="6400,9594,10418"; a="285161496" X-IronPort-AV: E=Sophos;i="5.93,191,1654585200"; d="scan'208";a="285161496" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2022 22:22:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,191,1654585200"; d="scan'208";a="574900888" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 24 Jul 2022 22:22:10 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Sun, 24 Jul 2022 22:22:09 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Sun, 24 Jul 2022 22:22:09 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 24 Jul 2022 22:22:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gDaE/rlOaRv7G4Cugp94ISDROZdC8ZDICfXLiWNeS025Dl9R1feKGGZ4ipHAP1XDsTZf2BGg570aA71Ffs1ZtuZe9z+Pz4+u95qz//AQ4BuM5hmLQTtN/REGCMinsNRT8wi6cBBJyanAUiXnZEehmkuaT5aaFhJan8JsElSzDj0hBu+nahLFZvC9VWd8N95+gmHc60DY2t9CNsUUP3aZpp9HVOhjlW0oVxYT4vHBTblKbSZ2mzLKGLTVLWghBUhT4lxZKT6Q/gOmQqCXN5qBNYJi1ic90C3qEXtASx2xOwNDTYzuivBDc6tCXdCkOTaxV3CdA4k+ndkXLbpk6WVyOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BTZWAtsP27zHAhop9GyWlf/zVoTox6Vm7CcFP2kSNPQ=; b=RbaTjwJspbY2bCrJ/Hh88kkIww1gunXsX5VHBt5jyrxh0NQU7bjKJzmzD7eD0yKtBjnDpeJ+lClWRz+Xl9HEqeFaZUNJyx1nWxUDoQxed36rl+PoK8MqpgFegepQB8Bm6UuEuKP0O9xGPQVJZwuBCF+nsjH8DSi20/apHyLICfdztx62dP887aw6jQWT8+Oh3VvY8tMFIRV+EPKj98wrwOtgJRhgug4g/uyvl9ku67NJFsHqWvaM1Btmo/sAn22AyKwTrfvUWTSBBkiogTs+HDxLXmxGE5MZALpXxHi6172w5R/GtBCMwXzdPWaKjLgNneHsLa1dMQi0m6LpJt+SqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by MN2PR11MB3582.namprd11.prod.outlook.com (2603:10b6:208:ec::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 05:22:07 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 05:22:07 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v3 1/4] lavc/hevc_refs: fix dpb logical for IRAP Thread-Index: AQHYmAj1tnPPduKrdU+BYVl4nKy9R62D3BCAgArA0oA= Date: Mon, 25 Jul 2022 05:22:07 +0000 Message-ID: <8020b05e3e101471d4c307552ade97b4594243cc.camel@intel.com> References: <20220715050644.879488-1-fei.w.wang@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2451d86-3472-4028-84f4-08da6dfd9e3f x-ms-traffictypediagnostic: MN2PR11MB3582:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6l6ixQPBUpLeEGzl9kwvj0DCUbQY3n7X4EN5uNYr8U3nIlz1T/mKQwoNk2Dv1vZZNmGNtp007tB3glIDe24SLIq+vfTm45VxchQLhLqCB03K6mcE8t0kJw2ez2sjqCoK8H/jwcNslLoGF/r5wdohzYjMzAVJ8T67YwjEU7GzecK3rxe3s2Wnb3tIOuPmTiedpXdiJ1uD//Hz9poXdwcWAVE8sOs9qQXNqPsFI7/RcJYk11qQQ70fSx5VYx5E1eiA4ZbxD/1kUToo/M4SvZW4zD7Qa2qyglmZ1ncPyC7SQEMzap+wPwdSi6OH9auVAPh6IbsMACTW1Y18Io9DsI2gBUfv45CeVKTu/U82IjRb2CoxdnIxJEL00oF3wIKAbI/9siSDeRlLMkzV6+M6uF7tsZWpz25w5D22oXsUKQz96S65cBaaJClB8CNl4GrwkENn+HgvIs8pLarnAJQaHDe810XDKbQcH6sXzJDAVyWGw1wSFtihBHL5RCwy9GFmNkmVRN+hSaomnyuOynOfP5I4fwPiniMo4A1/IT53Tx0lKkZijE3neCIcRr2viepbWb11SoYQEElConPaUxp91jbIwgbDXgMbeZ++qX7WpoAJsVkdLkHRqMk5CdIGUoThAtbqKoMpdg+Y2M8s+PRHW6Qbj6eUlP2cGD4e//l/AO4IFgQJXiVhvxpBc1pXbCgwhkHzbqlBARL/HluP8WC9A7970cKGeQarEjbcXwnhQ/wqHrkCLhU5ly9YhqKGDBiKtazrwNNRVVQUo5wOvrPRdgME2I73zYr+3q2lyRJT47pCyB55rWLYnLWTTmBMDC5XHDdCoeVP1GWj/u3GxtjkVN4v9g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(39860400002)(396003)(136003)(376002)(346002)(478600001)(6486002)(86362001)(54906003)(6506007)(6916009)(41300700001)(82960400001)(36756003)(38070700005)(26005)(316002)(107886003)(2616005)(186003)(83380400001)(76116006)(66476007)(66446008)(64756008)(8676002)(66556008)(71200400001)(5660300002)(4326008)(91956017)(8936002)(66946007)(6512007)(38100700002)(122000001)(2906002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WUdob0xLeDdCd3lEaml1YWtHLzBEYmhxUWt3TmtFVW9CdkhvV0tsdnFscVh1?= =?utf-8?B?dEFha1dLUHI3WHBQZFc4VlhNcStiVDJyNlRNTjJPZXdqbzUrZ1NpaUtUaTdS?= =?utf-8?B?UzZwd2lsV2VYcEt0enlCOUMrcUY5UDhxbHc5TG1ldGtsRDhZazZudUtNOWk3?= =?utf-8?B?emVaRDlOcHFnSTh1dHhvU2FMdnBnMzNLYUdWWThaMmNKZ2NreUxGclk0Mjlp?= =?utf-8?B?N24xbUdzK3ZLWVN3SDJ4cGdhd2xpbnlXdEhNaVdTY0dqTGZEeHBKVitsSnFt?= =?utf-8?B?WXk4Tms4K0JrUmxjejJGUjUxVEVsc3E3M3VtN0R5aDVtN2Z1ZTNlM2hqY05O?= =?utf-8?B?aUpwQzhKZzhWQW9rQTN0S3gwdEt2R2lNWUF0Tjg5ZTZ2Z1AwT056Tm92ZXZM?= =?utf-8?B?S0s3K0xmRWpmQ1VVM21ucDNSUGRVajlKOEJkbi9pMEtqeXVuUlIzWXI1SHdk?= =?utf-8?B?L000cGJkZWg5SUh5YmEvZ052Z25aNEYxMHVyQm9qZ2lBZVpOMjNaNVNTeEFl?= =?utf-8?B?dDd4Q0NydURFN0dEQmUwWGZGNHZvM1dUR1VSZ2lQOFFjZnR3NVVXQ3VycWdC?= =?utf-8?B?dFdiQjFoZHluYjRVdkkwV2RUVXhLZVlYUzBQanV6dXZ5dUF0azdtU1o5SE9E?= =?utf-8?B?T2IwUnhFamk3NkpVaHBtS1lKUmR3TEhPUzVhS3FJdzNrV0JYSWhqWUIvN2sv?= =?utf-8?B?eGhidDVqNFNsZkNKUXVpZGE1U0VYeVZmaGpCWkc2OG5UUzBJNTFJNjVVejFx?= =?utf-8?B?VXhTa09URExQZldsYkovODdpbjdvdld3S0dBYWVvUnp3bjBkWllXak5nODZl?= =?utf-8?B?YU16bzA5UFBiNVExYStPcXBmc1ZLY2NtckQvdmR6b3NvbC9YR05WU1BjTUdz?= =?utf-8?B?bWdab1FzV2M3UnBFNDB6N2hJYUJRNmRVdWRSQ0JpVWYwOTgybk5YVnp2R05N?= =?utf-8?B?dlpzeUNtZnJ0TWdLRTVaekVXUjVZOHdjSVprV2VKZWE3dGd1RjEySFFtWm5F?= =?utf-8?B?RGUzd01rZVU5TDNDZFZURUFIWjlqblE2TW42bkczZGZFNWpBUjJLUHJkdzAw?= =?utf-8?B?V1FuamxBZGV3cE1DN0hUZDZoRTd5ZW4vcHZpZzErUHkxaHlQYldZSEVBR3lh?= =?utf-8?B?TW81eGlrMlBQeGdoMnQ1dmdmZE5FWkNNYkMzcnhISEZPdDZmR2NacmIvaEJw?= =?utf-8?B?ZUNYTkJCTzhzeTBsdjhVd3JDZVpKWi9INlNlcXJkbzdidGN1OHg3TUhDMG9N?= =?utf-8?B?Y2E4c1RYdndxeFpyWHh5VWJTZkZSdjNFMXYvN0NYcEthKzNONmxqNnNkUFVt?= =?utf-8?B?MXhyajFmTyt0VDdXMGw1UzVTYy8vMGlLcUZsbFBocjdkaHZwR284bWVYNGJ5?= =?utf-8?B?M01sNWJEN05zaXpLU0M2TWFmWm16QktpZGJ0MlVoLzIzOUxCRDdCVW9yRGYw?= =?utf-8?B?WEVQeVVDdk50WHV1cmJxb3hrK3ppZlpiWjZIdGppREgxZFRuMlpybjN5VGpz?= =?utf-8?B?UHpLamxvMHowTm5BMi8vWHg5VzNoS0kxVnFGMFBKa21OZnpBR2RLWWQ1bjRN?= =?utf-8?B?aC9NTE81QXFQUTBUeVJqb0JPNHRrOVNFRzFoZlROU0tXTEJzSHQvUHNjbG0y?= =?utf-8?B?U2NJMHk0QWxTUHBTZUFiVHZkbEplbjd1Y2Q0ZUhObTF0K1BmY1pHWEUzRzdm?= =?utf-8?B?ZG54OGl6SzdaaXlobzZpS1JRaTBDdFpTYzNQbjRlcTN4ZWJLL2tZbHkvcnB2?= =?utf-8?B?UWxNN2tmdGxpWWtUN2x1TjNGbHlpc2NWN1ByMGtaRGxqdzFPNTEzd3VDRWJ5?= =?utf-8?B?YUVueDJEc0FLRXlnWVM1NitkM2ZoNEx4bmxzSUNsS00ySU8rQnVFZUQxMkRM?= =?utf-8?B?REpnRG9QQS9DMW9GRWdMWnB1dnJmZDV3ZFJRYk4vTDRvWnhVVzluTE5aZi9m?= =?utf-8?B?alBIWndLR3pmS1M3K2NoeTA4MjVDM3dCT2dtL1RrVVI4RGREdTQ1cGdnNi9F?= =?utf-8?B?NWRlcHBINVAzSW13M21iM0ZvOEFINGUwSEFISHU5VGV5b2NVaStDb1k5eG1E?= =?utf-8?B?dVorUzFCeHNrZzZOZE5iUWhFaEVMSkwwSjVmNmhaR3l3akd6b2pFN25FSGVh?= =?utf-8?B?L0FKWGk3am9XbTdEUVlYSHJST1dMZkRPTUY5Ty84Y3QxSzkyTVJYVHJHUGlp?= =?utf-8?B?WHc9PQ==?= Content-ID: <7D83D6AA6600964C89D180BDA7E687F8@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2451d86-3472-4028-84f4-08da6dfd9e3f X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 05:22:07.4838 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ORxl4qWoHkDJ/NQI+tYtD+hbuuuBYJERCjP9zBVEoDJfRVcCnufDn4k5degZ7o+rckSMGCyJ8wG9/qXM4eraAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3582 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v3 1/4] lavc/hevc_refs: fix dpb logical for IRAP X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xu, Guangxin" , "Wang, Fei W" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-07-18 at 09:09 +0000, Xiang, Haihao wrote: > On Fri, 2022-07-15 at 13:06 +0800, Fei Wang wrote: > > From: Xu Guangxin > > > > According to C.5.2.2, item 2. When we got an IRAP, and the > > NoOutputOfPriorPicsFlag = 0, we need bump all outputable frames. > > > > Tested-by: Fei Wang > > Signed-off-by: Xu Guangxin > > --- > > update: > > 1. clean and replace 0xff with HEVC_SEQUENCE_COUNTER_MASK > > > > libavcodec/hevc_refs.c | 23 +++++++++++++---------- > > 1 file changed, 13 insertions(+), 10 deletions(-) > > > > diff --git a/libavcodec/hevc_refs.c b/libavcodec/hevc_refs.c > > index 6a70c817b0..2b0468d6c4 100644 > > --- a/libavcodec/hevc_refs.c > > +++ b/libavcodec/hevc_refs.c > > @@ -175,21 +175,24 @@ int ff_hevc_set_new_ref(HEVCContext *s, AVFrame > > **frame, > > int poc) > > > > int ff_hevc_output_frame(HEVCContext *s, AVFrame *out, int flush) > > { > > + if (IS_IRAP(s) && s->no_rasl_output_flag == 1) { > > + const static int mask = HEVC_FRAME_FLAG_BUMPING | > > HEVC_FRAME_FLAG_OUTPUT; > > + for (int i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > > + HEVCFrame *frame = &s->DPB[i]; > > + if ((frame->flags & mask) == HEVC_FRAME_FLAG_OUTPUT && > > + frame->sequence != s->seq_decode) { > > + if (s->sh.no_output_of_prior_pics_flag == 1) > > + ff_hevc_unref_frame(s, frame, HEVC_FRAME_FLAG_OUTPUT); > > + else > > + frame->flags |= HEVC_FRAME_FLAG_BUMPING; > > + } > > + } > > + } > > do { > > int nb_output = 0; > > int min_poc = INT_MAX; > > int i, min_idx, ret; > > > > - if (s->sh.no_output_of_prior_pics_flag == 1 && s- > > >no_rasl_output_flag > > == 1) { > > - for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > > - HEVCFrame *frame = &s->DPB[i]; > > - if (!(frame->flags & HEVC_FRAME_FLAG_BUMPING) && frame->poc > > != s->poc && > > - frame->sequence == s->seq_output) { > > - ff_hevc_unref_frame(s, frame, HEVC_FRAME_FLAG_OUTPUT); > > - } > > - } > > - } > > - > > for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > > HEVCFrame *frame = &s->DPB[i]; > > if ((frame->flags & HEVC_FRAME_FLAG_OUTPUT) && > > Patchset LGTM. > The patchset works well for me. Are there any more comments here ? If not, I'll apply this patchset in a few days. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".