On 11/1/2024 11:57 AM, Patrice Dumas wrote: > > Here is a proposed patch for portability of doc/t2h.pm for GNU Texinfo > 7.1 and 7.1.90 (7.2 pretest). I tested against 7.1 and 7.1.90 (7.2 > pretest). There is a difference in the headings compared to the website > version, maybe related to FA_ICONS not being set the same, but the > result seems correct. > > I also renamed $element to $output_unit in ffmpeg_heading_command as in > new equivalent makeinfo/texi2any code the $element variable is the > $command variable in ffmpeg_heading_command, which is very confusing. I > left as is the $command variable to have a patch easier to read, but it > could make sense to rename $command as $element later on. > > The patch could also have effects with Texinfo 7.0, since some of the > changes are for that version, but that probably never show up because it > is for situations that may not exist in ffmpeg manuals (for example > @node without sectioning command), or because the code is robust to some > missing information (case of $heading_level in ffmpeg_heading_command > that was not set, as far as I can tell). > > --- > doc/t2h.pm | 169 ++++++++++++++++++++++++++++++++++++++++------------- > 1 file changed, 129 insertions(+), 40 deletions(-) Will apply.