From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 2A0C440E4D
	for <ffmpegdev@gitmailbox.com>; Wed, 11 May 2022 04:30:36 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1061268B405;
	Wed, 11 May 2022 07:30:34 +0300 (EEST)
Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C9BEB68B353
 for <ffmpeg-devel@ffmpeg.org>; Wed, 11 May 2022 07:30:27 +0300 (EEST)
Received: from smtp2.mailbox.org (smtp2.mailbox.org
 [IPv6:2001:67c:2050:b231:465::2])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4Kyhm10BRHz9ssc
 for <ffmpeg-devel@ffmpeg.org>; Wed, 11 May 2022 06:30:25 +0200 (CEST)
Message-ID: <7feebbef-b03e-8104-9930-05477d06c8a4@gyani.pro>
Date: Wed, 11 May 2022 10:00:23 +0530
MIME-Version: 1.0
Content-Language: en-US
To: ffmpeg-devel@ffmpeg.org
References: <20220510224829.143890-1-ccom@randomderp.com>
From: Gyan Doshi <ffmpeg@gyani.pro>
In-Reply-To: <20220510224829.143890-1-ccom@randomderp.com>
X-Rspamd-Queue-Id: 4Kyhm10BRHz9ssc
Subject: Re: [FFmpeg-devel] [PATCH] configure: add check for sdl2 >= 2.23.0
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/7feebbef-b03e-8104-9930-05477d06c8a4@gyani.pro/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>



On 2022-05-11 04:18 am, Christopher Degawa wrote:
> sdl2 recently changed their versioning, moving the patch level to minor level
> https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff
>
> trac: https://trac.ffmpeg.org/ticket/9768
>
> Signed-off-by: Christopher Degawa <ccom@randomderp.com>
> ---
>   configure | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/configure b/configure
> index 4d2f4d9112..88777fed10 100755
> --- a/configure
> +++ b/configure
> @@ -6743,6 +6743,13 @@ fi
>   if enabled sdl2; then
>       SDL2_CONFIG="${cross_prefix}sdl2-config"
>       test_pkg_config sdl2 "sdl2 >= 2.0.1 sdl2 < 2.1.0" SDL_events.h SDL_PollEvent
> +    # sdl2 changed their versioning scheme to match GLib and flatpack moving the patch to
> +    # minor instead in
> +    # https://github.com/libsdl-org/SDL/commit/cd7c2f1de7d9e418bb554047d714dd7cacc020ff
> +    # which obviously breaks the previous check, so go ahead and check for the new version
> +    if disabled sdl2; then
> +        test_pkg_config sdl2 "sdl2 >= 2.23.0" SDL_events.h SDL_PollEvent

Clamp the new check to be under 3.x and LGTM.

Regards,
Gyan
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".