From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4E3164282C for ; Sun, 31 Jul 2022 10:06:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 721DB68BA49; Sun, 31 Jul 2022 13:06:27 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9ADEB68B8A3 for ; Sun, 31 Jul 2022 13:06:20 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 26VA6JBf005851-26VA6JBg005851; Sun, 31 Jul 2022 13:06:19 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 21990A1468; Sun, 31 Jul 2022 13:06:18 +0300 (EEST) Date: Sun, 31 Jul 2022 13:06:18 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <7f49aaae-6c97-3bf1-450-12bca3f01331@martin.st> References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 3/4] configure: Add msmpeg4(dec|enc) subsystems X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 31 Jul 2022, Andreas Rheinhardt wrote: > The msmpeg4 decoders/encoders share a common set of prerequisites, > ergo it makes sense to use common subsystems for them. This also > allows to remove the CONFIG_MSMPEG4_DECODER/ENCODER ad-hoc defines > (which violated the CONFIG_ namespace). > > Signed-off-by: Andreas Rheinhardt > --- > configure | 24 ++++++++++++++---------- > libavcodec/Makefile | 16 ++++------------ > libavcodec/h263dec.c | 4 ++-- > libavcodec/mpegvideo_enc.c | 8 ++++---- > libavcodec/msmpeg4dec.h | 8 -------- > libavcodec/msmpeg4enc.h | 6 ------ > libavformat/protocols.c | 1 + > 7 files changed, 25 insertions(+), 42 deletions(-) > diff --git a/libavcodec/Makefile b/libavcodec/Makefile > index a6311411d3..33b913c4fc 100644 > --- a/libavcodec/Makefile > +++ b/libavcodec/Makefile > @@ -141,6 +141,8 @@ OBJS-$(CONFIG_MPEGVIDEODEC) += mpegvideo_dec.o mpegutils.o > OBJS-$(CONFIG_MPEGVIDEOENC) += mpegvideo_enc.o mpeg12data.o \ > motion_est.o ratecontrol.o \ > mpegvideoencdsp.o > +OBJS-$(CONFIG_MSMPEG4DEC) += msmpeg4dec.o msmpeg4.o msmpeg4data.o > +OBJS-$(CONFIG_MSMPEG4DEC) += msmpeg4enc.o msmpeg4.o msmpeg4data.o Typo on the second line, should be CONFIG_MSMPEG4ENC? // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".