Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH 3/4] configure: Add msmpeg4(dec|enc) subsystems
Date: Sun, 31 Jul 2022 13:06:18 +0300 (EEST)
Message-ID: <7f49aaae-6c97-3bf1-450-12bca3f01331@martin.st> (raw)
In-Reply-To: <DB6PR0101MB2214A67137AFF9847951FEAE8F9B9@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>

On Sun, 31 Jul 2022, Andreas Rheinhardt wrote:

> The msmpeg4 decoders/encoders share a common set of prerequisites,
> ergo it makes sense to use common subsystems for them. This also
> allows to remove the CONFIG_MSMPEG4_DECODER/ENCODER ad-hoc defines
> (which violated the CONFIG_ namespace).
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> configure                  | 24 ++++++++++++++----------
> libavcodec/Makefile        | 16 ++++------------
> libavcodec/h263dec.c       |  4 ++--
> libavcodec/mpegvideo_enc.c |  8 ++++----
> libavcodec/msmpeg4dec.h    |  8 --------
> libavcodec/msmpeg4enc.h    |  6 ------
> libavformat/protocols.c    |  1 +
> 7 files changed, 25 insertions(+), 42 deletions(-)

> diff --git a/libavcodec/Makefile b/libavcodec/Makefile
> index a6311411d3..33b913c4fc 100644
> --- a/libavcodec/Makefile
> +++ b/libavcodec/Makefile
> @@ -141,6 +141,8 @@ OBJS-$(CONFIG_MPEGVIDEODEC)            += mpegvideo_dec.o mpegutils.o
> OBJS-$(CONFIG_MPEGVIDEOENC)            += mpegvideo_enc.o mpeg12data.o  \
>                                           motion_est.o ratecontrol.o    \
>                                           mpegvideoencdsp.o
> +OBJS-$(CONFIG_MSMPEG4DEC)              += msmpeg4dec.o msmpeg4.o msmpeg4data.o
> +OBJS-$(CONFIG_MSMPEG4DEC)              += msmpeg4enc.o msmpeg4.o msmpeg4data.o

Typo on the second line, should be CONFIG_MSMPEG4ENC?

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-07-31 10:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31  9:37 [FFmpeg-devel] [PATCH 1/4] avcodec/intrax8: Remove unused IDCTDSPContext Andreas Rheinhardt
2022-07-31  9:41 ` [FFmpeg-devel] [PATCH 2/4] configure, avcodec/Makefile: Make IntraX8 select WMV2DSP, fix MIPS build Andreas Rheinhardt
2022-07-31  9:41 ` [FFmpeg-devel] [PATCH 3/4] configure: Add msmpeg4(dec|enc) subsystems Andreas Rheinhardt
2022-07-31 10:06   ` Martin Storsjö [this message]
2022-07-31 18:33     ` Andreas Rheinhardt
2022-07-31  9:41 ` [FFmpeg-devel] [PATCH 4/4] avcodec/intrax8: Avoid indirection when accessing VLC table Andreas Rheinhardt
2022-08-03  5:11 ` [FFmpeg-devel] [PATCH 1/4] avcodec/intrax8: Remove unused IDCTDSPContext Andreas Rheinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f49aaae-6c97-3bf1-450-12bca3f01331@martin.st \
    --to=martin@martin.st \
    --cc=andreas.rheinhardt@outlook.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git