From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9880249715 for ; Tue, 19 Mar 2024 19:14:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4ACA068D404; Tue, 19 Mar 2024 21:14:55 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 665A468D27E for ; Tue, 19 Mar 2024 21:14:49 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id F3C1DEA197 for ; Tue, 19 Mar 2024 20:14:48 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CMNJSkDD6U_A for ; Tue, 19 Mar 2024 20:14:47 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 45895E63E7 for ; Tue, 19 Mar 2024 20:14:47 +0100 (CET) Date: Tue, 19 Mar 2024 20:14:47 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20240319001554.GI6420@pb2> Message-ID: <7ef509b0-6189-2e85-f1b4-ff2bb748b943@passwd.hu> References: <20240317195729.11755-1-cus@passwd.hu> <20240317195729.11755-2-cus@passwd.hu> <20240319001554.GI6420@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 19 Mar 2024, Michael Niedermayer wrote: > On Sun, Mar 17, 2024 at 08:57:29PM +0100, Marton Balint wrote: >> - Only parse the defined masks in dwChannelMask, unless strict_std_compliance >> is less than normal. This matches with the behaviour of the wav muxer. >> - Ignore additional bits in dwChannelMasks as the MS documentation suggests [1] >> - Assume UNKNOWN channels for missing bits as the MS documentation suggests [1] >> >> [1] https://learn.microsoft.com/en-us/previous-versions/windows/hardware/design/dn653308(v=vs.85)#details-about-dwchannelmask >> >> Signed-off-by: Marton Balint >> --- >> libavformat/riffdec.c | 28 +++++++++++++++++++++++++--- >> 1 file changed, 25 insertions(+), 3 deletions(-) > > breaks: > ./ffmpeg -i ~/tickets/2859/5.1plusdownmix.wav -ac 2 -t 100 -bitexact -c:a aac -y /tmp/2859-frenchspeack-nolibfaac.mp4 After the patch this is file will need -strict unofficial to work, since the downmix channels are not officially recognized in the dwChannelMask. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".