From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts
Date: Tue, 19 Mar 2024 20:14:47 +0100 (CET)
Message-ID: <7ef509b0-6189-2e85-f1b4-ff2bb748b943@passwd.hu> (raw)
In-Reply-To: <20240319001554.GI6420@pb2>
On Tue, 19 Mar 2024, Michael Niedermayer wrote:
> On Sun, Mar 17, 2024 at 08:57:29PM +0100, Marton Balint wrote:
>> - Only parse the defined masks in dwChannelMask, unless strict_std_compliance
>> is less than normal. This matches with the behaviour of the wav muxer.
>> - Ignore additional bits in dwChannelMasks as the MS documentation suggests [1]
>> - Assume UNKNOWN channels for missing bits as the MS documentation suggests [1]
>>
>> [1] https://learn.microsoft.com/en-us/previous-versions/windows/hardware/design/dn653308(v=vs.85)#details-about-dwchannelmask
>>
>> Signed-off-by: Marton Balint <cus@passwd.hu>
>> ---
>> libavformat/riffdec.c | 28 +++++++++++++++++++++++++---
>> 1 file changed, 25 insertions(+), 3 deletions(-)
>
> breaks:
> ./ffmpeg -i ~/tickets/2859/5.1plusdownmix.wav -ac 2 -t 100 -bitexact -c:a aac -y /tmp/2859-frenchspeack-nolibfaac.mp4
After the patch this is file will need -strict unofficial to work, since
the downmix channels are not officially recognized in the dwChannelMask.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-03-19 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 19:57 [FFmpeg-devel] [PATCH 1/2] avformat/riff: pass an AVFormatContext explicitly to ff_get_wav_header Marton Balint
2024-03-17 19:57 ` [FFmpeg-devel] [PATCH 2/2] avformat/riffdec: follow the MS docs more strictly for setting wav channel layouts Marton Balint
2024-03-19 0:15 ` Michael Niedermayer
2024-03-19 19:14 ` Marton Balint [this message]
2024-03-21 8:23 ` Tobias Rapp
2024-03-21 9:40 ` Marton Balint
2024-03-21 10:26 ` Tobias Rapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef509b0-6189-2e85-f1b4-ff2bb748b943@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git