From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4E61840BCF for ; Mon, 5 Dec 2022 04:37:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7E18168BC2D; Mon, 5 Dec 2022 06:37:42 +0200 (EET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D666E68BC09 for ; Mon, 5 Dec 2022 06:37:34 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670215060; x=1701751060; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=02+WGOMdPiTNlcC4OGjv+sWd6XJ8/ErOy2fG+TKjoGU=; b=neI9lJxvE3aUxD3COprCBKcp3LOyopYWx8YPLYKrionn4/WdTBN4MLtE xold1pRvv+e52cL9meAWZt738LC2FSqOM0ggF9yIOx9qtil4lMqH1P0nX Zx4pYpJ1so1JE/+2WCv4yUIfCfmIGk+oHXjyZyBLb2OmgO2q20q8K1hB0 pMWcv7DzUG5VY+WgCdihjna5lB+G5pPga9ValsAUEocQuec+hVgziz/X0 cJ1GcrVUYiRmvds7QVvuTVgJEAGr92Ub10rtmQ8SzppB8btH9IaPbL4PM jOHIUdVVW9zU+mcRCchGmUjTUtKXETfjFWs9t9IU56wKJvDzKOOmRGTJ2 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="317405043" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="317405043" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2022 20:37:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10551"; a="645679521" X-IronPort-AV: E=Sophos;i="5.96,218,1665471600"; d="scan'208";a="645679521" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 04 Dec 2022 20:37:31 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 4 Dec 2022 20:37:30 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 4 Dec 2022 20:37:30 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 4 Dec 2022 20:37:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HMJVUd9t9fpmEeNW+axns7PVuLquxpxmj2cd6OYS5nO8Py72bYsnNXmfWE7sMMa8/K8jB/9zl3PlvjrSig5vfjP2DtEuvNmkQ2QC5fnNjLHrglXRNiKK1kdlBaAeo6H625NEt0Zd1ex2R8/+h9b6F83VuzEiYPkhqmvDXqBFJECUqnzsE2pd9f2mqBs3YjgaU47KMtMaHa0JHBtCeetsUOeZz9CimjOax4iRf8HOpSSzAFp1233sQjJ3Xy2M96x7DjjiO1AE0jpcjLxXAfY8MocjjyHpA29v/D9aBVhdDvoW766dhGK1EwmeMzVTeRsUtw6kETMMp1q64luRaRwSXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02+WGOMdPiTNlcC4OGjv+sWd6XJ8/ErOy2fG+TKjoGU=; b=Mc5JcYcfNLyo3FhNFHRSdsPep+pPPdiI78KQHgIpckqy6bHrxazMcb9FLqoW8K00JXT61KDgcIFEcNrYIznHlX3XXEK121pF5TxJz4a7vK6wefTsx74KfI9rTxy9eMPJWo6x5L+EETYbBaj7/UeHEVM+njFtXZi0ferXAPevNulTkur4+Itd5+KmHzniuncx5Wh4cm4CmKW3OO627wGVVXrwuO/VJ3+g3g4yDgwY/vppEm4bZ8Wak79oNlcsjKX9hI2eTxodRmKSDpTyzXv2osXFvovz2TdOhhGtnLA32LmWdzBF/nKSemjmLMFasjo1ix6ixbTKJVpeADqFPOFhig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DS0PR11MB7312.namprd11.prod.outlook.com (2603:10b6:8:11f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.11; Mon, 5 Dec 2022 04:37:29 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::e3ef:177c:4008:7ee9%5]) with mapi id 15.20.5880.013; Mon, 5 Dec 2022 04:37:29 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Skip 'vgem' driver Thread-Index: AQHY/4ZBvsVCB/L7uE6qO3zW4YivGq5ex3+A Date: Mon, 5 Dec 2022 04:37:29 +0000 Message-ID: <7ef2d283c35de47f6d2c38236d3d649e49a5eac2.camel@intel.com> References: <20221123215444.1754721-1-briannorris@chromium.org> In-Reply-To: <20221123215444.1754721-1-briannorris@chromium.org> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|DS0PR11MB7312:EE_ x-ms-office365-filtering-correlation-id: 63ca82d7-8c2f-424e-0c5e-08dad67a6ae3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ld6ZIyS7FHyGPtFxAmsqM6c2G2WCJcn+gLGLbGDzvAz2ZAry+SRe3AFxc6JmSs2MVG/Gsi0XM0dW3aGMxxFa+x3pl1tZNteGu5X4jkGI3gT0rQGUfNi4CuCNW6Ai13sgkunPbmsKMW1lr2OHo1XOzCCFryPM+m2QQXDbzKpay6Nc9ma3dg0fcTVRIDEZ1podPhzMz1YwP3Iojyw5i/Ycw5qdC1JUkr4PdWJq2vT19A2WjuFR/30zJJF1z6dKK/HOqzSD/Qgl3OwaEwsYzqmwcLqreR69G2KhuA3mgS6/nrFHNy4doS2DKsCWJvfB/DnWsqu+G9P0Ww60cYWaASYmTlzzm1J783RKRdVDhY8RM0bkwNYijB7sOTWaXgyqUaDEb6qGsj0hY3t7Lq1Uu48KjDaVBoCVEMkLHg06fFf3bCF71JyiFHWvlgSExcNFbUKU+LSzJZVJApqI/8kGuJd9h+0RV7KdDxBTEzhuY61N0qa/1G8QudDu20CWi4H1B73Hphikg7MHn3GRkVFh8Pcx+0JOuEBdTJ7oOjsfvBeK+MSJAH3BauxUs+Crv0k+UP3JTkrhxP8QEXDQ+9wexLe5jQXRRG5FGVGq4l8jEuGUjWP4TIhoy0MzLzlLljt323MC/D3IyFzcmJJC6GMp8aEHVXC35nqDZr8/QhKQKZJEx7wy8LcQ+diWLruRyxRMStcuu9q8zFPD/asu19fOxaL6aQWg90xH09pLCNz1LnS5pc8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(376002)(396003)(346002)(136003)(39860400002)(451199015)(2906002)(4001150100001)(316002)(86362001)(83380400001)(6506007)(6512007)(966005)(6486002)(26005)(186003)(6916009)(71200400001)(478600001)(2616005)(82960400001)(41300700001)(5660300002)(8936002)(38070700005)(38100700002)(4326008)(91956017)(76116006)(66556008)(66446008)(66476007)(64756008)(66946007)(122000001)(8676002)(36756003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OTdyWlNPc3VwZUFrdXlvbWZHU0xmbGpMRXZSK29KTzZjcUNQUlJrK1JrRVZR?= =?utf-8?B?bEZzSVRHWE56eXpXMElIT25yS2hFSldmV0FRRVJaWWVabXZlSVZncnViSHdQ?= =?utf-8?B?ZXZyMGVzUmxmbmc0QUROaUoySzJFaXMxSEhROHRmaHJJS2NodjYrSFdtNUNG?= =?utf-8?B?WEtyT3YwVFRJMy9iN3hKYkl1aTdWZTFXc2J1TjdTdU9XSVIrNGlnL2tFb0U1?= =?utf-8?B?VTBLMEp0bFhKS3RieHg2RytJVk5COXNaZUZkWkdXNmtKZWlrSjRhS240SmNr?= =?utf-8?B?bTZ5VGlHSnlqU3Q4TGp2VVZSd0FnR25ETEhjZzRxaGhMVzI5WVpqL2NIczJw?= =?utf-8?B?N2JQNitzZWhDRTk4b0FLUU5iR0I5eTAzckpOaHc1bmpnbitWRWlHbDJCQStv?= =?utf-8?B?alVUSUtxUlJTS3l6dkt3QTJhMXhyTkxBNXNaVmFLYVJsejdKTGRxQWtGS1NQ?= =?utf-8?B?Q2RDYVd3NlVPL0dRMitjYnE1bVB2UjhreG9wT0lLY2ltZDY3YVZLK0pvOWdr?= =?utf-8?B?eXFhWW90TTR0OTlOcUtSUTdDOVhhODIwN0NPaW5HVE1OV0F0T211Y1Bjc3hv?= =?utf-8?B?cXBRcmJ6QjIvYlVVbnNseldyMnRLbm5FMXZrR21xYnJPRzh3cmRZOFlzYTRQ?= =?utf-8?B?dnAzdWdhVVNXQ1BiRXd5YS9hcFRHalJ5TmNJeHhMWTVLblVHUlhDelVueU5V?= =?utf-8?B?VHlnU0IyTmhJNDJNaWprdE5wRHZ2VXJtTFBzbnlUUjRhakUxSmRkN0p2L1NR?= =?utf-8?B?UFI2S0gvbVlsN29PWVc5V3RUd1lERTZqT2tpRmIwSzdoNVhpN3RQeXhDZjJ4?= =?utf-8?B?c3BncFNYbnVnM3dPa2JjcW9zdzF0Tk1JY2JPeS9UU2gwVCt5WXprdjZMVmp3?= =?utf-8?B?TlpHMTEzRFUwM3BleVJkOGswajFDb09VOVptVytTMTNrWWM0a0ZibnAyVkVX?= =?utf-8?B?RTJMRXZ4dXkxSUQwWGNpOFFrY3VlK2VQbG9kQ3JVblhUcURmUFdjV1ZLQzZX?= =?utf-8?B?b3AxR2VhVjBURWxwTDJpK1pGSlhwWXdiQTBNM1dob3FUemRzY0Y1bFN6WDBX?= =?utf-8?B?enVHR1Q1Y1dRUml2NHo5SGNMSVBwK1ZLenNncGpURWl0aGh5ZTNaMTI0QlVD?= =?utf-8?B?bDR1VlRxSXJYTVJSYzVZcTExZE1iQWFYL1RmLzNoMTBMSFNONmdnYkZEMkhE?= =?utf-8?B?QzI2T1lzZUZwVjRIVlpJTDE4bVNKUjAwTERTbldvVmdzdlR4Q2JjRXdrWHBE?= =?utf-8?B?bGprWmtzaFFmNVFRNUp4QzV6bmZnWFJXbVcrTEtITkVwb1VMOFp4dHM4a0pU?= =?utf-8?B?Rk96YjgzZ3lqVkN4OUdQS2FjaGE0Z1FpaDNzaStjRlEvVWZxOStISkEvYjMw?= =?utf-8?B?NnBjNzRzZFZKbU1MZmJlVllXQlZkQ0hQVWl0ZzVpQXJYQVdZR0szVVFoTkVT?= =?utf-8?B?MHBaZnR1RkhleUxPdXRzR2gyOEpZUVZYeHNXb1BRUzdQcTgzMDgwOTY3T1lo?= =?utf-8?B?aGZFZ0lyTG5uUURLeDB2TG4vUjRFbVhWcUtOb2dDcGpTRlo1b2RueHkvcDg5?= =?utf-8?B?bkFVazJNakRHVDRvM3JHcG9GdTJIQTJBM2ZEQUkyTHI4UDVtUDQzeXBoK3Aw?= =?utf-8?B?Wk1iUUhpT2UxUzdIUTNwNThEWkJSRC9PLzFDZlFDQ2ducjRZeWkweHY1TXBV?= =?utf-8?B?R2NVVTNxL3dPMzdsRzVKcEhFSmIzdlpRUFg1TmxRV2QxazJJR3hKeTR6bjNa?= =?utf-8?B?Y240SzVKVmF4elI0N2NML0k0RCtvdUlqUzlmMXhqa3k3S3JwVWFnNTlFYmF0?= =?utf-8?B?N0p2c25za2xjZzNsLytGQ0l0N0t3bWRJUVNid2h0STYwRnltVGdGVWNUendM?= =?utf-8?B?ME1lWW1FWkdCR0VpbjhQS3crSGIzd3JGZDNpVHR0TEJ1djVkQ2xJcFFQaVhw?= =?utf-8?B?d2Z1d3NwUHBuczNBRyt2akVybC9vL0prK0lpMFJmdTFaSHNqMWJrUW1oUnhV?= =?utf-8?B?bTVSZHBBdm50WDhiOTEwWkw5TWl3czFkeFJjckMvN2lKMDBnNTRzeXZKQnRI?= =?utf-8?B?ZS9lTzZENHgvdmlHcVZpaGtFY1NYcWVKYVpoTVg5dDdDNDdOdktmWDZWeVNT?= =?utf-8?B?OFVvKzVhRmxDRElTOWZMRGM1OUdIM001WGdmeWE3dEU2VkNaQko1NVV0eUx0?= =?utf-8?B?UVE9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63ca82d7-8c2f-424e-0c5e-08dad67a6ae3 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2022 04:37:29.3497 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tszoh2V5O2CuOg8hP/zTVPdGdLOhXZ5xJ3mP2vXBGbdmkzV1++LE/E9NLShbJz9ejsjT5nweSh/fiba5VvUhMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7312 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_vaapi: Skip 'vgem' driver X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "briannorris@chromium.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2022-11-23 at 13:54 -0800, Brian Norris wrote: > There can be more than one available render node, and it's not > guaranteed the first node we come across is the correct one. In > particular, 'vgem' devices are common, and are > never VAAPI-enabled and thus not valid here. > > We have a 'kernel_driver' arg already for specifying a single driver we > *do* want, but it doesn't support a negation, nor a list. It's easier > just to automatically skip 'vgem' anyway, to avoid foisting this burden > on users. > > This has precedent in libva-utils already: > > bfb6b98ed62a exclude vgem node and invalid drm node in vainfo > > https://github.com/intel/libva-utils/commit/bfb6b98ed62ac14a840ba62639ab902a23912258 > > Signed-off-by: Brian Norris > --- > > libavutil/hwcontext_vaapi.c | 28 +++++++++++++++++++++------- > 1 file changed, 21 insertions(+), 7 deletions(-) > > diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c > index 4bcde74f6212..84b03b633251 100644 > --- a/libavutil/hwcontext_vaapi.c > +++ b/libavutil/hwcontext_vaapi.c > @@ -1700,6 +1700,7 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, > const char *device, > char path[64]; > int n, max_devices = 8; > #if CONFIG_LIBDRM > + drmVersion *info; > const AVDictionaryEntry *kernel_driver; > kernel_driver = av_dict_get(opts, "kernel_driver", NULL, 0); > #endif > @@ -1713,9 +1714,15 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, > const char *device, > break; > } > #if CONFIG_LIBDRM > + info = drmGetVersion(priv->drm_fd); > + if (!info) { > + av_log(ctx, AV_LOG_VERBOSE, > + "Failed to get DRM version for device %d.\n", n); > + close(priv->drm_fd); > + priv->drm_fd = -1; > + continue; > + } > if (kernel_driver) { > - drmVersion *info; > - info = drmGetVersion(priv->drm_fd); > if (strcmp(kernel_driver->value, info->name)) { > av_log(ctx, AV_LOG_VERBOSE, "Ignoring device %d " > "with non-matching kernel driver (%s).\n", > @@ -1730,12 +1737,19 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, > const char *device, > "with matching kernel driver (%s).\n", > n, info->name); > drmFreeVersion(info); > - } else > -#endif > - { > - av_log(ctx, AV_LOG_VERBOSE, "Trying to use " > - "DRM render node for device %d.\n", n); > + break; > + } else if (!strncmp(info->name, "vgem", 4)) { The virtual GEM device is vgem, so better to use strcmp here. Thanks Haihao > + av_log(ctx, AV_LOG_VERBOSE, > + "Skipping vgem node for device %d.\n", n); > + drmFreeVersion(info); > + close(priv->drm_fd); > + priv->drm_fd = -1; > + continue; > } > + drmFreeVersion(info); > +#endif > + av_log(ctx, AV_LOG_VERBOSE, "Trying to use " > + "DRM render node for device %d.\n", n); > break; > } > if (n >= max_devices) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".