From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9F7D4445C2 for ; Fri, 16 Sep 2022 21:17:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B66F368BB99; Sat, 17 Sep 2022 00:17:17 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C4AC068BB99 for ; Sat, 17 Sep 2022 00:17:10 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 28GLH7hl028527-28GLH7hm028527; Sat, 17 Sep 2022 00:17:07 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id BD9E7A1467; Sat, 17 Sep 2022 00:17:07 +0300 (EEST) Date: Sat, 17 Sep 2022 00:17:07 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Hubert Mazur In-Reply-To: <20220913115824.60792-4-hum@semihalf.com> Message-ID: <7ec4d690-6aa9-4f27-d9f7-b29db8be25ef@martin.st> References: <20220913115824.60792-1-hum@semihalf.com> <20220913115824.60792-4-hum@semihalf.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavc/aarch64: Add neon implementation for pix_median_abs8 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: gjb@semihalf.com, upstream@semihalf.com, jswinney@amazon.com, ffmpeg-devel@ffmpeg.org, mw@semihalf.com, spop@amazon.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 13 Sep 2022, Hubert Mazur wrote: > Provide optimized implementation for pix_median_abs16 function. Forgot to update this part of the commit message here too. > Performance comparison tests are shown below. > - median_sad_1_c: 273.7 > - median_sad_1_neon: 98.2 > > Benchmarks and tests run with checkasm tool on AWS Graviton 3. > > Signed-off-by: Hubert Mazur > --- > libavcodec/aarch64/me_cmp_init_aarch64.c | 3 ++ > libavcodec/aarch64/me_cmp_neon.S | 65 ++++++++++++++++++++++++ > 2 files changed, 68 insertions(+) The same comments as for patch 1/3; looks reasonble, a bunch of leftover mov instructions which I don't see how they'd be necessary, and please avoid the extra single-lane handling and just do plain vector operations, and extract the single lane at the end. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".