Re: [FFmpeg-devel] [PATCH 0/4] avformat/hls: Some extension fixes that need testing

From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 0/4] avformat/hls: Some extension fixes that need testing
Date: Sun, 6 Apr 2025 09:20:58 -0400
Message-ID: <7e33746e-5772-4f82-87b1-7fa0ebbd9f09@gmail.com> (raw)
In-Reply-To: <20250406111944.706970-1-michael@niedermayer.cc>

On 4/6/25 7:16 AM, Michael Niedermayer wrote:
> Hi all
> 
> This patchset adds all the extensions i found on trac and its links to
> allowed_extensions for hls.
> There was one testcase only so most of this is untested. It may be
> needed to add the extensions also to demuxers or as exceptions
> specific to hls elsewhere.
> 

If the issue at hand is that bad extensions can cause invalid 
demuxers/decoders to be probed, why don't we just use a demuxer or 
decoder whitelist? We already have code to support this.

It feels like we're going to be sending these sorts of "add this one 
extension we didn't think about" patch over and over again when we could 
have just solved the original problem. This feels like an XY problem, we 
really want to accomplish X but we're solving Y because we believe it 
will fix X. Rather than just fixing X.

- Leo Izen (Traneptora)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".