From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: ensure lmin is smaller than lmax
Date: Tue, 18 Apr 2023 08:57:24 -0300
Message-ID: <7e318956-b9ff-0600-bd17-3776b4673148@gmail.com> (raw)
In-Reply-To: <20230414193454.3538-1-jamrial@gmail.com>
On 4/14/2023 4:34 PM, James Almer wrote:
> Fixes ticket #10234
>
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> libavcodec/ituh263enc.c | 5 +++++
> libavcodec/mpegvideo_enc.c | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/libavcodec/ituh263enc.c b/libavcodec/ituh263enc.c
> index c30ecad438..97abfb3f45 100644
> --- a/libavcodec/ituh263enc.c
> +++ b/libavcodec/ituh263enc.c
> @@ -865,6 +865,11 @@ av_cold void ff_h263_encode_init(MpegEncContext *s)
> s->c_dc_scale_table= ff_mpeg1_dc_scale_table;
> }
>
> + if (s->lmin > s->lmax) {
> + av_log(s->avctx, AV_LOG_WARNING, "Clipping lmin value to %d\n", s->lmax);
> + s->lmin = s->lmax;
> + }
> +
> ff_thread_once(&init_static_once, h263_encode_init_static);
> }
>
> diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c
> index bcd2f9ef1d..efd8e63aa8 100644
> --- a/libavcodec/mpegvideo_enc.c
> +++ b/libavcodec/mpegvideo_enc.c
> @@ -798,6 +798,11 @@ av_cold int ff_mpv_encode_init(AVCodecContext *avctx)
> AV_CODEC_FLAG_INTERLACED_ME) ||
> s->alternate_scan);
>
> + if (s->lmin > s->lmax) {
> + av_log(avctx, AV_LOG_WARNING, "Clipping lmin value to %d\n", s->lmax);
> + s->lmin = s->lmax;
> + }
> +
> /* init */
> ff_mpv_idct_init(s);
> if ((ret = ff_mpv_common_init(s)) < 0)
Will apply.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-04-18 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 19:34 James Almer
2023-04-18 11:57 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e318956-b9ff-0600-bd17-3776b4673148@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git