From: "Jean-Baptiste Kempf" <jb@videolan.org>
To: Lynne <dev@lynne.ee>, ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] aacdec: correctly skip padding at the start of frames and during seeking
Date: Mon, 30 Oct 2023 08:38:10 +0100
Message-ID: <7e230234-7cc6-4c31-ae7b-fd86ef616f7a@betaapp.fastmail.com> (raw)
In-Reply-To: <NhyzMEL--3-9@lynne.ee>
Hello,
Does this fix #2325 #9667?
jb
On Mon, 30 Oct 2023, at 06:10, Lynne wrote:
> Presently, our AAC decoder didn't skip any samples, unless the side data
> contained skip information.
>
> This uses the newly added ff_decoder_skip_samples function to skip samples
> on two levels: base, and additional.
> Base is the inherent decoder delay. Most containers already specify it,
> hence it is overwritten in that case.
> Additional is any extra samples that have to be skipped, in AAC's case,
> it's the delay introduced by SBR.
>
> Patch attached.
>
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
> Attachments:
> * 0002-aacdec-correctly-skip-padding-at-the-start-of-frames.patch
--
Jean-Baptiste Kempf - President
+33 672 704 734
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-10-30 7:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 5:09 [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function Lynne
[not found] ` <Nhyz9MY--3-9@lynne.ee-NhyzDNG----9>
2023-10-30 5:10 ` [FFmpeg-devel] [PATCH 2/2] aacdec: correctly skip padding at the start of frames and during seeking Lynne
2023-10-30 7:38 ` Jean-Baptiste Kempf [this message]
[not found] ` <7e230234-7cc6-4c31-ae7b-fd86ef616f7a@betaapp.fastmail.com-NhzWMs9----9>
2023-10-30 17:03 ` Lynne
2023-11-04 10:41 ` [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function Anton Khirnov
2023-11-04 16:22 ` Derek Buitenhuis
2023-11-04 17:32 ` Derek Buitenhuis
2023-11-04 17:41 ` Michael Niedermayer
2023-11-04 20:33 ` Lynne
2023-11-04 23:02 ` Martin Storsjö
2023-11-04 23:27 ` Lynne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e230234-7cc6-4c31-ae7b-fd86ef616f7a@betaapp.fastmail.com \
--to=jb@videolan.org \
--cc=dev@lynne.ee \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git