From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4475345ED0 for ; Mon, 17 Apr 2023 11:32:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3103C68BE2D; Mon, 17 Apr 2023 14:32:26 +0300 (EEST) Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A212468924F for ; Mon, 17 Apr 2023 14:32:19 +0300 (EEST) Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-187bee46f9dso8492528fac.11 for ; Mon, 17 Apr 2023 04:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681731138; x=1684323138; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZMKzI9OivuY/Q3SX3eoo+1prI8AG1yIwk+ZoGzNmWvM=; b=EiZWn+V6m6jJwVHqL5KXR7V9yHBerLBtaTMWOSAcb4nHnmsBHsrVFr5sBX7zdRiuSj Q+ilcntBSNWXGh2vLOo2wZcEuH0G1xBErh3/c8GURH/Iw8h/wW7plIIENEeJG5/2WUT5 EHnaaobh/P7rO963immTwapVG+5OeO3AscBK1kcc0DQswUpLEhgRhHAHC2Q66qNrdY4U v749qqP4zd3uW8N6HHWyiZ2H906v7F+UJx1g7nLAq1MY0Vb0JHlYYaMmhV7FcpKMhFAJ /MDGOqhUE7Rs09QApcYNNQ/TWpTVuU76wAy8tZOTtqn8C4fxDLr+dUqYNfpLGUl4civ+ pCnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681731138; x=1684323138; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZMKzI9OivuY/Q3SX3eoo+1prI8AG1yIwk+ZoGzNmWvM=; b=b+EM7lhTAcTdxD0a27wOObxMkcHG7G8pFLBlfUuvMA5fxR2Yir9kjMWJOnpKUnArp/ 2C8JYjBu9W655Hadt153j6BJD02hKZZce42Cef1TZbbXlp8o9o3FmZ2ua2jbqbkR5Ubl W2qkQuhdE5HP9GhFrnQnYn2UFjTWbv3wzqU12049rxo5tbtDlSoO4S1u7JUDQ8n04+4c qmIS/VYUixCd54r/rWw30G1VGIbOgsl4HyDi70SPMiIN7CA0ibAk4dE/Nzc9oDCjtIcb b++LwFDEsgdHh7cfHaV8Ck0XZPjkPGY34KOH0HLCxAr+06AHNO2rOdBJO8dp2pNC76MZ kBLw== X-Gm-Message-State: AAQBX9fSaHYTN9jI15e8Bk1bkFTsCAnWDxymv0nSnGNuVqWQmehg7p9v obf3wx+4+95gDJeH9TABlOX14+K+HEI= X-Google-Smtp-Source: AKy350YP+gScLyFQyjKsYy+Qhm1g/lG8XiAUrZ0Vak5mOPRetn04Ze7K8ZuHznAGeG2HwEZJFGmlsQ== X-Received: by 2002:a05:6870:c087:b0:187:806f:432f with SMTP id c7-20020a056870c08700b00187806f432fmr9365828oad.41.1681731137970; Mon, 17 Apr 2023 04:32:17 -0700 (PDT) Received: from [192.168.0.15] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id bd6-20020a056871b30600b0017281100b75sm4372385oac.42.2023.04.17.04.32.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 04:32:17 -0700 (PDT) Message-ID: <7dd256a0-7ce5-8609-8ba2-abf79a33d730@gmail.com> Date: Mon, 17 Apr 2023 08:32:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230412194936.48022-1-jamrial@gmail.com> <168172855674.3843.120092233348005833@lain.khirnov.net> From: James Almer In-Reply-To: <168172855674.3843.120092233348005833@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/5] avutil/frame: add new interlaced and top_field_first flags X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/17/2023 7:49 AM, Anton Khirnov wrote: > Quoting James Almer (2023-04-12 21:49:32) >> Signed-off-by: James Almer >> --- >> Missing version bump and APIChanges entry. >> >> libavutil/frame.h | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> > > Changing all those into bitfields of size 1 might be better, because no > code would need to be changed. Can you elaborate on this? If i do > diff --git a/libavutil/frame.h b/libavutil/frame.h > index f85d630c5c..3f3deab657 100644 > --- a/libavutil/frame.h > +++ b/libavutil/frame.h > @@ -494,12 +494,12 @@ typedef struct AVFrame { > /** > * The content of the picture is interlaced. > */ > - int interlaced_frame; > + int interlaced_frame: 1; > > /** > * If the content is interlaced, is top field displayed first. > */ > - int top_field_first; > + int top_field_first: 1; > > /** > * Tell user application that palette has changed from previous frame. It's not only an ABI break, but i assume the compiler will still pad/align the struct for the next field, so you're not saving many bytes. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".