Re: [FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests

From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] fate.sh: Allow overriding what targets to make for running the tests
Date: Thu, 30 Nov 2023 18:28:39 +0200 (EET)
Message-ID: <7d54d098-3461-7eaf-2263-5c9a3bd9717@martin.st> (raw)
In-Reply-To: <2804232.DsgiF8beE4@basile.remlab.net>

On Thu, 30 Nov 2023, Rémi Denis-Courmont wrote:

> Le torstaina 30. marraskuuta 2023, 17.34.31 EET Martin Storsjö a écrit :
>> Yeah, I wouldn't reuse an existing build here. For the setup I have in
>> mind, one build doesn't take too horribly long (either on an old desktop
>> x86 machine, or a moderate aarch64 server) - so it's not ideal but not a
>> dealbreaker anyway (while running all of fate with qemu takes one
>> magnitude longer).
>
> Well it's pretty much a deal breaker for Armv9 and RV. I can understand 
> wanting to build on a comfy x86 server, but doing different builds just to 
> change QEMU CPU flags is IMO inept.

Yes. But for doing one single run with QEMU, I don't mind.

Again, for SVE, I'd rather have testing with 1 config (the default, which 
is longer vectors than one usually encounters in HW) rather than none at 
all. It won't catch every theoretical issue but practically would catch 
many things at least.

Are you volunteering to write FATE integration to run checkasm multiple 
times with different QEMU settings, so I can wait for that instead of 
having much improved public test coverage right now?

> Sure, we could just build once and run several times checkasm with a separate 
> script, as I already pointed out. But then this patch is completely 
> unnecessary.

Indeed, that's trivial to do for a private testing setup.

>> For the other setup I intended to test, to test AArch64 PAC and BTI, I
>> would do a separate build with -mbranch-protection=standard anyway.
>
> That does not make much sense to me. PAC and BTI should be enabled by default 
> in compatibility mode (for ARMv8.0-8.2 builds) or noncompatibility mode (for 
> ARMv8.3+ builds).

Maybe it should - but it currently isn't.

And in order to actually test BTI, one has to link with a sysroot that 
also was built with BTI enabled - I currently use a sysroot extracted from 
fedora for that. (And my tests for it use -Wl,-z,force-bti.)

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".