From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 45D5D47566 for ; Sun, 10 Mar 2024 22:29:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0A29568CF45; Mon, 11 Mar 2024 00:29:37 +0200 (EET) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 32E4D68CE16 for ; Mon, 11 Mar 2024 00:29:31 +0200 (EET) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6e64997a934so2923791b3a.0 for ; Sun, 10 Mar 2024 15:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710109768; x=1710714568; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=XOM/z9ss573baAAV5ntNdm9iurdSDpaGMs0aITwOQ2k=; b=XbwpGJewDxjMYdpcGhkVS96KJAG477tfgGL/SuvVTpdqt7ioiIyLxek3gzP83AlV0Y ostq3oc6iyKGFevdFaF5x3FUmA5GlL1V/ybGpAaIFGfsYGWR0dzaqBjBwCzclUut5//v gbTMAp7AqonU5K9bXVkXCWnB8oMqxpk1lyfU/lgUp1MWlALegD6oekZuwwR1TqxOhuJF jSnlHgLS+R0VNmNmo3gQF13KWC/MGqpzbxddZYtFcLGqY+INjxNoreD74m4T/uG5dIpI CqVTzT5/QEEjV/wAbKAYiIaeJrnt+IxbCDIXo7rUFSTW/GleDUjJRsXrBhZcq6T3+LZv 9nmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710109768; x=1710714568; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XOM/z9ss573baAAV5ntNdm9iurdSDpaGMs0aITwOQ2k=; b=C2QiWR9IreVu17O63C6Yj3Moed1oIC47jNYhGBwZ6txeB1ybzgiNKSql3kseLl+F7S hkeCCIEZREd3reTY8zxgLpPWnxQIQzTxgnw9Lm+fVypl4QzdeWcjQyprEzZfpfnHZ12j e8GpXErERp+axPSDAkk6EXVUEgxHfUqhcjHwWGnuw0GXybFDMVQIZmjGx8Tgs1v6SJx4 0jF1X8SjwmuFg28cCqY43i3CHy+Ku+G129OWi4EXSTv5mKSuQG9LAYiJ/JdBfLRVaTMK 05cuoFk2CbkKJu58Akfc2STV/zhpJSuTJi3W9YRLado7J2f1GY4urs0H5eR5p+DOGjaj fVcA== X-Gm-Message-State: AOJu0YxJI8+3vxj+pT9r+P2dYjDS2EAyrl4y+yBGNVKEcE0hhf/e5lOf h40WCpfdaA3pMNjURgg6NBeB2W1RTsf2Bwa7OYab73bcE5MtlUXNr9ceBkZT X-Google-Smtp-Source: AGHT+IH7VY15nHXgzkR+WCuQYhAwj0jiCxm/b7FVjhDTKlhmS8uBJ+tBwXR/OEFejlSC5/mWo6L4eg== X-Received: by 2002:a05:6a00:93aa:b0:6e6:351c:bb28 with SMTP id ka42-20020a056a0093aa00b006e6351cbb28mr5557307pfb.19.1710109768373; Sun, 10 Mar 2024 15:29:28 -0700 (PDT) Received: from [192.168.0.14] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id n4-20020aa78a44000000b006e64ee44f51sm2991406pfa.71.2024.03.10.15.29.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Mar 2024 15:29:27 -0700 (PDT) Message-ID: <7d011f1c-f131-412c-85ce-318c71efba0f@gmail.com> Date: Sun, 10 Mar 2024 19:29:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240306110319.17339-1-anton@khirnov.net> <20240306110319.17339-2-anton@khirnov.net> <20240307203739.GI6420@pb2> <170987607651.7287.4766174024309496140@lain.khirnov.net> <20240310033629.GM6420@pb2> <171005119864.662.10837664362214202636@lain.khirnov.net> <20240310192147.GQ6420@pb2> <171010947057.7287.8642196154964262055@lain.khirnov.net> Content-Language: en-US From: James Almer In-Reply-To: <171010947057.7287.8642196154964262055@lain.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 02/18] fftools/ffmpeg_filter: refactor setting input timebase X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/10/2024 7:24 PM, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-03-10 20:21:47) >> On Sun, Mar 10, 2024 at 07:13:18AM +0100, Anton Khirnov wrote: >>> Quoting Michael Niedermayer (2024-03-10 04:36:29) >>>> On Fri, Mar 08, 2024 at 06:34:36AM +0100, Anton Khirnov wrote: >>>>> Quoting Michael Niedermayer (2024-03-07 21:37:39) >>>>>> On Wed, Mar 06, 2024 at 12:03:03PM +0100, Anton Khirnov wrote: >>>>>>> Treat it analogously to stream parameters like format/dimensions/etc. >>>>>>> This is functionally different from previous code in 2 ways: >>>>>>> * for non-CFR video, the frame timebase (set by the decoder) is used >>>>>>> rather than the demuxer timebase >>>>>>> * for sub2video, AV_TIME_BASE_Q is used, which is hardcoded by the >>>>>>> subtitle decoding API >>>>>>> >>>>>>> These changes should avoid unnecessary and potentially lossy timestamp >>>>>>> conversions from decoder timebase into the demuxer one. >>>>>>> >>>>>>> Changes the timebases used in sub2video tests. >>>>>>> --- >>>>>>> fftools/ffmpeg_filter.c | 17 ++- >>>>>>> tests/ref/fate/sub2video_basic | 182 +++++++++++++------------- >>>>>>> tests/ref/fate/sub2video_time_limited | 8 +- >>>>>>> 3 files changed, 106 insertions(+), 101 deletions(-) >>>>>> >>>>>> breaks: >>>>>> >>>>>> ./ffmpeg -i \[a-s\]_full_metal_panic_fumoffu_-_01_-_the_man_from_the_south_-_a_hostage_with_no_compromises__rs2_\[1080p_bd-rip\]\[BBB48A25\].mkv -filter_complex '[0:s:1]scale=800:600' -t 15 -qscale 2 -y a.avi >>>>>> >>>>> >>>>> Use a constant framerate. >>>> >>>> why not automatically choose a supported timebase ? >>>> >>>> "[mpeg4 @ 0x55973c869f00] timebase 1/1000000 not supported by MPEG 4 standard, the maximum admitted value for the timebase denominator is 65535" >>> >>> Because I don't want ffmpeg CLI to have codec-specific code for a codec >>> that's been obsolete for 15+ years. One could also potentially do it >>> inside the encoder itself, but it is nontrivial since the computations >>> are spread across a number of places in mpeg4videoenc.c and >>> mpegvideo_enc.c. And again, it seems like a waste of time - there is no >>> reason to encode mpeg4 today. >> >> This is not mpeg4 specific, its just a new additional case that fails > > The case you reported is mpeg4 specific. > >> ./ffmpeg -i mm-small.mpg test.dv >> [dvvideo @ 0x7f868800f100] Found no DV profile for 80x60 yuv420p video. Valid DV profiles are: > > There is no mechanism for an encoder to export supported time bases. Could it be added as an extension to AVProfile, or AVCodec? > >> IMHO ffmpeg should be able to select supported parameters if the user >> indicated thats what he wants >> >> We also do this with pixel formats and not fail and require the user to manually >> specify it > > AFAIK only a tiny number of obsolete encoders place restrictions on the > timebase, so I see little point in spending effort on making them work > automagically. > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".