From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0DF2844C94 for ; Wed, 15 Mar 2023 14:46:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 563B868BD2E; Wed, 15 Mar 2023 16:46:51 +0200 (EET) Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 49CA368BD2E for ; Wed, 15 Mar 2023 16:46:45 +0200 (EET) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-17ab3a48158so5046968fac.1 for ; Wed, 15 Mar 2023 07:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678891603; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UcRDZJm8vtTymajtrOm7WOzccS9rMA08M5aA6ThIxx4=; b=Bbo6E/NIFFohBF5fqMU9e3HFzODVjIaoeEDhiNMyxtX4X+mLrAGm9semGTEFfAOxqL HdtTiZIDNHSb7aqNReZuMVQZlueO6oRpFTlkakkU/S2RwQE2gmH59J61g5fk637SBdCA H0CgSIpwMOouLZtDAgBGSmKhlYlid0OIQtIi08LHwT3I/2GXsMaLqd5mBvNZ8HHq+GSh SELB9dRbKOi6dkd4DxobsWPkN2r9s12Tw9o1+aCZd5C0/66qZOQqC5fq34DEqQ2v+5XF Mtl8dczHMIN0761m0YOxMOrwHD8DbGtaRtyPon+LCsl2F6NmB3yK7xAGk2S5TVLKE1xX cz0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678891603; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UcRDZJm8vtTymajtrOm7WOzccS9rMA08M5aA6ThIxx4=; b=K+HxXCRWvwg2ZV/E2BjCB9ktYWOv7l4OecTMSbZU1r8+0zIHg+kN/LTV9YkWbVxUm2 4TT22DNCCNYKvDrH8R50GAHPSqA2/jd6346jtIaQwanjXKGmu7dXVwmY0MK3+EQnx8f2 bXcFOOyC/Uw7W8cRrKPs6UZd3GW8O7+z8qgZYBV++QnUqoA1bqBgyVvjWQqEkRfJQQvh uHiRylw3WGYXZPNI5DaRVbWX0P1+af9gOAylOeC6o3PhRlRGj1sS6KGUgQsubRC0ppod /boyUnwV91iKCR0BGvZHFjkRrKLZ22VRW4g7BMGUjz3a696EaVVPIFHtGsvb6oh0CT2P thpw== X-Gm-Message-State: AO0yUKV3wHpOZ9xecqG4nT56RkM4uQV9FBFnSI3ToPvMulnhgyqv7F9O CQLthTR1JSXd23Z00yFwatIr3QvHZHU= X-Google-Smtp-Source: AK7set8baDm0uveOmP9pJhtDZFG29mhBuhDh5R4zIXWZiao+PpRggDsJxOaovrpBrd0kjPYDKljaWQ== X-Received: by 2002:a05:6870:630a:b0:177:7dae:42e4 with SMTP id s10-20020a056870630a00b001777dae42e4mr11935969oao.27.1678891603348; Wed, 15 Mar 2023 07:46:43 -0700 (PDT) Received: from [192.168.0.14] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id y7-20020acae107000000b00383ef567cfdsm2229231oig.21.2023.03.15.07.46.42 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Mar 2023 07:46:42 -0700 (PDT) Message-ID: <7ca72e22-ad77-8513-4d7b-009741732e47@gmail.com> Date: Wed, 15 Mar 2023 11:46:41 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230315144525.4140-1-anton@khirnov.net> From: James Almer In-Reply-To: <20230315144525.4140-1-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/15/2023 11:45 AM, Anton Khirnov wrote: > This encoder leaks and overreads, as can be seen e.g. by running an > encode under valgrind with default encoder parameters. This was known > upstream since at least 2019 (e.g. bitbucket issue #482) but never fixed > until now. > > Since upstream does not seem to practice basic code hygiene, make sure > people do not use this encoder without knowing what they are getting > into. This is a really bad idea. It will break several scripts and command lines that were working perfectly fine and giving the desired results. > --- > libavcodec/libx265.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index 420d0953af..d4511251a5 100644 > --- a/libavcodec/libx265.c > +++ b/libavcodec/libx265.c > @@ -895,7 +895,8 @@ FFCodec ff_libx265_encoder = { > .p.id = AV_CODEC_ID_HEVC, > .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | > AV_CODEC_CAP_OTHER_THREADS | > - AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, > + AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE | > + AV_CODEC_CAP_EXPERIMENTAL, > .p.priv_class = &class, > .p.wrapper_name = "libx265", > .init = libx265_encode_init, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".