From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 2FB564591D
	for <ffmpegdev@gitmailbox.com>; Mon, 27 Mar 2023 20:08:12 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CCC5E68CB95;
	Mon, 27 Mar 2023 23:08:10 +0300 (EEST)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 551AB68CB8B
 for <ffmpeg-devel@ffmpeg.org>; Mon, 27 Mar 2023 23:08:04 +0300 (EEST)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 32RK82KS027188-32RK82KT027188;
 Mon, 27 Mar 2023 23:08:03 +0300
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id B7AD9A1542;
 Mon, 27 Mar 2023 23:08:02 +0300 (EEST)
Date: Mon, 27 Mar 2023 23:08:01 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: Christopher Degawa <ccom@randomderp.com>
In-Reply-To: <CABDPGry0HfMq90268E+mLypuNtV3_bRgCLCGQKQPBLOb0Bj-jQ@mail.gmail.com>
Message-ID: <7c97e95b-9c6c-99ed-1f6-95c23d1b092@martin.st>
References: <20230102230128.972907-1-ccom@randomderp.com>
 <e49e883-5f4-31c0-bfb8-a0710e445a4@martin.st>
 <CABDPGry0HfMq90268E+mLypuNtV3_bRgCLCGQKQPBLOb0Bj-jQ@mail.gmail.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH] get_cabac_inline_x86: Don't inline if
 32-bit Windows
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/7c97e95b-9c6c-99ed-1f6-95c23d1b092@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Mon, 27 Mar 2023, Christopher Degawa wrote:

> This may need to be re-done since according to
> https://trac.ffmpeg.org/ticket/8903,
> it seems to be affecting linux 32-bit as well with the latest compilers.

Oh, interesting - both me and Hendrik tried to reproduce it with 32 bit 
compilers for Linux today, but the combination that triggered it on 
Windows (-march=pentium4 -mtune=generic) didn't trigger it there.

With that in mind, I think it's rather clear that we should make this 
function noinline for all i386 combinations; yes it used to work back in 
the day, but compilers these days do way more things than they used to do, 
and inlineing this everywhere might not be feasible on i386.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".