From: "Martin Storsjö" <martin@martin.st>
To: Christopher Degawa <ccom@randomderp.com>
Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] get_cabac_inline_x86: Don't inline if 32-bit Windows
Date: Mon, 27 Mar 2023 23:08:01 +0300 (EEST)
Message-ID: <7c97e95b-9c6c-99ed-1f6-95c23d1b092@martin.st> (raw)
In-Reply-To: <CABDPGry0HfMq90268E+mLypuNtV3_bRgCLCGQKQPBLOb0Bj-jQ@mail.gmail.com>
On Mon, 27 Mar 2023, Christopher Degawa wrote:
> This may need to be re-done since according to
> https://trac.ffmpeg.org/ticket/8903,
> it seems to be affecting linux 32-bit as well with the latest compilers.
Oh, interesting - both me and Hendrik tried to reproduce it with 32 bit
compilers for Linux today, but the combination that triggered it on
Windows (-march=pentium4 -mtune=generic) didn't trigger it there.
With that in mind, I think it's rather clear that we should make this
function noinline for all i386 combinations; yes it used to work back in
the day, but compilers these days do way more things than they used to do,
and inlineing this everywhere might not be feasible on i386.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-03-27 20:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 23:01 Christopher Degawa
2023-01-02 23:35 ` Hendrik Leppkes
2023-01-03 18:32 ` Christopher Degawa
2023-01-03 18:45 ` Christopher Degawa
2023-01-03 10:15 ` Andreas Rheinhardt
2023-01-03 18:51 ` Christopher Degawa
2023-01-03 19:18 ` Christopher Degawa
2023-03-27 11:34 ` Martin Storsjö
2023-03-27 17:59 ` Christopher Degawa
2023-03-27 20:08 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c97e95b-9c6c-99ed-1f6-95c23d1b092@martin.st \
--to=martin@martin.st \
--cc=ccom@randomderp.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git