From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9665444477 for ; Mon, 12 Sep 2022 12:21:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A987968BB37; Mon, 12 Sep 2022 15:21:53 +0300 (EEST) Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 406B768BA9F for ; Mon, 12 Sep 2022 15:21:47 +0300 (EEST) Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-127f5411b9cso22842771fac.4 for ; Mon, 12 Sep 2022 05:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=8fQXMO4T4WXl7iaeBm9awiRtHNyogykWxQamHnT/H/M=; b=Dz2epzP5BVWYecs3C4Svet7/B1Rii1pa/yEFH2yWmE5CGDuVzMHeuIPoRGBPUB67ZH JVDN16Zu/t44sUgf+BpXMs5MN2ulVWumGRDP8ycVakhzzYdKzRFUxIqoE/TB1GhDdGZR TBbnLQa/vXb6pC+/Z4wN3kcAh/BwGKAN7guU+ENd6iGRKKg9OYTq4giKWiuzH0FJ4wSI +DElTIq2ijAhJrXFpL/PtZ70WzW2MP94hbHzUBAF4IYlAzaq9y6npHDBPnaLQc0aPElT kVq9Q3oHggn/x/WXvP+VjzCPgbwqclXE2V6S98nxcMQsWyMTUO9VO7660Fwu/BHfHISB +7aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=8fQXMO4T4WXl7iaeBm9awiRtHNyogykWxQamHnT/H/M=; b=tMu3UoxXO8iX3zTUYuUQQZmSYO+kmmzaoa7qhaYILHaphJmaygaq18Sv7pC1S9gJT9 /zfhoicTjESbOh4SwUC0/GaX0DzX0ajVYGWTgcN4QzsigBfgVrpKgCmIf6mwpWMzjaoN 0UfKSrFAqNWu9pCm/9Z020QZOQjinnxnDDo946AXOuZib6GVm335JSI0/2uMHYBL8Adv xsB+NZdW175LvRRM+WmBDNadkP9l07NwEuMUS3y8qGpDi7xcWUzsWIg8QExJ/Tkr+ld9 lUYR24DB0vt44aeFi90NBlvA5frmEKroxcpNn3vbyQPeudn1xaIVHQ+aqmHdrmVEr+fu lnhg== X-Gm-Message-State: ACgBeo2vvbOzBABhe7wrlpNoMNJmpcRULNlE/WMzHcvQOLIuGvhxBSML cTyyFGvnm1i2Dx02/CDwa1m3QGb23AQ= X-Google-Smtp-Source: AA6agR5h06i+7sDVHcVvEZ+ROxatLJfOKwHRxwbM3FIv3cDychvyl/HPg++PxeoXqsGwp5R6ABaESg== X-Received: by 2002:a05:6808:1983:b0:34f:bfb0:8b8b with SMTP id bj3-20020a056808198300b0034fbfb08b8bmr910236oib.194.1662985305281; Mon, 12 Sep 2022 05:21:45 -0700 (PDT) Received: from [192.168.0.13] ([191.97.187.183]) by smtp.gmail.com with ESMTPSA id h20-20020a9d6414000000b0061d31170573sm4525239otl.20.2022.09.12.05.21.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 05:21:44 -0700 (PDT) Message-ID: <7c34d21b-9a81-c96a-b00a-261b3b5d9626@gmail.com> Date: Mon, 12 Sep 2022 09:21:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/bonk: Actually clip when using av_clip() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 9/12/2022 9:20 AM, Andreas Rheinhardt wrote: > Also fixes a "statement with no effect [-Wunused-value]" > warning from GCC. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/bonk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c > index f3d797d588..409694f710 100644 > --- a/libavcodec/bonk.c > +++ b/libavcodec/bonk.c > @@ -280,7 +280,7 @@ static int predictor_calc_error(int *k, int *state, int order, int error) > } > > // don't drift too far, to avoid overflows > - av_clip(x, -(SAMPLE_FACTOR << 16), SAMPLE_FACTOR << 16); > + x = av_clip(x, -(SAMPLE_FACTOR << 16), SAMPLE_FACTOR << 16); > > state[0] = x; LGTM, but this decoder needs a test to ensure it's actually doing the right thing. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".