* [FFmpeg-devel] [PATCH] avcodec/bonk: Actually clip when using av_clip()
@ 2022-09-12 12:20 Andreas Rheinhardt
2022-09-12 12:21 ` James Almer
2022-09-12 19:20 ` Paul B Mahol
0 siblings, 2 replies; 3+ messages in thread
From: Andreas Rheinhardt @ 2022-09-12 12:20 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Andreas Rheinhardt
Also fixes a "statement with no effect [-Wunused-value]"
warning from GCC.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
libavcodec/bonk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c
index f3d797d588..409694f710 100644
--- a/libavcodec/bonk.c
+++ b/libavcodec/bonk.c
@@ -280,7 +280,7 @@ static int predictor_calc_error(int *k, int *state, int order, int error)
}
// don't drift too far, to avoid overflows
- av_clip(x, -(SAMPLE_FACTOR << 16), SAMPLE_FACTOR << 16);
+ x = av_clip(x, -(SAMPLE_FACTOR << 16), SAMPLE_FACTOR << 16);
state[0] = x;
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/bonk: Actually clip when using av_clip()
2022-09-12 12:20 [FFmpeg-devel] [PATCH] avcodec/bonk: Actually clip when using av_clip() Andreas Rheinhardt
@ 2022-09-12 12:21 ` James Almer
2022-09-12 19:20 ` Paul B Mahol
1 sibling, 0 replies; 3+ messages in thread
From: James Almer @ 2022-09-12 12:21 UTC (permalink / raw)
To: ffmpeg-devel
On 9/12/2022 9:20 AM, Andreas Rheinhardt wrote:
> Also fixes a "statement with no effect [-Wunused-value]"
> warning from GCC.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/bonk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c
> index f3d797d588..409694f710 100644
> --- a/libavcodec/bonk.c
> +++ b/libavcodec/bonk.c
> @@ -280,7 +280,7 @@ static int predictor_calc_error(int *k, int *state, int order, int error)
> }
>
> // don't drift too far, to avoid overflows
> - av_clip(x, -(SAMPLE_FACTOR << 16), SAMPLE_FACTOR << 16);
> + x = av_clip(x, -(SAMPLE_FACTOR << 16), SAMPLE_FACTOR << 16);
>
> state[0] = x;
LGTM, but this decoder needs a test to ensure it's actually doing the
right thing.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] avcodec/bonk: Actually clip when using av_clip()
2022-09-12 12:20 [FFmpeg-devel] [PATCH] avcodec/bonk: Actually clip when using av_clip() Andreas Rheinhardt
2022-09-12 12:21 ` James Almer
@ 2022-09-12 19:20 ` Paul B Mahol
1 sibling, 0 replies; 3+ messages in thread
From: Paul B Mahol @ 2022-09-12 19:20 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Andreas Rheinhardt
On 9/12/22, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
> Also fixes a "statement with no effect [-Wunused-value]"
> warning from GCC.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/bonk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c
> index f3d797d588..409694f710 100644
> --- a/libavcodec/bonk.c
> +++ b/libavcodec/bonk.c
> @@ -280,7 +280,7 @@ static int predictor_calc_error(int *k, int *state, int
> order, int error)
> }
>
> // don't drift too far, to avoid overflows
> - av_clip(x, -(SAMPLE_FACTOR << 16), SAMPLE_FACTOR << 16);
> + x = av_clip(x, -(SAMPLE_FACTOR << 16), SAMPLE_FACTOR << 16);
>
> state[0] = x;
>
LGTM
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-12 19:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-12 12:20 [FFmpeg-devel] [PATCH] avcodec/bonk: Actually clip when using av_clip() Andreas Rheinhardt
2022-09-12 12:21 ` James Almer
2022-09-12 19:20 ` Paul B Mahol
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git