From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 27EDC4DE3D for ; Tue, 6 Jan 2026 08:48:19 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'3vKQEM1Hjo+ZLanjDUYgEYbz/jDgKS9zt3yh/Q0Vnu8=', expected b'cpNUL3HO+FPHa2vOzO8twLHSJFohzP8vipMlPqvqYaU=')) header.d=frankplowman.com header.i=post@frankplowman.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1767689283; h=message-id : date : mime-version : to : references : in-reply-to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : from; bh=jiXyta8kJjOOo8XwUkjRl8bSfec+YXMNyJphLXzqPgI=; b=KiCYtQPPb7TMoZPc3K7zv3N3Eqc0TrPZs3WEzKCg+s2M5m312AXuoZLgFPZ9x7d2yDzx9 PLvZWJ3vMxeaVFFmMv9+2ejixj+Orcx5RiGKCsfaOL7Ec+oXNGZLbZfL4D4nXQZ72IBXAqU EbeDR2M82xEWq9T/FnMQCTZ6aeLf7kPBssmIUOxiRocHpdWxHO7uy8ETjpcuyqnR+1TbQhv TYSLQjIK2HCAwPRZA3tllp0I5gj9leAfraRsCwDjz9rQQupGBV6LC2I9WA+lgOVN9waz4gu nLzIbaG4GMJLK3CZZJvIYgTBNzWaJ5Q2RB14ENWkUULEHzAttCEuHvzw1Vjw== Received: from [172.20.0.4] (unknown [172.20.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id B52CD690D7E; Tue, 6 Jan 2026 10:48:03 +0200 (EET) ARC-Seal: i=2; cv=pass; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1767689266; b=NmebHYFa4Kz6gfpi+uTN2eHUT1u7iBoUGmcVh4aOwvKMdowflPEbYIqptXUiZiJdnRo83 0WRuJqO5ccWQFMZ+Z+Ue4JmYRPrkw6Sn7GU/T/Pht0QGFU9NvKp5ESmEQhMd9EvAYVcGfOE uhv+Gw5JVCLN3GXcPEUlihjcKFuKfCy5HAHoTCHTlLc3l3OkCWc+FIVGE78tGzwRsuXdm7N d6/2zPI7F8x/3Jym0lPE3DLqs5il+fCf+YfvwtIbGQIfTDF4mddRnCqP6OPfLFP8VnUWdeU bYsLV3VECqnzN6bxRTkgV8G2LtwelBbWl1eO8e4DwoV61+RlyssUYsYVz2eA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1767689266; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=3vKQEM1Hjo+ZLanjDUYgEYbz/jDgKS9zt3yh/Q0Vnu8=; b=HyneNz2FsG5Ubi2eHJEQfqxo7wDpr2z8caCWUtZNHJ9oyD0EuNPRAqy/D4yYr1nMNvV4o hVTZ2BXBdg+QvlTLUoy9VJyP3ZCFWdYrxRXde9WZTV5RVByS3pVnST6YJfI9gBVN1ds3vsX rQs6BYVeN3KV26Ov+kbB6W66uXjU06Las8JAX+cSLl5LQxirxX4tqodrrmG58+wmX1Rrk5H yc4BN+UwFVw+qhMvQltJlNiib52JHqS9/o75X7hKYfL60458ym/qOdGNfAHmD87AM0y7ZEp XvIXrVGz6lCmI49scZaai/0XiPXC3YJEgMEg0CTynzYGjuTnF/kISP0MquuA== ARC-Authentication-Results: i=2; ffmpeg.org; dkim=pass header.d=frankplowman.com header.i=post@frankplowman.com; arc=pass; dmarc=none Authentication-Results: ffmpeg.org; dkim=pass header.d=frankplowman.com header.i=post@frankplowman.com; arc=pass; dmarc=none Received: from sender-op-o19.zoho.eu (sender-op-o19.zoho.eu [136.143.169.19]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 57578690D10 for ; Tue, 6 Jan 2026 10:47:32 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; t=1767689250; cv=none; d=zohomail.eu; s=zohoarc; b=lLUZu7Un3o+aW0RqsYiPnMDazrrQ0Rw7aR+Mghskdu1MJ7WRa0UiOphU3q+1L9owq7aKqxaZkXBqh7WPzzK4SbhAzBinTFfXXvNbFfGA9F7usK6Js2/eZCl09+69gh+zbVDYrBnPY8g5JU7SpZjfw80qoTaHxhkxiIeqFXrwppQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1767689250; h=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=cpNUL3HO+FPHa2vOzO8twLHSJFohzP8vipMlPqvqYaU=; b=TSCNTPBqflJHao4V6F5w/VBPUpKPgc3aMvTEwvaNihho8BJLhYoQzNO1zEIVkwZj8Dj35zgHOc6QdZQmV/IUD4vtiW73yj+HxqgJbmrgNQ55HjiWOP9PYXjAjFdN3ueJ+4uWhJAIC5bjdDRFNsML3Eqld9UGRqMIziJiwHApUcU= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=frankplowman.com; spf=pass smtp.mailfrom=post@frankplowman.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1767689250; s=zmail; d=frankplowman.com; i=post@frankplowman.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Message-Id:Reply-To:Cc; bh=cpNUL3HO+FPHa2vOzO8twLHSJFohzP8vipMlPqvqYaU=; b=XmzqisjdgDhNm3zWk9+CxVt+mBK/aPj+Zx5E3xJCf7++reZZ4SCb4X5fDhbzjlYD pRcZlh4FUpZrzlP6kwGIaPc0nHqRYg4zDlDOMWDizI0rfInj1x273lOnhfW8NB59HSV EjytVvZx7sJEvUn9fLuHg5rZVkjK9h82q/NdGQ4A= Received: by mx.zoho.eu with SMTPS id 1767689249697433.63225866150333; Tue, 6 Jan 2026 09:47:29 +0100 (CET) Message-ID: <7b958c6f-b4f6-4079-94b0-e517cb5b07da@frankplowman.com> Date: Tue, 6 Jan 2026 08:47:29 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20260105001630.1738-1-monsterbat02@gmail.com> <20260105001630.1738-3-monsterbat02@gmail.com> In-Reply-To: X-Zoho-Virus-Status: 1 X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-1.4.3/267.658.84 X-ZohoMailClient: External Message-ID-Hash: 62NWS5OMAMYBAUWTT3GLG4HFMIIMXKQD X-Message-ID-Hash: 62NWS5OMAMYBAUWTT3GLG4HFMIIMXKQD X-MailFrom: SRS0=4rLH=7L=frankplowman.com=post@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avcodec/vvc: validate reference picture list indices List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Frank Plowman via ffmpeg-devel Cc: Frank Plowman Content-Type: multipart/mixed; boundary="===============4636187779295704347==" Archived-At: List-Archive: List-Post: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============4636187779295704347== Content-Language: en-GB Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------TS8aQs9d9HuyxcV2tFfDbDJC" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------TS8aQs9d9HuyxcV2tFfDbDJC Content-Type: multipart/mixed; boundary="------------3cF00Hm0Sv9zmf3Yx59lwNzd"; protected-headers="v1" From: Frank Plowman To: ffmpeg-devel@ffmpeg.org Message-ID: <7b958c6f-b4f6-4079-94b0-e517cb5b07da@frankplowman.com> Subject: Re: [FFmpeg-devel] Re: [PATCH] avcodec/vvc: validate reference picture list indices References: <20260105001630.1738-1-monsterbat02@gmail.com> <20260105001630.1738-3-monsterbat02@gmail.com> In-Reply-To: --------------3cF00Hm0Sv9zmf3Yx59lwNzd Content-Type: multipart/mixed; boundary="------------F4axVND540m8guLrSFSBFoRA" --------------F4axVND540m8guLrSFSBFoRA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/01/2026 07:58, Christophe Gisquet via ffmpeg-devel wrote: > Hi, >=20 > sorry in advance for any bad formatting in my reply from a phone. >=20 > Le mar. 6 janv. 2026, 03:13, 0xBat via ffmpeg-devel > a =C3=A9crit >=20 >> --- >> libavcodec/vvc/ctu.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c >> index 18cbe0fe0f..8e4f003886 100644 >> --- a/libavcodec/vvc/ctu.c >> +++ b/libavcodec/vvc/ctu.c >> @@ -1287,6 +1287,8 @@ static void derive_mmvd(const VVCLocalContext *l= c, >> MvField *mvf, const Mv *mmvd_ >> if (mvf->pred_flag =3D=3D PF_BI) { >> const RefPicList *rpl =3D sc->rpl; >> const int poc =3D lc->fc->ps.ph.poc; >> + if (mvf->ref_idx[L0] >=3D rpl[L0].nb_refs || mvf->ref_idx[L1]= >=3D >> rpl[L1].nb_refs) >> + return; >> const int diff[] =3D { >> poc - rpl[L0].refs[mvf->ref_idx[L0]].poc, >> >=20 > Not a maintainer or contributor to the VVC decoder, but sounds fishy. T= hat > a ref_idx is invalid, means that wherever it came from didn't validate > against the RPL. I don't know where mvf comes from, but if that's from = the > current frame, it is extremely weird. >=20 > And by that I mean, the issue sounds like it should be caught earlier t= o > avoid it from propagating to other places. >=20 > Regards, > Christophe >=20 Hi, Yes I agree with Christophe. MMVD takes its "base MVs" (what is called mvf here) from the regular merge list, which is shared with various other merge modes. Consequently, if there are invalid MVs in MMVD then I suspect the issue may be more fundamental and there may be issues with other merge modes. I'm guessing you have fuzzed bitstreams which led you to these issues, would it be possible to share them? Thanks a lot for your work, Frank --------------F4axVND540m8guLrSFSBFoRA Content-Type: application/pgp-keys; name="OpenPGP_0x03A84C6A098F2C6B.asc" Content-Disposition: attachment; filename="OpenPGP_0x03A84C6A098F2C6B.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEaDsehBYJKwYBBAHaRw8BAQdAtPY6tq5662mjGsrl9wixeTHtvaO/qPBio/aX SmF+pjnNJUZyYW5rIFBsb3dtYW4gPHBvc3RAZnJhbmtwbG93bWFuLmNvbT7ClgQT FgoAPgIbAQIXgAUJAeEzrBYhBDTiSNa330dpcMczBAOoTGoJjyxrBQJoOyIVBQsJ CAcCBhUKCQgLAgQWAgMBAh4BAAoJEAOoTGoJjyxrMhUBAKT3f80IXiufxCSU1rve Xp5BKwvNbY6szRdR/m21m9GAAQCGhR6t64PlMspXLtwWq9o1vjKzjWH+Bgw+UybQ CG2zDM4zBGg7HsQWCSsGAQQB2kcPAQEHQPmGNV50IFIJBy9F60ZIxe5my91pL/Sl LUWq9Z5DHBsYwsA1BBgWCgAmFiEENOJI1rffR2lwxzMEA6hMagmPLGsFAmg7HsQC GwIFCQHhM4AAgQkQA6hMagmPLGt2IAQZFgoAHRYhBEh0l9eKWUIIcnmv1LvizNAX Sd6KBQJoOx7EAAoJELvizNAXSd6KtkEBAP0jS/nBlqaVJq0iNeNDk+PnKkNBmC9p i4SuwFD71nQfAP9eWO32RXbRoIwvbrdsalWxWYmqSOdIdQE51qGMsJUuAjtIAQDA 6o6O2o2pHnWWdSqKs7Zkp4BImBD+kztmzA0Du3vJeQD/TR+qrBCXaG1FCDKn9c+Q XQNtHTxI9c6dCywjkQljOAzOOARoOyM7EgorBgEEAZdVAQUBAQdAKS1xy5312Agk deedJEXplopXco5pyANBz/edWeb7zEkDAQgHwn4EGBYKACYWIQQ04kjWt99HaXDH MwQDqExqCY8sawUCaDsjOwIbDAUJAeEzgAAKCRADqExqCY8saxvgAP9zskNI1Sti DXM4RFMoJb1aQ5TPToQZSSkGhw7JyMbLpgD/VCG7BOFjKgJGtXYEb5zpmRzNzdEB QkLsgE/vAD9GXQs=3D =3DReZ+ -----END PGP PUBLIC KEY BLOCK----- --------------F4axVND540m8guLrSFSBFoRA-- --------------3cF00Hm0Sv9zmf3Yx59lwNzd-- --------------TS8aQs9d9HuyxcV2tFfDbDJC Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQRIdJfXillCCHJ5r9S74szQF0neigUCaVzMIQUDAAAAAAAKCRC74szQF0neis7T AQD9w9qNV4GciEjFb1zZIq7wkpbm6/GK0+JMFb759mbK8QEAiKHuoeQIuN0Re5y5ua7aURswdk26 HAjRlLv4NhBPhA4= =Cywm -----END PGP SIGNATURE----- --------------TS8aQs9d9HuyxcV2tFfDbDJC-- --===============4636187779295704347== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org --===============4636187779295704347==--