From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6F6EF49ED3 for ; Wed, 13 Mar 2024 08:26:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3971A68CFDA; Wed, 13 Mar 2024 10:26:46 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1DB8468CD39 for ; Wed, 13 Mar 2024 10:26:40 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id D1521E9AAC for ; Wed, 13 Mar 2024 09:26:39 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aBMqfwd2jLyH for ; Wed, 13 Mar 2024 09:26:37 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 6C76DE9A2A for ; Wed, 13 Mar 2024 09:26:37 +0100 (CET) Date: Wed, 13 Mar 2024 09:26:37 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20240312223625.1296218-1-chen.stonechen@gmail.com> Message-ID: <7b6cbc7f-259b-84b1-dd4d-6cba892ce49e@passwd.hu> References: <20240312223625.1296218-1-chen.stonechen@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] Change rdiv (vf_convolution) documentation to reflect actual behavior X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 12 Mar 2024, Stone Chen wrote: > The documentation correctly states that the rdiv is a multiplier but incorrectly states the default behavior is to multiply by the sum of all matrix elements - it multiplies by 1/sum. > > This changes the documentation to match the code. Please mention in the commit message the ticket number this patch fixes. Thanks, Marton > --- > doc/filters.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/filters.texi b/doc/filters.texi > index e0436a5755..913365671d 100644 > --- a/doc/filters.texi > +++ b/doc/filters.texi > @@ -10497,7 +10497,7 @@ and from 1 to 49 odd number of signed integers in @var{row} mode. > @item 2rdiv > @item 3rdiv > Set multiplier for calculated value for each plane. > -If unset or 0, it will be sum of all matrix elements. > +If unset or 0, it will be 1/sum of all matrix elements. > > @item 0bias > @item 1bias > -- > 2.44.0 > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".