From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 203494310A for ; Fri, 20 May 2022 20:05:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AD12C68B43B; Fri, 20 May 2022 23:05:22 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3809B68A214 for ; Fri, 20 May 2022 23:05:15 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 24KK5Eco029566-24KK5Ecp029566 for ; Fri, 20 May 2022 23:05:14 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id C438CA150B for ; Fri, 20 May 2022 23:05:14 +0300 (EEST) Date: Fri, 20 May 2022 23:05:13 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <7b577e45-b12b-c5c-4ec7-10ac6963ef1@martin.st> References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v3] avcodec/mfenc: Dynamically load MFPlat.DLL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 20 May 2022, Trystan Mata wrote: > From 2bdef1bdb93efa40b7d3fe21270f9f23465bee90 Mon Sep 17 00:00:00 2001 > From: Trystan Mata > Date: Fri, 20 May 2022 14:26:49 +0200 > Subject: [PATCH] avcodec/mfenc: Dynamically load MFPlat.DLL > > Allow builds of FFmpeg with MediaFoundation to work under N editions of > Windows which are without MediaFoundation by default. > > Signed-off-by: Trystan Mata > --- > configure | 4 +- > libavcodec/mf_utils.c | 26 +++++++------ > libavcodec/mf_utils.h | 16 ++++++-- > libavcodec/mfenc.c | 91 ++++++++++++++++++++++++++++++++++++------- > 4 files changed, 107 insertions(+), 30 deletions(-) This patch on its own breaks builds for UWP targets (where LoadLibrary isn't available). Or more precisely, previously mfenc was enabled, now it no longer is available. For such targets, one can unconditionally assume that the functions are available and can link directly against them. See ff_MFTEnumEx in mf_utils.c how that's done so far. Doing the same instead of LoadLibrary probably shouldn't be an issue for you, but I think we'd need to drop the dependency on LoadLibrary in configure. (I think that's fine, we don't really lose anything by doing that.) Btw, when sending updates to an earlier posted patch, it'd be nice if you'd mention somewhere what changed compared to the previous revision of the patch. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".