From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Coia Prant <coiaprant@gmail.com>
Subject: Re: [FFmpeg-devel] [PATCH] fix(configure): fix detection on windows
Date: Sun, 25 May 2025 17:50:05 +0300 (EEST)
Message-ID: <7a95fb9-63c-7ec-52b1-e39dfaba7c0@martin.st> (raw)
In-Reply-To: <20250523093201.1534-1-coiaprant@gmail.com>
On Fri, 23 May 2025, Coia Prant wrote:
> On Windows Arm64
> `uname -m` returned `x86_64` instead of `aarch64`
> Link: https://github.com/msys2/msys2-runtime/issues/171
>
> On x86 32-bit toolchain msys2 environment
> `uname -m` returned `x86_64` instead of `i686` or `x86`
>
> So check MSYSTEM_CARCH on windows (for arm64 and i686)
>
> This problem also in VideoLAN/x264
> Link: https://code.videolan.org/videolan/x264/-/merge_requests/177
>
> Signed-off-by: Coia Prant <coiaprant@gmail.com>
> ---
> configure | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configure b/configure
> index 2e69b3c..ed30b6b 100755
> --- a/configure
> +++ b/configure
> @@ -4157,6 +4157,8 @@ if test "$target_os_default" = aix; then
> arch_default=$(uname -p)
> strip_default="strip -X32_64"
> nm_default="nm -g -X32_64"
> +elif test "$MSYSTEM_CARCH" != ""; then
> + arch_default="$MSYSTEM_CARCH"
> else
> arch_default=$(uname -m)
> fi
> --
> 2.49.0.windows.1
This approach seems reasonable to me.
(On i686 vs x86_64, it hasn't been an issue, since they all map into "x86"
within ffmpeg, and configure then checks the bitness, but for arm64 it's
indeed an issue.)
I can push the patch soon if nobody minds it.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-25 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 9:32 Coia Prant
2025-05-25 14:50 ` Martin Storsjö [this message]
2025-05-25 14:52 ` Coia Prant
2025-05-26 11:48 ` Martin Storsjö
2025-05-26 13:39 ` Coia Prant
2025-05-27 21:00 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a95fb9-63c-7ec-52b1-e39dfaba7c0@martin.st \
--to=martin@martin.st \
--cc=coiaprant@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git