From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6375A48446 for ; Fri, 2 Feb 2024 12:31:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3BCFB68CBF7; Fri, 2 Feb 2024 14:31:42 +0200 (EET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E566068CBF7 for ; Fri, 2 Feb 2024 14:31:35 +0200 (EET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d7393de183so15323145ad.3 for ; Fri, 02 Feb 2024 04:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706877093; x=1707481893; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=wkcInIiKjSZ2J+uT5h3JLTRpbbyuR9bMT2NSv7NPKYQ=; b=iHRA8j2tOkbwyUE0BSBF87rBzH84/2Wz23uF6n8wPv68FqOlo2JjkV0WMMCV1dglCN CaOT2kRRv3xLsfqycgmhlqGRuuy3z5G2z+N7H5rmfJxfERgM8BC7O6f7M2HBCWOuGQ6U H9fgKGYgccK7eKh65Czhf0FQaUPNBcFZzdgGOpXdc/C9Dr4Asdil53gjIFenulPtwTF5 Fbd9VLq42DH8EyaNGGMhGMLN+Dam/3ylaCn5ryB+BHgBPlOcYBKz655roPRy7q51iF4J wfnhF0ceYV/SquMrmtEozhEp7Vb1RW1ADQIfqloiGNknm4GCxxjQhCcSrIr6Z5JBa/iw LEQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706877093; x=1707481893; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wkcInIiKjSZ2J+uT5h3JLTRpbbyuR9bMT2NSv7NPKYQ=; b=qbdgF8v3gWR9ZicMYzYQoi4/ZQsFgDBFR3XhNlGuWxhQVvEgnDOCFJB5Im7aQRK5oM kknM+aIYO6DodR4aMYXSS+Ci/HjWv/WhSgXrNDkyTkwLyNkYyAhX4aGKM7WhQszVNudu zSsBgbmI7X1qyM6VCwOb1f4+RXI4k3tgV+x0RSraLEjo2l8OxDgoHmyP/NeMktFt2DSh nUfsqFsY3kW3qz9PxJ5C824YL4uWQMkxKEbLWS1mr5SGrCWtw/91kspFDbLkKYhoJx9t oleOvP/pzVN5Hkdh6Waf72YyNbeMLxNxBNEjI1mibaEk9CHI8c8HtfpwEuerdFT7f+QN NjhA== X-Gm-Message-State: AOJu0YzEfWzb7n59Eh+hyEfwTTETg86wV/STtd2bpA7bCm9P1so9jMeB REqG9/j4WJY152yLo9NlTL4o0z60gGj04fXjcmWn+YFw27nBUFw0y+6bmZyq X-Google-Smtp-Source: AGHT+IEm8kcYjOAe2Y5gZtZ7Uia3sSrEyLgCIAepowg3v03GuFSEZkEMcdizxKsL2EBTAG8H8GJtdA== X-Received: by 2002:a17:903:2342:b0:1d9:791b:7dda with SMTP id c2-20020a170903234200b001d9791b7ddamr764389plh.36.1706877092059; Fri, 02 Feb 2024 04:31:32 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id d5-20020a63d705000000b005cfc1015befsm1480532pgg.89.2024.02.02.04.31.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Feb 2024 04:31:31 -0800 (PST) Message-ID: <7a3bf46b-9f78-4eb1-9f1f-97f1568f0343@gmail.com> Date: Fri, 2 Feb 2024 09:32:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/iamf_writer: Avoid using dynamic buffer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/2/2024 8:30 AM, Andreas Rheinhardt wrote: > Andreas Rheinhardt: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/iamf_writer.c | 28 ++++++---------------------- >> 1 file changed, 6 insertions(+), 22 deletions(-) >> >> diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c >> index 99602ae204..f665f45b7a 100644 >> --- a/libavformat/iamf_writer.c >> +++ b/libavformat/iamf_writer.c >> @@ -807,31 +807,15 @@ static int iamf_write_mixing_presentation(const IAMFContext *iamf, >> >> int ff_iamf_write_descriptors(const IAMFContext *iamf, AVIOContext *pb, void *log_ctx) >> { >> - uint8_t header[MAX_IAMF_OBU_HEADER_SIZE]; >> - PutBitContext pbc; >> - AVIOContext *dyn_bc; >> - uint8_t *dyn_buf = NULL; >> - int dyn_size; >> - >> - int ret = avio_open_dyn_buf(&dyn_bc); >> - if (ret < 0) >> - return ret; >> + int ret; >> >> // Sequence Header >> - init_put_bits(&pbc, header, sizeof(header)); >> - put_bits(&pbc, 5, IAMF_OBU_IA_SEQUENCE_HEADER); >> - put_bits(&pbc, 3, 0); >> - flush_put_bits(&pbc); >> + avio_w8(pb, IAMF_OBU_IA_SEQUENCE_HEADER << 3); >> >> - avio_write(dyn_bc, header, put_bytes_count(&pbc, 1)); >> - ffio_write_leb(dyn_bc, 6); >> - avio_wb32(dyn_bc, MKBETAG('i','a','m','f')); >> - avio_w8(dyn_bc, iamf->nb_audio_elements > 1); // primary_profile >> - avio_w8(dyn_bc, iamf->nb_audio_elements > 1); // additional_profile >> - >> - dyn_size = avio_close_dyn_buf(dyn_bc, &dyn_buf); >> - avio_write(pb, dyn_buf, dyn_size); >> - av_free(dyn_buf); >> + ffio_write_leb(pb, 6); >> + avio_wb32(pb, MKBETAG('i','a','m','f')); >> + avio_w8(pb, iamf->nb_audio_elements > 1); // primary_profile >> + avio_w8(pb, iamf->nb_audio_elements > 1); // additional_profile >> >> for (int i = 0; i < iamf->nb_codec_configs; i++) { >> ret = iamf_write_codec_config(iamf, iamf->codec_configs[i], pb); > > Will apply this patchset tomorrow unless there are objections. > > - Andreas Set LGTM, thanks. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".