Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] configure: correct lensfun header function check
@ 2023-12-31  7:33 Gyan Doshi
  2024-01-01  4:03 ` Gyan Doshi
  0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2023-12-31  7:33 UTC (permalink / raw)
  To: ffmpeg-devel

The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017
in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d
but the configure check wasn't changed.

lensfun removed lf_db_new declaration in lf 35c0017593 so configure
fails to find lensfun.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index cd66e42850..9262c1b650 100755
--- a/configure
+++ b/configure
@@ -6776,7 +6776,7 @@ enabled libjxl            && require_pkg_config libjxl "libjxl >= 0.7.0" jxl/dec
                              require_pkg_config libjxl_threads "libjxl_threads >= 0.7.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner
 enabled libklvanc         && require libklvanc libklvanc/vanc.h klvanc_context_create -lklvanc
 enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 2.0.0" kvazaar.h kvz_api_get
-enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_new
+enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_create
 
 if enabled libmfx && enabled libvpl; then
    die "ERROR: can not use libmfx and libvpl together"
-- 
2.39.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH] configure: correct lensfun header function check
  2023-12-31  7:33 [FFmpeg-devel] [PATCH] configure: correct lensfun header function check Gyan Doshi
@ 2024-01-01  4:03 ` Gyan Doshi
  2024-01-01 10:02   ` Gyan Doshi
  0 siblings, 1 reply; 3+ messages in thread
From: Gyan Doshi @ 2024-01-01  4:03 UTC (permalink / raw)
  To: ffmpeg-devel



On 2023-12-31 01:03 pm, Gyan Doshi wrote:
> The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017
> in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d
> but the configure check wasn't changed.
>
> lensfun removed lf_db_new declaration in lf 35c0017593 so configure
> fails to find lensfun.
> ---
This unbreaks use of the lib so plan to push in a few hours.

Regards,
Gyan


>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index cd66e42850..9262c1b650 100755
> --- a/configure
> +++ b/configure
> @@ -6776,7 +6776,7 @@ enabled libjxl            && require_pkg_config libjxl "libjxl >= 0.7.0" jxl/dec
>                                require_pkg_config libjxl_threads "libjxl_threads >= 0.7.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner
>   enabled libklvanc         && require libklvanc libklvanc/vanc.h klvanc_context_create -lklvanc
>   enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 2.0.0" kvazaar.h kvz_api_get
> -enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_new
> +enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_create
>   
>   if enabled libmfx && enabled libvpl; then
>      die "ERROR: can not use libmfx and libvpl together"

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [FFmpeg-devel] [PATCH] configure: correct lensfun header function check
  2024-01-01  4:03 ` Gyan Doshi
@ 2024-01-01 10:02   ` Gyan Doshi
  0 siblings, 0 replies; 3+ messages in thread
From: Gyan Doshi @ 2024-01-01 10:02 UTC (permalink / raw)
  To: ffmpeg-devel



On 2024-01-01 09:33 am, Gyan Doshi wrote:
>
>
> On 2023-12-31 01:03 pm, Gyan Doshi wrote:
>> The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017
>> in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d
>> but the configure check wasn't changed.
>>
>> lensfun removed lf_db_new declaration in lf 35c0017593 so configure
>> fails to find lensfun.
>> ---
> This unbreaks use of the lib so plan to push in a few hours.

Pushed as e1c1dc8347f13104bc21e4100fcf4d4dddf5e5d8

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-01-01 10:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-31  7:33 [FFmpeg-devel] [PATCH] configure: correct lensfun header function check Gyan Doshi
2024-01-01  4:03 ` Gyan Doshi
2024-01-01 10:02   ` Gyan Doshi

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git