From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id E81A549517 for ; Tue, 28 Jan 2025 17:52:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 17B5768B9CA; Tue, 28 Jan 2025 19:52:36 +0200 (EET) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B6FE668B944 for ; Tue, 28 Jan 2025 19:52:29 +0200 (EET) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-385e0e224cbso3438544f8f.2 for ; Tue, 28 Jan 2025 09:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738086749; x=1738691549; darn=ffmpeg.org; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=Qh0hQbq3IBUy8oO9aof961dowv9SK2HDfmTdqrbj4Ig=; b=NHkLEUXxFs09Um8or2SS1K+z6Ne9XQxYDAcXajUYPIcZN+OkkV3QqUPTpnnPswp6iP PHFAQWOvnxP7IVsglqJiCMCf6zV/qlPO5RV5YQF5KAvTVqhooiVC+qGQ8fjBiPJEl5K4 NF7/16GN9FnrQejAEAS5cfBKipjVRRGXZDpq6KReU6U06IPohiBLi/wbfXjjPus/RT31 tvggUOumIo1+jv8r0HJBrfgKh+UcHfzv0tBfAPAETyuu5Jm4P7D1+OdNfNcbVOL6Jl5P zJVjC1xUVJNKVA8YM0rUgmYYKhyztjEVDeHFKuvVAq4P/MT8qftrO/3L7rBPJjeMO+Qv B3nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738086749; x=1738691549; h=mime-version:references:in-reply-to:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Qh0hQbq3IBUy8oO9aof961dowv9SK2HDfmTdqrbj4Ig=; b=Dho+jIyuULjDG95aq7pw5t/mf5zyQy0vyBCwgenJnHXlslZIYGWkD1UDNQrdxeYyQk GI9ZB/Go45midLLfwHW8M7ihcDHJPZEG+FiP4fV//4vB7v98fNnQwQdftsF6P+X3BBA3 9ESQxJyOmc0AsY4fG6uuMcQMo/hMNA0SiiJk7JkEaPQbl3yyS4T8sfbCOyX6GOKuyagI MySMuf9a0qsMWQcKGZxy/TaN+oj0Gzoh7pduS6Q8yMJSEQQKhWeGmFQfzwb3MDX0rRQe 7i4Y7ITxyIS5HYr7KV2HRBw+bCPpjgUzrrLf+QBJgF6diRm/MvU95iA7LLWOT2ZN2bPy rQxw== X-Gm-Message-State: AOJu0YxhfodEUikT8L1y4xzGf5OD/6PARWTA0bmdKbBgkHENa09dEPBW llTKJVsyDar8pEqBdfJ8QQSA2MNjqgYdhmiYVm0K7EdHYqDwJicDUGNGtw== X-Gm-Gg: ASbGncuOsLwxyihgZ5NHPZGgcM9XNMHdLTcgfc0Oj/tneSx5gSIxzbrimmka0EBwJ8I zndfZYRXspvsP3H6xvNItqeecZHe9ry0ucdjzFBMdeeGFHNlwMV1ZcTMBHIHF+Td/MPXh7UPqrU kjHh0iKh2+rTNJyZAvrF0vJtNman2QxKhuQFmVv7oDnNSBSoJ0opIiW0yLMIsh99IGObAkrWUnJ pdD4ZZoYHtCSzaDy8QMEdkCJ3SWGSRAhORJ95jBhCP44qPoWq+TC82scgXkNxiu7slgNMlONrcv p+0srMnwAh4P06EIjNkxds6Tn0YBCaVou8CWkoEZX6EsoH+Tm85E+IYFrg4WfHg+ELVwRgCGHLG uk6RS7KVY4rmpfVR9PwNsE1ToKHE= X-Google-Smtp-Source: AGHT+IH9E5Pp/axQlV4v0nXkR4RpITQwgZ7bzWIQiw6zb3rMSeaSdNsYJrOuOC0AoDYtzZi4mb4eoA== X-Received: by 2002:adf:fc08:0:b0:38a:a037:a517 with SMTP id ffacd0b85a97d-38bf5662a3bmr28639528f8f.19.1738086748881; Tue, 28 Jan 2025 09:52:28 -0800 (PST) Received: from [192.168.178.30] (p200300cccf399000c10fe8a4a2d3ec3e.dip0.t-ipconnect.de. [2003:cc:cf39:9000:c10f:e8a4:a2d3:ec3e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c2a188c33sm15038356f8f.53.2025.01.28.09.52.26 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jan 2025 09:52:28 -0800 (PST) From: epirat07@gmail.com To: FFmpeg development discussions and patches Date: Tue, 28 Jan 2025 18:52:26 +0100 X-Mailer: MailMate (1.14r6065) Message-ID: <7F6292FD-ED15-4A11-93B6-A6C78369E553@gmail.com> In-Reply-To: <20250128174911.11367-1-jamrial@gmail.com> References: <20250128174911.11367-1-jamrial@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avutil/downmix_info: check for side data allocation success before zeroing it X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 28 Jan 2025, at 18:49, James Almer wrote: > Fixes coverity #1641638. > > Signed-off-by: James Almer > --- > libavutil/downmix_info.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavutil/downmix_info.c b/libavutil/downmix_info.c > index feaee28493..7e6c3e854d 100644 > --- a/libavutil/downmix_info.c > +++ b/libavutil/downmix_info.c > @@ -30,7 +30,8 @@ AVDownmixInfo *av_downmix_info_update_side_data(AVFrame *frame) > if (!side_data) { > side_data = av_frame_new_side_data(frame, AV_FRAME_DATA_DOWNMIX_INFO, > sizeof(AVDownmixInfo)); > - memset(side_data->data, 0, sizeof(AVDownmixInfo)); > + if (side_data) > + memset(side_data->data, 0, sizeof(AVDownmixInfo)); > } > > if (!side_data) > -- > 2.48.1 LGTM > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".